🇵🇭Philippines @cleavinjosh

Hi,

The remaining issues are the line-length warnings on the src/Services/SoapClientManager.php file.

However, the comments themselves are within the 80 characters range; it was only flagged because of the spaces before the comment marker.

Should those comments be broken down?

Please check and advise. Thank you.

cleavinjosh → changed the visibility of the branch 3476328-fix-the-phpcs-issues to active.

Hi @anybody,

Thank you for your feedback, especially on the cspell issue. It is greatly appreciated!

Please review, check, and advise. Thank you.

Hi,

I am not sure if it is safe to change the "Aktion" and the "preconfiguration" being flagged so I just added them to a dictionary.

Please review, check, and advise on MR!4. Thank you.

No more cspell issues found.

No more phpcs issues found.

Hi,

Please review, check, and advise on MR!5. Thank you.

No more phpcs issues found.

cleavinjosh → changed the visibility of the branch 3476322-fix-the-phpcodesniffer-issues to hidden.

Hi

Please review, check, and, advise on MR!3. Thank you.

No more phpcs issues found.

cleavinjosh → changed the visibility of the branch 3477518-fix-the-phpcodesniffer-issues to hidden.

cleavinjosh → changed the visibility of the branch 3477489-phpcs-issues to hidden.

Hi,

Please review, check, and advise on MR!2. Thank you.

No more phpcs issues found.

The only file that should be updated is rssreadandprint.module.

cleavinjosh → changed the visibility of the branch 3373061-phpcs-issues to hidden.

Hi @avpaderno,

Please review, check, and advise. Thank you.

Hi,

Please review, check, and advise on MR!1. Thank you.

No more phpcs issues found.

List of phpcs issues found by Gitlab CI after the changes.

cleavinjosh → changed the visibility of the branch 3477484-phpcs-issues to hidden.

Hi,

Please check, review, and advise on MR!6. Thank you.

cleavinjosh → changed the visibility of the branch 3477267-phpcs-issues to hidden.

No more phpcs issues found.

Hi,

Please review, check, and advise on MR!2. Thank you.

No more phpcs issues found.

Hi,

Please review, check, and advise on MR!3. Thank you.

No more phpcs issues found.

Hi,

Please review, check, and advise on MR!4. Thank you.

No more phpcs issues found.

Hi @avpaderno,

Please review, check, and advise on MR!5. Thank you.

Only two files should be changed:

1. layout_builder_awesome_sections.module
2. /src/Plugin/Layout/AwesomeLayout.php

Hi @avpaderno,

Please review, check, and advise on MR!3. Thank you.

Hi @avpaderno,

Please review, check, and advise on MR!4. Thank you.

Hi @avpaderno,

Please review, check, and advise on MR!4. Thank you.

Hi @avpaderno,

I updated the issue summary. Please check and advise. Thank you.

Hi,

There might have been some composer dependency resolution issues.

I am not sure how to proceed.

Please check and advise. Thank you.

Hi,

There might have been some composer dependency resolution issues.

I am not sure how to proceed.

Please check and advise. Thank you.

Hi @avpaderno,

No phpcs issues were found by Gitlab CI even before the changes.

Please check and advise. Thank you.

cleavinjosh → changed the visibility of the branch 3477748-phpcs-issues to hidden.

cleavinjosh → changed the visibility of the branch 3477748-phpcs-issues to active.

Hi,

My apologies, there might have been some composer dependency resolution issues.

I am not sure how to proceed.

Please check and advise. Thank you.

Hi @avpaderno,

Please review, check, and advise on MR!2. Thank you.

No more phpcs issues found.

cleavinjosh → changed the visibility of the branch 3477024-phpcs-issues to active.

I'm not sure how to proceed. Sorry

Hi @avpaderno,

Please review, check, and advise on MR!3. Thank you.

No more phpcs issues found.

cleavinjosh → changed the visibility of the branch 3476609-fix-the-phpcodesniffer-issues to hidden.

cleavinjosh → changed the visibility of the branch 3476609-fix-phpcs-issues to active.

cleavinjosh → changed the visibility of the branch 3476609-fix-phpcs-issues to hidden.

Hi @avpaderno,

Please review, check and advise on MR!1. Thank you.

No more phpcs issues found.

cleavinjosh → changed the visibility of the branch 3476609-phpcs-issues to hidden.

List of phpcs issues found by Gitlab CI after the changes.

List of phpcs issues found by Gitlab CI before the changes.

cleavinjosh → changed the visibility of the branch 3476101-phpcs-issues to hidden.

Hi @avpaderno,

Please review, check, and advise. Thank you.

No more phpcs issues found.

List of phpcs issues found by Gitlab CI before the changes.