🇵🇭Philippines @cleavinjosh

penyaskito → credited cleavinjosh → .

Fixed most of the phpcs issues except for the class name:

➜  iotapay git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml ./

FILE: /Users/interns/Demo-site/drupal_11_test/install-dir/drupal_11_test_site/web/modules/contrib/iotapay/src/Plugin/Block/iota_donate.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------
 17 | ERROR | Class name must begin with a capital letter
 17 | ERROR | Class name must use UpperCamel naming without underscores
------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/interns/Demo-site/drupal_11_test/install-dir/drupal_11_test_site/web/modules/contrib/iotapay/src/Plugin/Block/iota_pay.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------
 17 | ERROR | Class name must begin with a capital letter
 17 | ERROR | Class name must use UpperCamel naming without underscores
---------------------------------------------------------------------------------------------------------------------------------------

Time: 200ms; Memory: 10MB

➜  iotapay git:(main) ✗

Please review. Thank you.

Hi,

Please, review, check, and advise on MR!1. Thank you.

No more phpcs issues found.

cleavinjosh → changed the visibility of the branch 3477524-phpcs-issues to hidden.

Only four files should be changed:

1. /src/Plugin/Block/GoogleMapBlock.php
2. /src/Form/GoogleMapList.php
3. /src/Form/EditLocation.php
4. /src/Form/AddLocation.php

cleavinjosh → made their first commit to this issue’s fork.

No more phpcs issues found.

cleavinjosh → changed the visibility of the branch 3475739-phpcs-issues to hidden.

Hi @amit.rawat777,

Thank you for providing a patch. I applied patch #7, it was applied smoothly and fixed most of the phpcs issues.

These are the remaining issues after I ran phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml:

➜  migration_tools git:(8.x-2.x) curl https://www.drupal.org/files/issues/2024-12-23/codstd-3359279-7.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 66525  100 66525    0     0   127k      0 --:--:-- --:--:-- --:--:--  127k
patching file CHANGELOG.md
patching file README.md
patching file migration_tools_example/migration/media_pdf_sample_csv.yml
patching file src/CheckFor.php
patching file src/Event/MessageEvent.php
patching file src/EventSubscriber/PostRowSave.php
patching file src/EventSubscriber/PrepareRow.php
patching file src/Form/MigrationToolsAdminForm.php
patching file src/Media.php
patching file src/Message.php
patching file src/Modifier/DomModifier.php
patching file src/Modifier/Modifier.php
patching file src/Modifier/SourceModifier.php
patching file src/Modifier/SourceModifierHtml.php
patching file src/Obtainer/Job.php
patching file src/Obtainer/ObtainArray.php
patching file src/Obtainer/ObtainCity.php
patching file src/Obtainer/ObtainCountry.php
patching file src/Obtainer/ObtainDate.php
patching file src/Obtainer/ObtainDateSpanish.php
patching file src/Obtainer/ObtainHtml.php
patching file src/Obtainer/ObtainImage.php
patching file src/Obtainer/ObtainImageFile.php
patching file src/Obtainer/ObtainLink.php
patching file src/Obtainer/ObtainLinkFile.php
patching file src/Obtainer/ObtainLocation.php
patching file src/Obtainer/ObtainPlainTextWithNewLines.php
patching file src/Obtainer/ObtainState.php
patching file src/Obtainer/ObtainTable.php
patching file src/Obtainer/ObtainTitle.php
patching file src/Obtainer/Obtainer.api.php
patching file src/Obtainer/Obtainer.php
patching file src/Operations.php
patching file src/Plugin/migrate/process/GateComparator.php
patching file src/Plugin/migrate/source/UrlList.php
patching file src/Plugin/migrate_plus/data_parser/Dom.php
patching file src/QpHtml.php
patching file src/Redirects.php
patching file src/SourceParser/HtmlBase.php
patching file src/SourceParser/Node.php
patching file src/StringTools.php
patching file src/Url.php
➜  migration_tools git:(8.x-2.x) ✗
➜  migration_tools git:(8.x-2.x) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml ./

FILE: /Users/interns/Demo-site/drupal_11_test/install-dir/drupal_11_test_site/web/modules/contrib/migration_tools/src/StringTools.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
-------------------------------------------------------------------------------------------------------------------------------------
 132 | ERROR | Public method name "StringTools::convertFatalCharstoASCII" is not in lowerCamel format
 484 | ERROR | Public method name "StringTools::convertNonASCIItoASCII" is not in lowerCamel format
 530 | ERROR | Public method name "StringTools::stripWindowsCRChars" is not in lowerCamel format
-------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/interns/Demo-site/drupal_11_test/install-dir/drupal_11_test_site/web/modules/contrib/migration_tools/src/SourceParser/HtmlBase.php
-----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------------
 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\migrate\Row.
-----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/interns/Demo-site/drupal_11_test/install-dir/drupal_11_test_site/web/modules/contrib/migration_tools/src/Url.php
-----------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------
 259 | WARNING | There must be no blank line following an inline comment
-----------------------------------------------------------------------------------------------------------------------------


FILE: /Users/interns/Demo-site/drupal_11_test/install-dir/drupal_11_test_site/web/modules/contrib/migration_tools/src/Operations.php
------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------
 11 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\migrate\Row.
------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/interns/Demo-site/drupal_11_test/install-dir/drupal_11_test_site/web/modules/contrib/migration_tools/src/Message.php
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------
 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Render\FormattableMarkup.
-----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/interns/Demo-site/drupal_11_test/install-dir/drupal_11_test_site/web/modules/contrib/migration_tools/src/Obtainer/Obtainer.api.php
-----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------------
 11 | ERROR | Class name doesn't match filename; expected "class Obtainer.api"
-----------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/interns/Demo-site/drupal_11_test/install-dir/drupal_11_test_site/web/modules/contrib/migration_tools/src/Obtainer/ObtainPlainTextWithNewLines.php
--------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 3 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------------------------------------------------------------------------------------------
 133 | ERROR   | Protected method name "ObtainPlainTextWithNewLines::findSelectorNSeparator" is not in lowerCamel format
 171 | WARNING | Possible useless method overriding detected
 175 | ERROR   | Parameter $selector is not described in comment
 191 | WARNING | Possible useless method overriding detected
 210 | WARNING | Possible useless method overriding detected
--------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/interns/Demo-site/drupal_11_test/install-dir/drupal_11_test_site/web/modules/contrib/migration_tools/src/Obtainer/ObtainArray.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------
 77 | WARNING | There must be no blank line following an inline comment
----------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/interns/Demo-site/drupal_11_test/install-dir/drupal_11_test_site/web/modules/contrib/migration_tools/src/Obtainer/ObtainDate.php
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------
 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\migration_tools\Message.
---------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------

Time: 1.91 secs; Memory: 18MB

➜  migration_tools git:(8.x-2.x) ✗

Thank you.

Hi,

Please review, check, and advise on MR!27. Thank you.

No more phpcs issues found.

Hi,

The remaining issues are the line-length warnings on the src/Services/SoapClientManager.php file.

However, the comments themselves are within the 80 characters range; it was only flagged because of the spaces before the comment marker.

Should those comments be broken down?

Please check and advise. Thank you.

cleavinjosh → changed the visibility of the branch 3476328-fix-the-phpcs-issues to active.

Hi @anybody,

Thank you for your feedback, especially on the cspell issue. It is greatly appreciated!

Please review, check, and advise. Thank you.

Hi,

I am not sure if it is safe to change the "Aktion" and the "preconfiguration" being flagged so I just added them to a dictionary.

Please review, check, and advise on MR!4. Thank you.

No more cspell issues found.

No more phpcs issues found.

Hi,

Please review, check, and advise on MR!5. Thank you.

No more phpcs issues found.

cleavinjosh → changed the visibility of the branch 3476322-fix-the-phpcodesniffer-issues to hidden.

Hi

Please review, check, and, advise on MR!3. Thank you.

No more phpcs issues found.

cleavinjosh → changed the visibility of the branch 3477518-fix-the-phpcodesniffer-issues to hidden.

cleavinjosh → changed the visibility of the branch 3477489-phpcs-issues to hidden.

Hi,

Please review, check, and advise on MR!2. Thank you.

No more phpcs issues found.

The only file that should be updated is rssreadandprint.module.

cleavinjosh → changed the visibility of the branch 3373061-phpcs-issues to hidden.

Hi @avpaderno,

Please review, check, and advise. Thank you.

Hi,

Please review, check, and advise on MR!1. Thank you.

No more phpcs issues found.

List of phpcs issues found by Gitlab CI after the changes.

cleavinjosh → changed the visibility of the branch 3477484-phpcs-issues to hidden.

Hi,

Please check, review, and advise on MR!6. Thank you.

cleavinjosh → changed the visibility of the branch 3477267-phpcs-issues to hidden.

No more phpcs issues found.

Hi,

Please review, check, and advise on MR!2. Thank you.

No more phpcs issues found.

Hi,

Please review, check, and advise on MR!3. Thank you.

No more phpcs issues found.

Hi,

Please review, check, and advise on MR!4. Thank you.

No more phpcs issues found.

Hi @avpaderno,

Please review, check, and advise on MR!5. Thank you.

Only two files should be changed:

1. layout_builder_awesome_sections.module
2. /src/Plugin/Layout/AwesomeLayout.php

Hi @avpaderno,

Please review, check, and advise on MR!3. Thank you.

Hi @avpaderno,

Please review, check, and advise on MR!4. Thank you.

Hi @avpaderno,

Please review, check, and advise on MR!4. Thank you.

Hi @avpaderno,

I updated the issue summary. Please check and advise. Thank you.

Hi,

There might have been some composer dependency resolution issues.

I am not sure how to proceed.

Please check and advise. Thank you.

Hi,

There might have been some composer dependency resolution issues.

I am not sure how to proceed.

Please check and advise. Thank you.

Hi @avpaderno,

No phpcs issues were found by Gitlab CI even before the changes.

Please check and advise. Thank you.

cleavinjosh → changed the visibility of the branch 3477748-phpcs-issues to hidden.

cleavinjosh → changed the visibility of the branch 3477748-phpcs-issues to active.

Hi,

My apologies, there might have been some composer dependency resolution issues.

I am not sure how to proceed.

Please check and advise. Thank you.

Hi @avpaderno,

Please review, check, and advise on MR!2. Thank you.

No more phpcs issues found.

cleavinjosh → changed the visibility of the branch 3477024-phpcs-issues to active.

I'm not sure how to proceed. Sorry