- Issue created by @sunil jolapara
- Merge request !3Resolve #3476682 "Fix the issues reported by phpcodesniffer" ā (Open) created by sunil jolapara
- šŗšøUnited States sunil jolapara 3265 Summitrun Drive, Independence, KY, 41051
- šµšPhilippines cleavinjosh
Hi @sunil jolapara,
Thank you for providing an MR. I applied MR!3, it was applied smoothly and fixed the phpcs issues.
ā media_contextual_crop_iwc_adapter git:(1.0.x) curl https://git.drupalcode.org/project/media_contextual_crop_iwc_adapter/-/merge_requests/3.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 10203 0 10203 0 0 26520 0 --:--:-- --:--:-- --:--:-- 26501 patching file .gitlab-ci.yml patching file composer.json patching file media_contextual_crop_iwc_adapter.info.yml patching file media_contextual_crop_iwc_adapter.module patching file src/Plugin/MediaContextualCrop/ImageWidgetCrop.php ā media_contextual_crop_iwc_adapter git:(1.0.x) ā .. ā contrib git:(main) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml media_contextual_crop_iwc_adapter ā contrib git:(main) ā
Thank you.
- š®š¹Italy apaderno Brescia, š®š¹
The issue summary for PHP_CodeSniffer issues should always show the report given from PHP_CodeSniffer and the arguments passed to
phpcs
.Furthermore, since GitLab CI is now enabled for all the projects, GitLab CI should be used to get PHP_CodeSniffer errors/warnings.
- Issue was unassigned.
- Status changed to Needs review
3 months ago 10:27am 12 December 2024 - š«š·France DrDam
Can you make the MR for the 2.x branch ?
the 1.x branch are minimaly maintained now
thanks
- š®š¹Italy apaderno Brescia, š®š¹
The issue summary still needs to be updated, since it should link to the GitLab CI report.
- š®š¹Italy apaderno Brescia, š®š¹
avpaderno ā changed the visibility of the branch 3476682-fix-the-issues to hidden.
- š®š¹Italy apaderno Brescia, š®š¹
@drdam May the 2.0.x branch be set as the default one?
- šµšPhilippines cleavinjosh
Hi,
My apologies, there might have been some composer dependency resolution issues.
I am not sure how to proceed.
Please check and advise. Thank you.
- Merge request !5Created a new merge request to get the list of all the PHP_CodeSniffer errors/warnings to fix ā (Open) created by apaderno
- š®š¹Italy apaderno Brescia, š®š¹
avpaderno ā changed the visibility of the branch 3476682-gitlab-ci-reports to hidden.
- š®š¹Italy apaderno Brescia, š®š¹
avpaderno ā changed the visibility of the branch 3476682-2.0.x-fix-phpcs-issues to hidden.
- š®š¹Italy apaderno Brescia, š®š¹
avpaderno ā changed the visibility of the branch 3476682-2.0.x-fix-phpcs-issues to active.
- Merge request !6Issue #3476682: Fix the issues reported by PHP_CodeSniffer ā (Open) created by apaderno
- š®š¹Italy apaderno Brescia, š®š¹
avpaderno ā changed the visibility of the branch 3476682-fix-phpcs-issues to hidden.