Fix the issues reported by PHP_CodeSniffer

Created on 28 September 2024, about 2 months ago

Problem/Motivation

FILE: rssreader\css\custom.css
--------------------------------------------------------------------------------
FOUND 35 ERRORS AFFECTING 25 LINES
--------------------------------------------------------------------------------
1 | ERROR | [x] Multiple selectors should each be on a single line
1 | ERROR | [x] Expected 1 space before opening brace of class definition; 0
| | found
2 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
4 | ERROR | [x] Multiple selectors should each be on a single line
4 | ERROR | [x] Expected 1 space before opening brace of class definition; 0
| | found
5 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
8 | ERROR | [x] Multiple selectors should each be on a single line
8 | ERROR | [x] Expected 1 space before opening brace of class definition; 0
| | found
9 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
11 | ERROR | [x] Multiple selectors should each be on a single line
11 | ERROR | [x] Expected 1 space before opening brace of class definition; 0
| | found
12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
15 | ERROR | [x] Multiple selectors should each be on a single line
15 | ERROR | [x] Expected 1 space before opening brace of class definition; 0
| | found
16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
18 | ERROR | [x] Multiple selectors should each be on a single line
18 | ERROR | [x] Expected 1 space before opening brace of class definition; 0
| | found
19 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
22 | ERROR | [x] Multiple selectors should each be on a single line
22 | ERROR | [x] Expected 1 space before opening brace of class definition; 0
| | found
23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
27 | ERROR | [x] Multiple selectors should each be on a single line
27 | ERROR | [x] Expected 1 space before opening brace of class definition; 0
| | found
28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
30 | ERROR | [x] Expected 1 space before opening brace of class definition; 0
| | found
31 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
33 | ERROR | [x] Multiple selectors should each be on a single line
33 | ERROR | [x] Expected 1 space before opening brace of class definition; 0
| | found
34 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
34 | ERROR | [ ] Style definitions must end with a semicolon
35 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 34 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: rssreader\rssreadandprint.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by
| | drupal.org packaging automatically
--------------------------------------------------------------------------------

FILE: rssreader\rssreadandprint.libraries.yml
---------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------
9 | ERROR | [x] Expected 1 newline at end of file; 0 found
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------

FILE: rssreader\rssreadandprint.module
--------------------------------------------------------------------------------
FOUND 7 ERRORS AND 1 WARNING AFFECTING 7 LINES
--------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
4 | WARNING | [x] Unused use statement
6 | ERROR | [x] Missing function doc comment
7 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
8 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
9 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
10 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Steps to reproduce

Run phpcs command to get the drupal coding standard issues.

Proposed resolution

Many of the issues can be fixed by running the phpcbf command. For the remaining ones, we will need to manually address and then commit these changes before pushing them.

📌 Task
Status

Needs work

Version

1.0

Component

Code

Created by

🇺🇸United States sunil jolapara 3265 Summitrun Drive, Independence, KY, 41051

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024