Fix the issues reported by PHP_CodeSniffer

The issue summary for PHP_CodeSniffer issues should always show the report given from PHP_CodeSniffer and the arguments passed to phpcs.

Furthermore, since GitLab CI is now enabled for all the projects, GitLab CI should be used to get PHP_CodeSniffer errors/warnings.

Hi @sunil jolapara,

Thank you for providing an MR. I applied MR!3, it was applied smoothly and fixed most of the phpcs issues.

These are the remaining issues after I ran phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml:

➜  account_modal git:(8.x-1.x) curl https://git.drupalcode.org/project/account_modal/-/merge_requests/3.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 14882    0 14882    0     0  35167      0 --:--:-- --:--:-- --:--:-- 35182
patching file account_modal.install
patching file account_modal.module
patching file src/AccountModalAjaxHelper.php
patching file src/AccountPageHelper.php
patching file src/Event/PagesEvent.php
➜  account_modal git:(8.x-1.x) ✗ ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml account_modal

FILE: /Users/interns/Demo-site/drupal_11_test/install-dir/drupal_11_test_site/web/modules/contrib/account_modal/src/AccountPageHelper.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
 135 | WARNING | Unused variable $pageId.
-----------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/interns/Demo-site/drupal_11_test/install-dir/drupal_11_test_site/web/modules/contrib/account_modal/src/Form/AccountModalSettingsForm.php
-----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------
  95 | WARNING | #options values usually have to run through t() for translation
  96 | WARNING | #options values usually have to run through t() for translation
 103 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-----------------------------------------------------------------------------------------------------------------------------------------------------

Time: 336ms; Memory: 12MB

➜  contrib git:(main) ✗

List of phpcs issues found by Gitlab CI before the changes.

cleavinjosh → changed the visibility of the branch 3476664-phpcs-issues to hidden.

List of phpcs issues found by Gitlab CI after the changes.

No more phpcs issues found.

Hi,

Please review MR!3. Thank you.