- Issue created by @sunil jolapara
- Merge request !2Resolve #3477163 "Fix the phpcodesniffer issues" ā (Open) created by sunil jolapara
- šŗšøUnited States sunil jolapara 3265 Summitrun Drive, Independence, KY, 41051
- š®š¹Italy apaderno Brescia, š®š¹
The issue summary for PHP_CodeSniffer issues should always show the report given from PHP_CodeSniffer and the arguments passed to
phpcs
.Furthermore, since GitLab CI is now enabled for all the projects, GitLab CI should be used to get PHP_CodeSniffer errors/warnings.
- šµšPhilippines cleavinjosh
Hi @sunil jolapara,
Thank you for providing an MR. I applied MR!2, it was applied smoothly and fixed most of the phpcs issues.
ā masonry_view_style git:(8.x-1.x) curl https://git.drupalcode.org/project/masonry_view_style/-/merge_requests/2.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 3308 0 3308 0 0 7665 0 --:--:-- --:--:-- --:--:-- 7675 patching file README.txt patching file masonry_view_style.module patching file src/Plugin/views/style/Masonry.php ā masonry_view_style git:(8.x-1.x) ā .. ā contrib git:(main) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml masonry_view_style FILE: /Users/interns/Demo-site/drupal_11_test/install-dir/drupal_11_test_site/web/modules/contrib/masonry_view_style/masonry_view_style.info.yml ------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------ 7 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" ------------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal_11_test/install-dir/drupal_11_test_site/web/modules/contrib/masonry_view_style/masonry_view_style.module ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------- 18 | WARNING | Unused variable $options. ---------------------------------------------------------------------------------------------------------------------------------------------- Time: 165ms; Memory: 10MB ā contrib git:(main) ā
Thank you.
- Merge request !3Created a new merge request to get the list of all the PHP_CodeSniffer errors/warnings to fix ā (Open) created by cleavinjosh
- šµšPhilippines cleavinjosh
- šµšPhilippines cleavinjosh
cleavinjosh ā changed the visibility of the branch 3477163-phpcs-issues to hidden.
- šµšPhilippines cleavinjosh
Hi,
Please review MR!2, no issues were found in Gitlab CI after the changes while there are still issues found in local.
Please check and advise.
Thank you.