Fix the issues reported by PHP_CodeSniffer

The issue summary for PHP_CodeSniffer issues should always show the report given from PHP_CodeSniffer and the arguments passed to phpcs.

Furthermore, since GitLab CI is now enabled for all the projects, GitLab CI should be used to get PHP_CodeSniffer errors/warnings.

cleavinjosh → changed the visibility of the branch 3477748-phpcs-issues to hidden.

No phpcs issues were found by Gitlab CI before changes.

Hi @sunil jolapara,

Thank you for providing an MR. I applied MR!2, it was applied smoothly and fixed most of the phpcs issues.

These are the remaining issues after I ran phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml:

➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml s3_db_export

FILE: /Users/interns/Demo-site/drupal_11_test/install-dir/drupal_11_test_site/web/modules/contrib/s3_db_export/README.md
------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
 87 | WARNING | Line exceeds 80 characters; contains 85 characters
------------------------------------------------------------------------------------------------------------------------


FILE: /Users/interns/Demo-site/drupal_11_test/install-dir/drupal_11_test_site/web/modules/contrib/s3_db_export/src/Controller/DbExport.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------
 59 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------------------------------------------

Time: 163ms; Memory: 10MB

➜  contrib git:(main) ✗

Thank you.

cleavinjosh → changed the visibility of the branch 3477748-phpcs-issues to active.

cleavinjosh → changed the visibility of the branch 3477748-phpcs-issues to hidden.

Hi,

Please check and advise on MR!1, no issues were found by Gitlab CI but in local there are two.

Thank you.

The issue summary still needs to be updated: The PHP_CodeSniffer report is wrong or it is not a report for a branch, since the info.yml file does not contain the reported lines.