- Issue created by @sunil jolapara
- Merge request !1Resolve #3477024 "Fix the phpcodesniffer issues" ā (Open) created by sunil jolapara
- šŗšøUnited States sunil jolapara 3265 Summitrun Drive, Independence, KY, 41051
- š®š¹Italy apaderno Brescia, š®š¹
The issue summary for PHP_CodeSniffer issues should always show the report given from PHP_CodeSniffer and the arguments passed to
phpcs
.Furthermore, since GitLab CI is now enabled for all the projects, GitLab CI should be used to get PHP_CodeSniffer errors/warnings.
- Assigned to cleavinjosh
- Status changed to Needs review
3 months ago 10:32am 12 December 2024 - šµšPhilippines cleavinjosh
Hi @sunil jolapara,
Thank you for providing an MR. I applied MR!1, it was applied smoothly and fixed most of the phpcs issues.
These are the remaining issues after I ran
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml
:ā contrib git:(main) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml ckeditor_tweetthis FILE: /Users/interns/Demo-site/drupal_11_test/install-dir/drupal_11_test_site/web/modules/contrib/ckeditor_tweetthis/ckeditor_tweetthis.info.yml ------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------ 9 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" ------------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal_11_test/install-dir/drupal_11_test_site/web/modules/contrib/ckeditor_tweetthis/src/Plugin/CKEditorPlugin/TweetThis.php ------------------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------------------ 54 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead ------------------------------------------------------------------------------------------------------------------------------------------------------------ Time: 182ms; Memory: 10MB ā contrib git:(main) ā
- Merge request !2Created a new merge request to get the list of all the PHP_CodeSniffer errors/warnings to fix ā (Open) created by cleavinjosh
- šµšPhilippines cleavinjosh
cleavinjosh ā changed the visibility of the branch 3477024-phpcs-issues to hidden.
- šµšPhilippines cleavinjosh
Hi,
Please review, check and advise on MR!1. Thank you.
- š®š¹Italy apaderno Brescia, š®š¹
The issue summary must still be updated. The supported branch is 2.x.
- šµšPhilippines cleavinjosh
cleavinjosh ā changed the visibility of the branch 3477024-phpcs-issues to active.
- š®š¹Italy apaderno Brescia, š®š¹
avpaderno ā changed the visibility of the branch 3477024-fix-the-phpcodesniffer-issues to hidden.
- šµšPhilippines cleavinjosh
Hi @avpaderno,
Please review, check, and advise on MR!2. Thank you.