Fix the issues reported by PHP_CodeSniffer

sunil jolapara → changed the visibility of the branch 3476322-fix-the-phpcodesniffer-issues to hidden.

The issue summary for PHP_CodeSniffer issues should always show the report given from PHP_CodeSniffer and the arguments passed to phpcs.

Furthermore, since GitLab CI is now enabled for all the projects, GitLab CI should be used to get PHP_CodeSniffer errors/warnings.

MR!2 will be merged to 8.x-1.x

Hi @sunil jolapara,

Thank you for providing an MR. I applied MR!2 on 3.0.x, it was not applied smoothly.

➜  city_weather_field git:(3.0.x) curl https://git.drupalcode.org/project/city_weather_field/-/merge_requests/2.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 10664    0 10664    0     0  26254      0 --:--:-- --:--:-- --:--:-- 26266
patching file README.md
patching file city_weather_field.info.yml
Reversed (or previously applied) patch detected!  Assume -R? [n] -R
Apply anyway? [n] n
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file city_weather_field.info.yml.rej
patching file city_weather_field.module
Hunk #1 FAILED at 50.
1 out of 1 hunk FAILED -- saving rejects to file city_weather_field.module.rej
patching file src/Form/WeatherSettingsForm.php
patching file src/Plugin/Field/FieldFormatter/WeatherFieldFormatter.php
patching file src/Plugin/Field/FieldType/WeatherFieldType.php
patching file src/Plugin/Field/FieldWidget/WeatherFieldWidget.php
patching file src/WeatherService.php
Hunk #2 FAILED at 32.
1 out of 2 hunks FAILED -- saving rejects to file src/WeatherService.php.rej
➜  city_weather_field git:(3.0.x) ✗

I applied it to 8.x-1.x, it was applied smoothly and fixed most of the phpcs issues.
This is the remaining issue after I ran phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml:

➜  city_weather_field git:(8.x-1.x) ✗ curl https://git.drupalcode.org/project/city_weather_field/-/merge_requests/2.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 10664    0 10664    0     0  26001      0 --:--:-- --:--:-- --:--:-- 26073
patching file README.md
patching file city_weather_field.info.yml
patching file city_weather_field.module
patching file src/Form/WeatherSettingsForm.php
patching file src/Plugin/Field/FieldFormatter/WeatherFieldFormatter.php
patching file src/Plugin/Field/FieldType/WeatherFieldType.php
patching file src/Plugin/Field/FieldWidget/WeatherFieldWidget.php
patching file src/WeatherService.php
➜  city_weather_field git:(8.x-1.x) ✗ ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml city_weather_field

FILE: /Users/interns/Demo-site/drupal_11_test/install-dir/drupal_11_test_site/web/modules/contrib/city_weather_field/src/WeatherService.php
-------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------
 70 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------------------------------------------------------------------

Time: 163ms; Memory: 10MB

➜  contrib git:(main) ✗

cleavinjosh → changed the visibility of the branch 3476322-phpcs-issues to hidden.

Hi,

Please check and advise on MR!2.

Thank you.

The issue summary must still be updated: Neither in the 8.x-1.x branch, nor in the 3.0.x branch the .yml file contains a project, datetime, or version line.

Only a branch is supported. The unsupported branch is no longer changed.
The list of the errors/warnings to fix should be given by GitLab CI.

Hi,

There might have been some composer dependency resolution issues.

I am not sure how to proceed.

Please check and advise. Thank you.

No more phpcs issues found.

Hi,

Please review, check, and advise on MR!4. Thank you.

avpaderno → changed the visibility of the branch 3476322-gitlab-ci-reports to hidden.

MR!4 was created just to get the list of the errors/warnings to fix.

cleavinjosh → changed the visibility of the branch 3476322-fix-the-phpcodesniffer-issues to hidden.

No more phpcs issues found.

Hi,

Please review, check, and advise on MR!5. Thank you.