- Issue created by @sunil jolapara
- Merge request !4Resolve #3476989 "Fix the phpcodesniffer issues" ā (Open) created by sunil jolapara
- šŗšøUnited States sunil jolapara 3265 Summitrun Drive, Independence, KY, 41051
- šµšPhilippines cleavinjosh
Hi @sunil jolapara,
Thank you for providing an MR. I applied MR!4, it was applied smoothly and fixed most of the phpcs issues.
This is the remaining issue after I ran
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml
:ā address_dawa git:(2.0.1) curl https://git.drupalcode.org/project/address_dawa/-/merge_requests/4.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 5125 0 5125 0 0 8212 0 --:--:-- --:--:-- --:--:-- 8213 patching file src/Controller/AddressDAWAController.php patching file src/Plugin/Field/FieldFormatter/AddressDawaFormatter.php patching file src/Plugin/Field/FieldType/AddressDawaItem.php patching file src/Plugin/Field/FieldWidget/AddressDawaWidget.php patching file tests/src/FunctionalJavascript/AddressDawaFieldTest.php ā address_dawa git:(2.0.1) ā .. ā contrib git:(main) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml address_dawa FILE: /Users/interns/Demo-site/drupal_11_test/install-dir/drupal_11_test_site/web/modules/contrib/address_dawa/src/Plugin/Field/FieldType/AddressDawaItem.php ------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------------------- 180 | ERROR | unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option. ------------------------------------------------------------------------------------------------------------------------------------------------------------- Time: 334ms; Memory: 10MB ā contrib git:(main) ā
Thank you.
- š®š¹Italy apaderno Brescia, š®š¹
The issue summary for PHP_CodeSniffer issues should always show the report given from PHP_CodeSniffer and the arguments passed to
phpcs
.Furthermore, since GitLab CI is now enabled for all the projects, GitLab CI should be used to get PHP_CodeSniffer errors/warnings.
- Merge request !5Created a new merge request to get the list of all the PHP_CodeSniffer errors/warnings to fix ā (Open) created by cleavinjosh
- šµšPhilippines cleavinjosh
- šµšPhilippines cleavinjosh
cleavinjosh ā changed the visibility of the branch 3476989-phpcs-issues to hidden.
- šµšPhilippines cleavinjosh