- Issue created by @sunil jolapara
- Status changed to Needs review
7 months ago 9:57am 20 September 2024 - šŗšøUnited States sunil jolapara 3265 Summitrun Drive, Independence, KY, 41051
- šµšPhilippines clarkssquared
Hi
I tested your MR !3 and I can still see some PHPCS issues in the module
ā paragraphs_summary git:(main) ā curl https://git.drupalcode.org/project/paragraphs_summary/-/merge_requests/3.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 4231 0 4231 0 0 6990 0 --:--:-- --:--:-- --:--:-- 7039 patching file 'src/Plugin/Field/FieldFormatter/ParagraphsSummaryFormatter.php' ā paragraphs_summary git:(main) ā .. ā contrib git:(main) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml paragraphs_summary FILE: ...l_local/web/modules/contrib/paragraphs_summary/paragraphs_summary.info.yml -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | WARNING | Remove "project" from the info file, it will be added by | | drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by | | drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by | | drupal.org packaging automatically -------------------------------------------------------------------------------- FILE: ...phs_summary/src/Plugin/Field/FieldFormatter/ParagraphsSummaryFormatter.php -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 12 WARNINGS AFFECTING 12 LINES -------------------------------------------------------------------------------- 132 | WARNING | \Drupal calls should be avoided in classes, use dependency | | injection instead 144 | WARNING | t() calls should be avoided in classes, use | | \Drupal\Core\StringTranslation\StringTranslationTrait and | | $this->t() instead 148 | WARNING | t() calls should be avoided in classes, use | | \Drupal\Core\StringTranslation\StringTranslationTrait and | | $this->t() instead 152 | WARNING | t() calls should be avoided in classes, use | | \Drupal\Core\StringTranslation\StringTranslationTrait and | | $this->t() instead 160 | WARNING | t() calls should be avoided in classes, use | | \Drupal\Core\StringTranslation\StringTranslationTrait and | | $this->t() instead 166 | WARNING | t() calls should be avoided in classes, use | | \Drupal\Core\StringTranslation\StringTranslationTrait and | | $this->t() instead 180 | WARNING | \Drupal calls should be avoided in classes, use dependency | | injection instead 183 | WARNING | t() calls should be avoided in classes, use | | \Drupal\Core\StringTranslation\StringTranslationTrait and | | $this->t() instead 190 | WARNING | t() calls should be avoided in classes, use | | \Drupal\Core\StringTranslation\StringTranslationTrait and | | $this->t() instead 197 | WARNING | t() calls should be avoided in classes, use | | \Drupal\Core\StringTranslation\StringTranslationTrait and | | $this->t() instead 200 | WARNING | t() calls should be avoided in classes, use | | \Drupal\Core\StringTranslation\StringTranslationTrait and | | $this->t() instead 201 | WARNING | t() calls should be avoided in classes, use | | \Drupal\Core\StringTranslation\StringTranslationTrait and | | $this->t() instead -------------------------------------------------------------------------------- Time: 215ms; Memory: 10MB ā contrib git:(main) ā
- š®š¹Italy apaderno Brescia, š®š¹
The issue summary for PHP_CodeSniffer issues should always show the report given from PHP_CodeSniffer and the arguments passed to
phpcs
.Furthermore, since GitLab CI is now enabled for all the projects, GitLab CI should be used to get PHP_CodeSniffer errors/warnings.
- Assigned to cleavinjosh
- Status changed to Needs work
3 months ago 7:54pm 26 December 2024 - Merge request !4Created a new merge request to get the list of all the PHP_CodeSniffer errors/warnings to fix ā (Open) created by cleavinjosh
- šµšPhilippines cleavinjosh
cleavinjosh ā changed the visibility of the branch 3475739-phpcs-issues to hidden.
-
opi ā
committed 63f40b81 on 1.x authored by
sunil jolapara ā
Resolve #3475739 "Fix phpcodesniffer issues"
-
opi ā
committed 63f40b81 on 1.x authored by
sunil jolapara ā
- š«š·France opi
Thanks everyone ; Merge train has arrived, I will create a new minor release.
Automatically closed - issue fixed for 2 weeks with no activity.