Account created on 22 March 2008, over 16 years ago
#

Merge Requests

Recent comments

πŸ‡«πŸ‡·France opi

Thanks for your work, for D11 & module weight issue ! much appreciate

πŸ‡«πŸ‡·France opi

Thanks for this work ;

I think menu_link_attributes deserves a 8.x-1.4 release, as some nice improvements are already merged : https://git.drupalcode.org/project/menu_link_attributes/-/compare/8.x-1....

πŸ‡«πŸ‡·France opi

Thanks @berdir ; Could you please release a 2.0.2 version ? Thanks for all your Drupal work !

πŸ‡«πŸ‡·France opi

Actually the work has been done in #3433353, and already merged.

The only thing we need now is a maintainer to release a 2.0.2 version <3

πŸ‡«πŸ‡·France opi

opi β†’ made their first commit to this issue’s fork.

πŸ‡«πŸ‡·France opi

Same here, adding https://git.drupalcode.org/project/classy/-/merge_requests/5.patch to my composer.json makes upgrade_status module happy ! And it works well with my theme.

πŸ‡«πŸ‡·France opi

@mstrelan Thanks a lot ! I wasn't brave enough to rebase a 21KB patch last evening <3

πŸ‡«πŸ‡·France opi

I can confirm that manually update this module weight in the core.extensions.yml config file solve my issue where my meta description was always empty.

πŸ‡«πŸ‡·France opi

After some personnal debugging on 1.3 if found that the merge is missing. Sadly I looked at the issue queue only after that and found your patch !

This is a massive RTBC for me, allowing my client to use both menu_link_attributes and menu_firstchild on a multilingual D10 website.

Thanks for your work

πŸ‡«πŸ‡·France opi

You're right, I didn't realise this issue was that old !

Tested the Twixxx URL in issue summary and can't reproduce on 2.x branch.

Closed as outdated.

πŸ‡«πŸ‡·France opi

Why this patch was not included in the 2.0.0-alpha3 release yesterday ? Thanks a lot

πŸ‡«πŸ‡·France opi

opi β†’ made their first commit to this issue’s fork.

πŸ‡«πŸ‡·France opi

You're patch seems OK but there's one issue regarding coding standards. Please add a space before the opening brackets of your if condition.

πŸ‡«πŸ‡·France opi

Could not reproduce on a almost fresh D10 instance. Could it be possible that you have some field that is not attach to any bundle, or maybe a custom entity without bundles, or any specific case ?

@maintainers : do you want me to provide a patch with additional checks for NULL variables ?

πŸ‡«πŸ‡·France opi

Patch is working. Update title. Still RTBC !

πŸ‡«πŸ‡·France opi

Note that issue #2894351 also try to fix this bug. Patch 26 works pretty well with Seven/Claro/Gin admin theme

source: https://www.drupal.org/project/field_group/issues/2894351#comment-14394498 πŸ› Tabs with invalid input are not focused RTBC

πŸ‡«πŸ‡·France opi

Thanks @Antoniya for your more generic patch #26, works like a charm !

πŸ‡«πŸ‡·France opi

damn missing comma !

Thanks itamair for your time & patience <3

πŸ‡«πŸ‡·France opi

there it is

πŸ‡«πŸ‡·France opi

thanks for the input itamair, I will provide a full patch asap

πŸ‡«πŸ‡·France opi

fix syntax error in last patch

πŸ‡«πŸ‡·France opi

I'm not allowed to fork in Gitlab, so here is a good old patch file

πŸ‡«πŸ‡·France opi

opi β†’ created an issue.

πŸ‡«πŸ‡·France opi

Thanks @infrafusion. I'm back on my Drupal job, and trying to catch up. Currently playing with Gitlab to merge & release this Drupal 10 first stable version.

Production build 0.71.5 2024