🇫🇷France @opi

Use -dev version of diff module solve the same issue for me. The fix from #3167126 is commited but no release has been made.

The .patch was mostly created for quick composer patching ;)

Agreed with you for the 2 more hooks, according to my quick testing. Thanks for your fast reaction on this !

In the meantime, (Use at your own risks) this patch remove the _gin_toolbar_gin_is_active() check from gin_toolbar_theme_registry_alter().

haha sorry, mismatch between 10.5.0 and 11.2.0 ; I was talking about 11.2.0 in #2.

After some digging, it seems that after a cache flush the function gin_toolbar_theme_registry_alter() is run and the check introduced in https://git.drupalcode.org/project/gin_toolbar/-/commit/80e4caa863df5a0a... prevent altering the theme registry if a user without access to the toolbar call the website first. (_gin_toolbar_gin_is_active() will return FALSE)

Same here on Drupal 11.5.0 + Gin_Toolbar 3.0.1 ;

It seems that the third ".toolbar-tab" is missing the ".toolbar-tab--toolbar-item-administration" class to be visible

sorry, commnt mismatch.

- 3252288-50.patch is against 11.x
- 3252288-51_against_11.2.0.patch is against 11.2.0

Still NW because no test was added, but this patch applies on 11.x, from merge request https://git.drupalcode.org/project/drupal/-/merge_requests/12448

Patches #28 and #43 does not apply on 11.2 branch..

MR3 looks RTBC to me.

You're welcome. I guess this module deserve a patch release with all these fixed issues :-)

all green !!

opi → made their first commit to this issue’s fork.

Setting as need review. Another One Liner Commit !

opi → made their first commit to this issue’s fork.

so quick, thanks !

opi → created an issue.

Change the sub config_type to mapping do the trick, as mentionned in the change record https://www.drupal.org/node/3459863 →

See merge request MR8 https://git.drupalcode.org/project/symfony_mailer_log/-/merge_requests/8

opi → made their first commit to this issue’s fork.

indeed

Backported MR from https://www.drupal.org/project/symfony_mailer/issues/3511206#comment-161... ✨ How to add a custom header MessageStream: broadcast for Postmark? Active

Note that only text headers are supported. Maybe this Email Adjuster may be renamed "text header" instead of "custom header".

opi → made their first commit to this issue’s fork.

If needed, I've created a merge request to add a new email policy adjuster which allows to define a custom header from the UI : https://git.drupalcode.org/project/symfony_mailer/-/merge_requests/168

The merge request is against the 2.x branch, if anyone need this for 1.6.x here is the corresponding gist : https://gist.github.com/opi/a5a6d2cee2c2166709421d6f9a85aaeb

opi → made their first commit to this issue’s fork.

Succesfully tested with Drupal 11. Please create a D11 compatible release, thanks !

Thanks @smustgrave for the merges & release ! <3

MR 4 has been updated to be compatible with Drupal 11 because format_size() function is now remplaced by ByteSizeMarkup class.
See https://www.drupal.org/node/2999981 → change record for more information.

Please don't be so spammy, there is no benefit but wasting maintainers precisous time..

The original issue about deprecating this module was https://www.drupal.org/project/twitter_username/issues/3467028 🌱 deprecate this module Active , add any constructive comment there.

These options already exists in D10+, and the MailControl contrib module offers UI to disable these mail.

Maybe core could just document theses config options in the settings.php file to allow advanced site-builders to disable mails simply by uncommenting settings lines ? If no this issue could be closed...

see https://git.drupalcode.org/project/mailcontrol/-/blob/8.x-1.x/mailcontro...

Tested MR4 on a D10 + D11 stack with success.

I'll be glad to see a 2.x release with a nice D11 support soon. Please tell us if help is needed in any way.

Maybe this tag could be a settings in the field formatter ? because depending on the TypeForm form settings we should use tf-live or tf-widget...

what do you think ?

Sadly my own usage of typeform on https://www.france-justforyou.com/contact-us did not work when using data-tf-widget bu only with data-tf-live. I should investigate on my Typeform configuration..

Thanks for your report. I guess that both "live" and "widget" should work regarding https://community.typeform.com/share-your-typeform-6/what-is-the-differe...

I have to test it more deeply, but in the meantime you should override the typeformfield-embed.html.twig in your own theme rather than modifying the module own template file.

Merged in commit https://git.drupalcode.org/project/menu_firstchild/-/commit/246f809d5943...

Setting status as RTBC for a cleaner issue queue.

My tests with 2.2.0-alpha1 on D10/D11 are green btw, it may bump to beta or even stable ;)

Yay !! Thanks, my Upgrade_Status score is happier !

wow, you're so speed !! Thanks

opi → created an issue.

Tested on D11 and it works well.

Can we have a D11 release, even in alpha/beta ? Thanks a lot for your work

opi → created an issue.

Works well with D11.1.1 + IWC dev-2.x 2f10025 , thanks.

Duplicate of https://www.drupal.org/project/image_widget_crop/issues/3491004 🐛 Can't save image widget crop settings in Drupal 11 Active ?

Please do not forget the patch from #2910886 (long time RTBC issue) before crafting a Drupal11 release. Thanks a lot <3

Currently D10 version is fully installable with Composer ; We need a D11 release but is it already on track in #3431024 issue.

obivous and minimal change.. RTBC!

Thanks everyone ; Merge train has arrived, I will create a new minor release.

+1 for RTBC ; Hope a maintainer will find the time to create a release <3

thanks! Merged and released as 1.0.3

The fix commited on the 1.0.x branch have pleased packagist workflow, I can now update the field_time module, no need to create a dedicated release \o/

Merge request !2 from @tobiasb seems good !

Thanks for your work, for D11 & module weight issue ! much appreciate

See merge request https://git.drupalcode.org/project/vitals_extra/-/merge_requests/4 for testing, or apply the patch https://git.drupalcode.org/project/vitals_extra/-/merge_requests/4.patch

opi → created an issue.

Works fine for me !

opi → created an issue.

Thanks for this work ;

I think menu_link_attributes deserves a 8.x-1.4 release, as some nice improvements are already merged : https://git.drupalcode.org/project/menu_link_attributes/-/compare/8.x-1....

Thanks @berdir ; Could you please release a 2.0.2 version ? Thanks for all your Drupal work !

Actually the work has been done in #3433353, and already merged.

The only thing we need now is a maintainer to release a 2.0.2 version <3

opi → created an issue.

opi → made their first commit to this issue’s fork.

merged

Same here, adding https://git.drupalcode.org/project/classy/-/merge_requests/5.patch to my composer.json makes upgrade_status module happy ! And it works well with my theme.

@mstrelan Thanks a lot ! I wasn't brave enough to rebase a 21KB patch last evening <3

Anyone else struggling to patch against 10.3.0 ?

I can confirm that manually update this module weight in the core.extensions.yml config file solve my issue where my meta description was always empty.

After some personnal debugging on 1.3 if found that the merge is missing. Sadly I looked at the issue queue only after that and found your patch !

This is a massive RTBC for me, allowing my client to use both menu_link_attributes and menu_firstchild on a multilingual D10 website.

Thanks for your work

You're right, I didn't realise this issue was that old !

Tested the Twixxx URL in issue summary and can't reproduce on 2.x branch.

Closed as outdated.

Why this patch was not included in the 2.0.0-alpha3 release yesterday ? Thanks a lot

fgm → credited opi → .

saschaeggi → credited opi → .

Fixed in https://git.drupalcode.org/project/views_pager_as_block/-/merge_requests/1

opi → made their first commit to this issue’s fork.

opi → created an issue.

thanks!

You're patch seems OK but there's one issue regarding coding standards. Please add a space before the opening brackets of your if condition.

Could not reproduce on a almost fresh D10 instance. Could it be possible that you have some field that is not attach to any bundle, or maybe a custom entity without bundles, or any specific case ?

@maintainers : do you want me to provide a patch with additional checks for NULL variables ?

opi → created an issue.

Patch is working. Update title. Still RTBC !

Note that issue #2894351 also try to fix this bug. Patch 26 works pretty well with Seven/Claro/Gin admin theme

source: https://www.drupal.org/project/field_group/issues/2894351#comment-14394498 🐛 Tabs with invalid input are not focused Postponed: needs info

Thanks @Antoniya for your more generic patch #26, works like a charm !

damn missing comma !

Thanks itamair for your time & patience <3

there it is

thanks for the input itamair, I will provide a full patch asap

fix syntax error in last patch

I'm not allowed to fork in Gitlab, so here is a good old patch file

opi → created an issue.

opi → created an issue.

Thanks @infrafusion. I'm back on my Drupal job, and trying to catch up. Currently playing with Gitlab to merge & release this Drupal 10 first stable version.

opi → created an issue.