Tabs with invalid input are not focused

Thanks @Antoniya for your more generic patch #26, works like a charm !

The patch on #26 breaks tests.

@rcodina I have also noticed the issue in the tests/src/Functional/MigrateUiFieldGroupTest.php file while executing the tests.
The error I saw is this one:

1) Drupal\Tests\field_group_migrate\Functional\MigrateUiFieldGroupTest::testFieldGroupMigrate
Undefined array key "Drupal\sqlite\Driver\Database\sqlite"

/var/www/html/web/modules/contrib/field_group/contrib/field_group_migrate/tests/src/Functional/MigrateUiFieldGroupTest.php:135
/var/www/html/web/modules/contrib/field_group/contrib/field_group_migrate/tests/src/Functional/MigrateUiFieldGroupTest.php:157
/var/www/html/web/modules/contrib/field_group/contrib/field_group_migrate/tests/src/Functional/MigrateUiFieldGroupTest.php:59
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

But it seems to be not related to the fix and issue. I have just added

$class_name = substr(strrchr($driver, '\\'), 1);
$form = $drivers[$class_name]->getFormOptions($connection_options);

Instead of at line 135 in field_group/contrib/field_group_migrate/tests/src/Functional/MigrateUiFieldGroupTest.php
:

$form = $drivers[$driver]->getFormOptions($connection_options);

@rcodina Could you please specify the error you see in the tests? Or could probably someone else test it also?

The patch on #26 works well for me.

Re-rolled the patch 23 against the new release 8.x-3.6

Re-rolled the patch 26 against the new release(3.6), branch 8.x-3.x.
Works on Drupal 10.3.0 with Gin admin theme.

#33 is working for me on Drupal core 10.3.2 an#33 is working for me on Drupal core 10.3.2 and field_group 3.6.0 with horizontal tabs.d field_group 3.6.0

Patch #33 working for Drupal 10.3 with version 8.x-3.6 module. I have created the merge request and it is ready for review.

Please use MR's!

Please check if this issue still exists in 4.x after 🐛 Ensure visibility of invalid fields (JS) Fixed has been merged now.

Hi.
I confirm that this bug is not reproduced in version 4.x-dev, so it is already fixed from this version onwards. Thanks!

Thanks @juandels3 so let's close this closed as duplicate! :)

I use the patch from the MR !71 on the version 3.6, but I found an issue with the submit button being targeted with not enough specificity.
I have an entity browser button on one of my tabs, and as soon as I click it, it goes back to my first tab.
The selector in the patch is not specific enough :
$(context).find('input.form-submit')

The entity browser also has the form-submit class, and a click on this button triggers the check for invalid fields.

This selector could be more appropriated :
$(context).find('input.form-submit.button--primary')

Or :
$(context).find('input.form-submit').not('.entity-browser-processed')

I'm not sure if this applies to the 4.x-dev version, as it seems to be treated in a different way.