🇫🇷France @clemorphy

Paris
Account created on 17 December 2020, over 4 years ago
#

Recent comments

🇫🇷France clemorphy Paris

This MR works and is absolutely necessary for csp_log to work with current version of the csp module. Without it we have a fatal error on the csp module settings page.

🇫🇷France clemorphy Paris

It seems that it "works as designed" 😅
It is because, on D10 (probably since D8 actually), it is not possible to redirect a content which has a path alias. It was possible with the D7 version of redirect module, but not anymore.
So before creating a redirect, we have to remove the path alias of the content. The redirect then works as expected.

Source :
https://www.drupal.org/project/redirect/issues/2879648 🐛 Redirects from aliased paths aren't triggered Needs review
https://www.drupal.org/project/redirect/issues/2821158 📌 Document that URL redirects work from node/{nid} but not alias Needs work

🇫🇷France clemorphy Paris

Hello @skoubi

No, still haven't found a solution...

🇫🇷France clemorphy Paris

I think it depends on the number of JS that need to be aggregated. So maybe also on the number of contrib modules that add a JS lib.

🇫🇷France clemorphy Paris

Ah funny that your are pointing JS aggregation, I was on that track too.
Actually I tested another contrib module that might better suit my needs ( CKEditor5 Custom Paste ) and it did exactly the same thing, as soon as I enable it, it crashes my CKEditor instances.
And at some point I tested with JS aggregation disabled, and it worked. I haven't tested again yet with CKEditor5 Paste Filter, but I think it will work too. But I don't really want to disable JS aggregation, so I searched more about it, and I found this 🐛 CKEditorError: plugincollection-plugin-not-found Needs work , which was fixed yesterday.
I tried on CKEditor5 Custom Paste to do the same. I replaced in the .libraries.yml :
js/build/pasteFilter.js: { preprocess: false, minified: true }
with
js/build/pasteFilter.js: { preprocess: true, minified: true }

And then enabled JS aggregation again. And it worked. Again, not tested yet on CKEditor5 Paste Filter, but I think it will fix it too.

🇫🇷France clemorphy Paris

After clearing caches do you see the same result?

Yes, first thing I tried was clearing caches. Same result.

What method are you using to install the module?

composer require 'drupal/ckeditor5_paste_filter:^1.0'
drush en ckeditor5_paste_filter
Can you be more specific about "trying to display a CKEditor field in the admin", is that something like editing a node with a body field, or is there custom code involved?

I'm trying to edit a paragraph on a node.

If you could write up steps to reproduce this from a clean install of Drupal that would be really helpful, since I'm not able to reproduce it in my testing. I tested with the same module and core versions (v1.0.1 on Drupal 10.3.5) but did not see any errorr, before or after clearing caches.

I tried a "SimplyTest" and of course it worked. I'm gonna try to disable other filters and/or contrib modules on my local installation, to see what could interfer.

Thank you.

🇫🇷France clemorphy Paris

Tested on Drupal 10.3.5, and I can confirm it doesn't have any effect too.
The pasted text coming from a Word document is still bloated with formats.

🇫🇷France clemorphy Paris

I use the patch from the MR !71 on the version 3.6, but I found an issue with the submit button being targeted with not enough specificity.
I have an entity browser button on one of my tabs, and as soon as I click it, it goes back to my first tab.
The selector in the patch is not specific enough :
$(context).find('input.form-submit')

The entity browser also has the form-submit class, and a click on this button triggers the check for invalid fields.

This selector could be more appropriated :
$(context).find('input.form-submit.button--primary')

Or :
$(context).find('input.form-submit').not('.entity-browser-processed')

I'm not sure if this applies to the 4.x-dev version, as it seems to be treated in a different way.

🇫🇷France clemorphy Paris

I have the same error when my deployment script imports FR translation for the webform module :

>  [notice] Importing fr translation for webform. (16%).
>  [error]  Import of string "<front>" was skipped because of disallowed or malformed HTML. 

And as this poduces an [error] tag, my deployment always fails because of this line. This is very inconvenient.

Can it be fixed so it doesn't produce this error?

🇫🇷France clemorphy Paris

Ok I know why.
The module is filtering alerts on the current language of the Drupal site (FR in my case), but the alert entities were created by default in EN language. I had to modify the default language used for the "Sitewide alert" content type, in my global language settings.

🇫🇷France clemorphy Paris

Why I need this :

I have a transition that allows a user to submit a content for review (draft -> needs_review)
I have another transition that allows and admin to "reject" a submitted content (needs_review -> draft), and an email is sent to the user with the reason for rejection (with workbench_email).
But I also want to allow my users to "cancel a submission" (needs-review -> draft), but this would be the same transition as "reject" so they will receive an email saying that their content has been rejected, while it wasn't the case.

🇫🇷France clemorphy Paris

So it seems that it wasn't made to be configurable, or removable.
I'll use hook_menu_local_tasks_alter()

🇫🇷France clemorphy Paris

Ah yes, ive fixed that - id need more time to look at writing a test.

I confirm that the error is gone with the updated MR!506
Thank you.

🇫🇷France clemorphy Paris

Thanks a lot aaron.ferris
I have tested your MR from #3, applied on version 6.2.7, and it works perfectly for me.

🇫🇷France clemorphy Paris

Thank you, snippet from #2 is working and just saved me some headache while trying to add classes on the rendering of the first item of a multi value image field.

{{ content.field_pictures.0|merge({'#item_attributes': {class: ['rounded-3', 'mb-3']}}) }}

Thank you for sharing this.

🇫🇷France clemorphy Paris

Well, I found that the xray_audit module already handles this, and it does a great job. I think I'm gonna stick with it.

🇫🇷France clemorphy Paris

Thank you @abhishek_gupta1 for your very quick reply.
I just tested your MR !28, it's working fine :)

🇫🇷France clemorphy Paris

Same as GaëlG.
MR from #5 tested and confirmed to work.
Waiting for this to be available in the next stable release.

🇫🇷France clemorphy Paris

I have this problem with 3.2.0.
When "enable fallback" is not checked, with JS disabled no captcha is displayed and I am able to submit the form.
When "enable fallback" is checked, with JS disabled a message "Please enable JavaScript to get a reCAPTCHA challenge." is displayed, but I am still able to submit the form. And that is an issue.

🇫🇷France clemorphy Paris

I wish I had a more precise way than #12 to disable specific purgers.
Relying on indexes is not very safe as it could change when you add purgers or change their order.
There should be a boolean on each purger to define if it is enabled or not.
But for now #12 is my only working option.

🇫🇷France clemorphy Paris

The issue was introduced by this patch : https://www.drupal.org/project/varnish_purge/issues/2843978 Multiple IP's for one varnish purger Needs review
When I remove the patch, it works again.

Too bad, this patch seemed to be a good way to target 2 varnish instances from 1 purger.

🇫🇷France clemorphy Paris

For me, using https://git.drupalcode.org/project/varnish_purge/-/merge_requests/11.patch introduces a bug.
It fails to correctly send ban requests, queue is not decreasing, varnish cache is never cleared. I have the following error in the cron logs :

Drupal\purge\Plugin\Purge\Purger\Exception\BadPluginBehaviorException : Only NOT_SUPPORTED, PROCESSING, SUCCEEDED and FAILED are valid outbound states. dans Drupal\purge\Plugin\Purge\Invalidation\InvalidationBase->setStateContext() (ligne 144 de /var/www/ppd/xxxxxxxxx/web/modules/contrib/purge/src/Plugin/Purge/Invalidation/InvalidationBase.php).

And I don't even have 2 hosts in my purger config.

🇫🇷France clemorphy Paris

I have the exact same issue but with 8.x-1.9 and D10.
The redirect doesn't work unless I navigate to the source url with an added slash at the end (even if the slash is NOT in the source url).
Navigating to the defined source url (without an ending slash) does not trigger the redirect.

🇫🇷France clemorphy Paris

Looking at

validateIsSupported()

it seems to look for $database['default']['prefix']['default'].
Shouldn't it look for $database['default']['default']['prefix']?

My db infos are defined like this :

$databases['default']['default']['database'] = "db";
$databases['default']['default']['username'] = "db";
$databases['default']['default']['password'] = "db";
$databases['default']['default']['host'] = $host;
$databases['default']['default']['driver'] = $driver;
$databases['default']['default']['port'] = $port;
$databases['default']['default']['prefix'] = '';

Drupal is ok with this, and it seems to be the recommended format.

🇫🇷France clemorphy Paris

Looking at validateIsSupported(), why does it look for $database['default']['prefix']['default']?
Shouldn't it look for $database['default']['default']['prefix'] ?

Production build 0.71.5 2024