- Issue created by @yannickoo
- Status changed to Needs review
11 months ago 11:39pm 1 September 2024 - Status changed to Needs work
11 months ago 9:44am 2 September 2024 - ๐บ๐ธUnited States damienmckenna NH, USA
Thank you for reporting the bug and for providing a possible fix.
I suspect the true source of this bug is a missing dependency.
- ๐ฉ๐ชGermany yannickoo Berlin
Thanks for the quick response! Yeah it seems all the other CKEditor plugins were unavailable for loading so the whole thing crashed :/
- ๐บ๐ธUnited States davedg629
This patch worked for me.
Seemed to be a conflict with CKEditor5 Fullscreen module, as uninstalled that module also resolved the issue.
- ๐ฉ๐ชGermany szeidler Berlin
I second @damienmckenna. It looks like a missing dependency. I tested around with the most likely suspects. It turned out setting
ckeditor5/internal.admin.image
as a dependency seems to fix the error. - Merge request !12Issue #3471500 by yannickoo, damienmckenna, davedg629, stomusic, szeidler:... โ (Open) created by szeidler
- ๐ฉ๐ชGermany szeidler Berlin
I created a MR + here's the attached patch. Thanks for a review.
- ๐บ๐ธUnited States davedg629
Replaced patch from #2 with patch from #9 and works great.
Thank you!
- ๐บ๐ธUnited States tim bozeman
tim bozeman โ changed the visibility of the branch 3471500-ckeditorerror-plugincollection-plugin-not-found to hidden.
- ๐บ๐ธUnited States tim bozeman
tim bozeman โ changed the visibility of the branch 3471500-ckeditorerror-plugincollection-plugin-not-found to active.
- ๐บ๐ธUnited States tim bozeman
The problem is with
JsCollectionGrouper
. When JS files are aggregated, say there are like 100 js files, they get grouped based on the library dependencies. Those 100 js files may be spit up into 5 groups of js files which ends up as 5 big JS files wrapped in an anonymous function to scope them altogether.All the CKEditor plugins like
alignment
andbold
andckeditor_media_resize
are their own separate JS files. Those little files arenโt being aggregated into the same larger aggregated JS file. You can tell this is true because when you turn off JS aggregation the files can see each other again and the error goes away.When we set
preprocess: false
we are forcing a new group (aggregated JS file). -
tim bozeman โ
committed 3a427b35 on 1.0.x
Issue #3471500 by szeidler, yannickoo, tim bozeman, davedg629, stomusic...
-
tim bozeman โ
committed 3a427b35 on 1.0.x
- ๐ซ๐ทFrance yonailo Paris
The fix committed as well as patch #9 don't work for me, the only thing that works is patch #2, I don't know why.
- ๐บ๐ธUnited States tim bozeman
Thanks for trying it. Do you have other JS libraries in your site that have
preprocess: false
in the definition? Try removing those and clearing caches if you do. I noticed editor_advanced_link does it too. You may be able to debugJsCollectionGrouper
and see what the offending library is that is putting ckeditor_media_resize in a group outside of the rest of the ckeditor libraries. - ๐ซ๐ทFrance yonailo Paris
Yes I am using "editor_advanced_link" module too, so does this mean that we should open an issue in "editor_advanced_link" in order to the preprocess: false to be removed ?
- ๐บ๐ธUnited States tim bozeman
Yes, especially if it fixes your error. Did it?
- Status changed to Fixed
9 months ago 5:14pm 19 November 2024 Automatically closed - issue fixed for 2 weeks with no activity.
- ๐ฎ๐ณIndia manojkumar_g
Hi,
I'm facing the same issue in Drupal CMS. I'm using the CKEditor 5, CKEditor Templates, CKEditor5 Fullscreen.Any patch for this error?