Whoopsie 😅
I think we got this one.
tim bozeman → created an issue.
Thank you
Thank you
tim bozeman → created an issue.
oh, right. Thank you :)
Heya Scott!
Thank you for pointing that out. Edit+ should be able to run without Layout builder, but I guess some hidden dependencies may have snuck in over time. I'll have to go through it all with a fine tooth comb one day and sprinkle around a bunch of if (layoutBuilder.isInstalled) all over.
tim bozeman → created an issue.
tim bozeman → created an issue.
You're welcome
tim bozeman → created an issue.
Ah yes, you're right those should totally be in composer.json.
Layout Builder + will soon not require Edit+, but it will require Navigation+ and twig_events. Both Edit+ and LB+ use the Layout Builder section storage and there are some things around that in Edit+ that should really be moved to Navigation+. It's on the todo list, but until then we unfortunately have a circular dependency on Navigation+ and Edit+ 😔
Sorry about that!
tim bozeman → created an issue.
Sorry about that! Is it working now? 😅
That project may need a new release too. I need to check.
I think the latest dev branch of Layout Builder 3.x is in pretty good shape.
Ah that sounds right. I'm sorry about that. I'll cut a new release!
Thank you!
Huh, that's crazy. Did you search for it? It should be listed under the Page Building group.
Ooo ya, I guess we broke that integration huh? You can see that in lb_plus_contextual_links_alter we are overriding the layout builder contextual links to add nested section storage support. That gives users the ability to place a block who's layout is managed with layout builder inside a layout. It makes for a block builder like functionality. Right now we have it to where block editing happens in the sidebar, but we are going to make that sidebar expandable and able to pop out into a modal and hopefully popout into another window too if that's possible.
Oh yeah, that's true. The section storage could totally be a third_party_setting. Nice catch!
Heya Milos,
Thanks for checking it out and sorry for the lack of documentation. I've been heads down getting this page builder suite ready for production and I haven't taken a look at the demo set up in quite a while. I'll give that all a once over and update the docs asap!
tim bozeman → created an issue.
tim bozeman → created an issue. See original summary → .
tim bozeman → created an issue.
tim bozeman → created an issue.
tim bozeman → created an issue.
Thanks!
Hmm. I'm on 3.34.0 and needed to use the patch when updating from Drupal 10.1 to 10.4 😅
tim bozeman → created an issue.
I think this one needs a rebase 🤪
Here's a re-roll of the MR against 10.4
tim bozeman → created an issue.
tim bozeman → created an issue. See original summary → .
Never!
tim bozeman → created an issue.
tim bozeman → created an issue.
tim bozeman → created an issue. See original summary → .
tim bozeman → created an issue.
Thanks for the report solideogloria! I think this was fixed in the latest dev version 😅
When we started writing these modules we were using Drupal core's toolbar module, so we called it toolbar_plus, but since we are moving to cores new navigation module we're going to rename toolbar_plus to navigation_plus → pretty soon.
Hmm, thanks for getting IEF complex going, but it seems to break regular non-IEF fields 😓
Also, this module is probably going to be moved to navigation_plus since we started using navigation when it came out.
There are still some sea change tasks coming up where this will be addressed.
Thank you Lucas! There's actually a bunch of technical debt around this one. Not totally sure what to do about in the meantime tbh.
Edit+ is a tool plugin for Toolbar+. So I think the info files are correct in that edit+ depends on toolbar+, but yeah there is definitely a hidden dependency. Would the two modules depending on each other cause a circular dependency? I've ran into that before, but not sure how I got there.
Edit+ and Layout Builder share a tempstore for hanging onto changes before the entity is saved. Because of the order that the modules were developed the tempstore handling is in Edit+ at the moment, but it should really be bubbled up to toolbar+.
Oops! Nice catch! Thank you.
tim bozeman → created an issue.
tim bozeman → created an issue.
tim bozeman → created an issue.
Have you narrowed down what character is the issue? Maybe there’s a way to detect invalid characters in a generic way. 🤔
tim bozeman → created an issue.
Maybe you could add a generator plugin that just returns nothing 😅