Let's roll with this first pass and add follow ups for new issues.
tim bozeman → made their first commit to this issue’s fork.
Heya Jim!
Thank you very much. I think you said that capability is available in 11.x which I am really psyched about! I need to get the +Suite up to date. To my chagrin, I have this recipe pinned to 10.x for the moment so I am unpacking in this install script. But yeah I should totally close this one as there isn't really anything to do here.
Added a core issue #3552744: Dispatch an event in twig_render_template →
@Pex Whatcha think? Does the use_twig_events flag suffice for now?
Also, before I forget. The plan to address this was 2 step approach.
1. Let's stop using twig_events_engine_render_template by adding a patch to core that dispatches an event in twig_render_template so we no longer need twig_events and avoid this problem space. We shouldn't require users to apply a core patch if we can avoid it though so in the meantime we can use a second approach.
2. Users when they use hook_theme can flag that this template should in fact use twig_events_engine_render_template and Navigation+ can ensure that it does.
function custom_module_theme($existing, $type, $theme, $path) {
return [
'block__inline_block__recipe' => [
'base hook' => 'block',
'path' => $path . '/templates',
'use_twig_events' => TRUE,
],
];
}Thanks Pex! I'm eager to see if this works!
I think that we can use `hook_entity_view_alter` instead of this event to wrap the entities.
I tried this approach at length when building it, but found that wrapping fields in the render function was the only way to wrap some types of templates.
I have a feeling this one has been fixed. Feel free to reopen if not
Thank you smustgrave
I added a test and it looks like they are all passing.
Added testing instructions.
Ah I am very sorry about that. I did have a D11 version going for a while, but I don't have a D11 site going and I know there is at least one issue 📌 Make compatible with core Navigation module D11.2.0 Active I need to address for it to work on 11.2, so I felt like I should temporarily remove the D11 release until I can dog food it and ensure it is actually working.
tim bozeman → created an issue.
tim bozeman → created an issue.
tim bozeman → created an issue.
tim bozeman → created an issue.
I used AI to extract the twig template editing feature from Component Library to a sub module, cl_override_mode. While this is a great start, it still needs some work.
tim bozeman → created an issue.
tim bozeman → created an issue.
tim bozeman → created an issue.
tim bozeman → made their first commit to this issue’s fork.
tim bozeman → made their first commit to this issue’s fork.
Very nice! Thank you!
tim bozeman → created an issue.
tim bozeman → created an issue.
tim bozeman → created an issue.
tim bozeman → created an issue.
Oh dear...
The branch seems pretty good to me, but the bot doesn't like it. I probably should not have rebased against the current 11.x? I'm not sure what to do about that. 😬
Here's testing that the editor:attached event is firing.
tim bozeman → created an issue.
tim bozeman → created an issue.
tim bozeman → created an issue.
tim bozeman → created an issue.
tim bozeman → created an issue.
tim bozeman → created an issue.
tim bozeman → created an issue.