Account created on 8 August 2012, over 12 years ago
#

Merge Requests

More

Recent comments

🇚ðŸ‡ļUnited States tim bozeman

Thank you very much!

I gave fixing this a try over on the navigation+ side 🐛 Save does not take effect until you click outside of the edit box Active by making the save button wait until the tempstore is done updating. Is that working for y'all?

🇚ðŸ‡ļUnited States tim bozeman

Thank you very much!!!

🇚ðŸ‡ļUnited States tim bozeman

Oh wow that’s crazy. I haven’t seen that one before.

🇚ðŸ‡ļUnited States tim bozeman

Thanks!

🇚ðŸ‡ļUnited States tim bozeman

Huh, that seems like a good module to support. I wonder what it would take to get it going. I'm surprised it's not working.

🇚ðŸ‡ļUnited States tim bozeman

tim bozeman → created an issue.

🇚ðŸ‡ļUnited States tim bozeman

Well heya Deiter. Sure thing. Thanks for the help!

🇚ðŸ‡ļUnited States tim bozeman

Yikes! That does look pretty hairy.

🇚ðŸ‡ļUnited States tim bozeman

Haha! That looks promising though!

🇚ðŸ‡ļUnited States tim bozeman

Hmm, I have a feeling the title isn't getting the required attributes needed for inline editing on the first pass. ðŸĪ”

🇚ðŸ‡ļUnited States tim bozeman


I'd love to copy what the Claro theme is doing to vertical tabs. That part of the theme code has a link to #3056089: Provide a new render element for accordion → ðŸĪ”

🇚ðŸ‡ļUnited States tim bozeman

Yes that is working! Thank you very much!

Jim Birch was the one who told me to make it strict, but I guess I will leave that as a task for #futureMe to figure out.

Thanks again!

🇚ðŸ‡ļUnited States tim bozeman

Thank you very much!

🇚ðŸ‡ļUnited States tim bozeman

Ah yes. Thanks Arun! That's definitely a step in the right direction. I am trying to make it so that we can apply the Recipe to Drupal CMS, but I've got to admit I have no idea how to get it to that point. I feel like if we can apply the Recipe to Drupal CMS then it will probably apply to most other sites.

🇚ðŸ‡ļUnited States tim bozeman

tim bozeman → created an issue.

🇚ðŸ‡ļUnited States tim bozeman

tim bozeman → created an issue.

🇚ðŸ‡ļUnited States tim bozeman

Oooo ya good point. We will definitely do that

🇚ðŸ‡ļUnited States tim bozeman

tim bozeman → created an issue.

🇚ðŸ‡ļUnited States tim bozeman

ya, that's okay. There's no difference to LB+ 3.1 and 3.2 other than some composer.json and .info file stuff. Using D11 as an example should still work file for 3.1

🇚ðŸ‡ļUnited States tim bozeman

Thank you for the report. I'm sorry that it failed, but I'm not surprised. I haven't upgraded from 2.x to 3.x myself 😔

The 2.x branch of LB+ was developed on cores Toolbar module, when cores Navigation module was released we started using that which replaces the toolbar. When that happened the sidebars and UI elements moved out of LB+ and moved to a shared Navigation+ module. I would suggest checking out the +Suite recipe → . There it has a curl command that can get a working LB+ up on D11. Maybe you can use that as an example and compare what's different between your site and that one.

curl -sL 'https://git.drupalcode.org/project/plus_suite/-/raw/1.0.x/install.sh' -o install.sh; bash install.sh

🇚ðŸ‡ļUnited States tim bozeman

Many thanks to Jim Birch for teaching me that you are making a life decision to maintain the config if you put it in your recipe. It's way better to apply the core recipe for that config.

🇚ðŸ‡ļUnited States tim bozeman

tim bozeman → created an issue.

🇚ðŸ‡ļUnited States tim bozeman

Whoopsie!

Thank you very much!

ðŸŒą | + Suite | + Suite Dude
🇚ðŸ‡ļUnited States tim bozeman

tim bozeman → created an issue.

💎 | Edit+ | Roadmap?
🇚ðŸ‡ļUnited States tim bozeman

Heya mortona2k,

Will it work along side experience builder? I can't imagine people would want 2 page builders on one site ðŸĪ”

But, things are coming along nicely. I just made a recipe for the page builder → . People can run that recipe to install it on an existing site or use this installer to try out the page builder on a new site.
curl -sL 'https://git.drupalcode.org/project/plus_suite/-/raw/1.0.x/install.sh' -o install.sh; bash install.sh

Page Builder Roadmap

  • We need page templates, so that will probably involve making section library items editable
  • I need to address some technical debt of moving the Edit+ storage stuff up to Navigation+
  • Add a hierarchical page elements/layers panel for being able to target specific thingies for moving, configuring, styling, editing
  • Break out all the stuff in Layout Builders contextual menu into tools. So an eraser for delete, a gear for configure, something for duplicate
  • A generic styling tool which will have a paintbrush icon
  • Extract the template editing from component_library into a twig tool

Let us know what you think and thanks for checking in on us!

🇚ðŸ‡ļUnited States tim bozeman

It looks like the tag is missing data-icon-text="Bl" which is messing things up. Thanks for looking into it!

🇚ðŸ‡ļUnited States tim bozeman

tim bozeman → created an issue.

🇚ðŸ‡ļUnited States tim bozeman

Thank you

🇚ðŸ‡ļUnited States tim bozeman

Heya Scott!

Thank you for pointing that out. Edit+ should be able to run without Layout builder, but I guess some hidden dependencies may have snuck in over time. I'll have to go through it all with a fine tooth comb one day and sprinkle around a bunch of if (layoutBuilder.isInstalled) all over.

🇚ðŸ‡ļUnited States tim bozeman

tim bozeman → created an issue.

🇚ðŸ‡ļUnited States tim bozeman

tim bozeman → created an issue.

🇚ðŸ‡ļUnited States tim bozeman

Ah yes, you're right those should totally be in composer.json.

Layout Builder + will soon not require Edit+, but it will require Navigation+ and twig_events. Both Edit+ and LB+ use the Layout Builder section storage and there are some things around that in Edit+ that should really be moved to Navigation+. It's on the todo list, but until then we unfortunately have a circular dependency on Navigation+ and Edit+ 😔

Sorry about that!

🇚ðŸ‡ļUnited States tim bozeman

Sorry about that! Is it working now? 😅

🇚ðŸ‡ļUnited States tim bozeman

That project may need a new release too. I need to check.

🇚ðŸ‡ļUnited States tim bozeman

I think the latest dev branch of Layout Builder 3.x is in pretty good shape.

🇚ðŸ‡ļUnited States tim bozeman

Ah that sounds right. I'm sorry about that. I'll cut a new release!

Thank you!

🇚ðŸ‡ļUnited States tim bozeman

Huh, that's crazy. Did you search for it? It should be listed under the Page Building group.

🇚ðŸ‡ļUnited States tim bozeman

Ooo ya, I guess we broke that integration huh? You can see that in lb_plus_contextual_links_alter we are overriding the layout builder contextual links to add nested section storage support. That gives users the ability to place a block who's layout is managed with layout builder inside a layout. It makes for a block builder like functionality. Right now we have it to where block editing happens in the sidebar, but we are going to make that sidebar expandable and able to pop out into a modal and hopefully popout into another window too if that's possible.

🇚ðŸ‡ļUnited States tim bozeman

Oh yeah, that's true. The section storage could totally be a third_party_setting. Nice catch!

🇚ðŸ‡ļUnited States tim bozeman

Heya Milos,

Thanks for checking it out and sorry for the lack of documentation. I've been heads down getting this page builder suite ready for production and I haven't taken a look at the demo set up in quite a while. I'll give that all a once over and update the docs asap!

🇚ðŸ‡ļUnited States tim bozeman

tim bozeman → created an issue.

🇚ðŸ‡ļUnited States tim bozeman

tim bozeman → created an issue.

🇚ðŸ‡ļUnited States tim bozeman

Hmm. I'm on 3.34.0 and needed to use the patch when updating from Drupal 10.1 to 10.4 😅

🇚ðŸ‡ļUnited States tim bozeman

I think this one needs a rebase ðŸĪŠ

🇚ðŸ‡ļUnited States tim bozeman

Here's a re-roll of the MR against 10.4

Production build 0.71.5 2024