🇺🇸United States @tim bozeman

Never!

tim bozeman → created an issue.

tim bozeman → created an issue.

tim bozeman → created an issue. See original summary → .

tim bozeman → created an issue.

Thanks for the report solideogloria! I think this was fixed in the latest dev version 😅

When we started writing these modules we were using Drupal core's toolbar module, so we called it toolbar_plus, but since we are moving to cores new navigation module we're going to rename toolbar_plus to navigation_plus → pretty soon.

Hmm, thanks for getting IEF complex going, but it seems to break regular non-IEF fields 😓

Also, this module is probably going to be moved to navigation_plus since we started using navigation when it came out.

There are still some sea change tasks coming up where this will be addressed.

Thank you Lucas! There's actually a bunch of technical debt around this one. Not totally sure what to do about in the meantime tbh.

Edit+ is a tool plugin for Toolbar+. So I think the info files are correct in that edit+ depends on toolbar+, but yeah there is definitely a hidden dependency. Would the two modules depending on each other cause a circular dependency? I've ran into that before, but not sure how I got there.

Edit+ and Layout Builder share a tempstore for hanging onto changes before the entity is saved. Because of the order that the modules were developed the tempstore handling is in Edit+ at the moment, but it should really be bubbled up to toolbar+.

Oops! Nice catch! Thank you.

tim bozeman → created an issue.

tim bozeman → created an issue.

tim bozeman → created an issue.

Have you narrowed down what character is the issue? Maybe there’s a way to detect invalid characters in a generic way. 🤔

tim bozeman → created an issue.

Maybe you could add a generator plugin that just returns nothing 😅

tim bozeman → created an issue.

tim bozeman → created an issue.

tim bozeman → created an issue. See original summary → .

tim bozeman → created an issue.

tim bozeman → created an issue. See original summary → .

tim bozeman → created an issue.

tim bozeman → created an issue.

tim bozeman → created an issue.

tim bozeman → created an issue.

¯\_(ツ)_/¯

tim bozeman → created an issue.

Yes, especially if it fixes your error. Did it?

Thanks for trying it. Do you have other JS libraries in your site that have preprocess: false in the definition? Try removing those and clearing caches if you do. I noticed editor_advanced_link does it too. You may be able to debug JsCollectionGrouper and see what the offending library is that is putting ckeditor_media_resize in a group outside of the rest of the ckeditor libraries.

When I enable Edit Plus, I see The website encountered an unexpected error. Try again later.

Yeah these modules are under development. While they are usable, they aren't obvious how to set up yet. We're working on that though. There are some instructions on how to get it going with Umami on the toolbar+ page → .

Layout Builder + is a drop in replacement for the layout builder UI. The biggest difference is drag and drop and sortable sections and stuff.

Oh those are some very nice changes.

tim bozeman → created an issue.

Oh nice work!

tim bozeman → created an issue.

tim bozeman → created an issue.

Toolbar Plus integrates with cores experimental navigation module. It adds an Edit button to the bottom of the sidebar. When you enter Edit Mode the navigation sidebar is replaced with a photoshop like toolbar with multiple tools. So far the tools are LB+ and Edit+

Edit+ adds inline editing much like quickedit, but different.

We have a philosophy of getting content on the page quickly and then making it easy for the user to edit it. We do so by auto-generating field values when you place a block. Field sample value makes the values that are generated plugable and gives a few default plugins.

Twig events let's us use twig_render_template.

All this is to provide a radical new editorial experience where you no longer need the edit or layout tab.

tim bozeman → created an issue. See original summary → .

The problem is with JsCollectionGrouper. When JS files are aggregated, say there are like 100 js files, they get grouped based on the library dependencies. Those 100 js files may be spit up into 5 groups of js files which ends up as 5 big JS files wrapped in an anonymous function to scope them altogether.

All the CKEditor plugins like alignment and bold and ckeditor_media_resize are their own separate JS files. Those little files aren’t being aggregated into the same larger aggregated JS file. You can tell this is true because when you turn off JS aggregation the files can see each other again and the error goes away.

When we set preprocess: false we are forcing a new group (aggregated JS file).

tim bozeman → changed the visibility of the branch 3471500-ckeditorerror-plugincollection-plugin-not-found to active.

tim bozeman → changed the visibility of the branch 3471500-ckeditorerror-plugincollection-plugin-not-found to hidden.

tim bozeman → created an issue.

It would be a pretty simple task if any one wants to tackle it. It's just removing lines 75 - 116 and any relevant styles. I aim on doing it asap when priorities allow for it. 😥

To work around it you can work with the config just like any other.

drush cset lb_plus.settings colors.main '#888888'

tim bozeman → created an issue.

tim bozeman → created an issue.

tim bozeman → created an issue.

tim bozeman → created an issue. See original summary → .

🎉