- Issue created by @pfolk
- @arunsahijpal opened merge request.
- 🇮🇳India arunsahijpal
Hi @pfolk,
I've movedfield.storage.node.layout_builder__layout.yml
into optional folder so that it will be skipped if the file already defined in the site — avoiding the config conflict error.Please check.
Thank,
Arun - 🇺🇸United States tim bozeman
Ah yes. Thanks Arun! That's definitely a step in the right direction. I am trying to make it so that we can apply the Recipe to Drupal CMS, but I've got to admit I have no idea how to get it to that point. I feel like if we can apply the Recipe to Drupal CMS then it will probably apply to most other sites.
- 🇺🇸United States drakythe
So the install issue seems to be related to https://www.drupal.org/project/distributions_recipes/issues/3304895 📌 Determine recipe pattern for optional config and modules Active
By adding `string: false` as the first entry under `config:` I can get the recipe to installed (The problem child was the system trying to install the navigation module and apply its config, which is not optional, and would require core change how that is handled or it be not strict in Plus Suite). I am now attempting to get the site to run in this state but I now get `The "" entity type does not exist. in Drupal\Core\Entity\EntityTypeManager->getDefinition()` which is of course my absolute favorite kind of entity to hunt down. I am investigating further as I am able.
My current suspicion is that some modules (possibly the + modules themselves) will need to be explicitly declared strict while the core modules can remain optional via the strict switch.
- 🇺🇸United States drakythe
Tracked it down to Navigation+
Created an issue here: https://www.drupal.org/project/navigation_plus/issues/3518649 🐛 Cannot view user page Active
I have yet to test the plus_suite functionality of the system now that I have it installing, but progress!
- 🇺🇸United States drakythe
Did some more testing this morning now that I had isolated the issue I was experiencing. I haven't tested the whole thing, but it is installable now and by creating a landing page through the updated navigation I was able to use the inline editing and layout builder features of the suite.
I am marking it as Needs Review as I am not an expert on the underlying modules and need those more familiar with them to verify everything is working.
It is also possible there are some dependent modules/config that cannot be optional. If so those should be explicitly labeled strict.
-
tim bozeman →
committed c7d063da on 1.0.x authored by
arunsahijpal →
Issue #3517909 by arunsahijpal, drakythe, tim bozeman: Make the recipe...
-
tim bozeman →
committed c7d063da on 1.0.x authored by
arunsahijpal →
- 🇺🇸United States tim bozeman
Yes that is working! Thank you very much!
Jim Birch was the one who told me to make it
strict
, but I guess I will leave that as a task for#futureMe
to figure out.Thanks again!
Wow, it's amazing to see progress like this! I will give it a try this evening. Would someone be able to reiterate the commands that they used to test? I am not sure how to make sure I am getting the updated version.
- 🇺🇸United States tim bozeman
Check the issue description for steps to test. Thanks!
- 🇺🇸United States drakythe
According to the issue I linked, Jim and many others are of the opinion that
Recipes are declarative and should not leave anything to be optional.
(see https://www.drupal.org/project/distributions_recipes/issues/3304895#comm... 📌 Determine recipe pattern for optional config and modules Active )
I am... less convinced that Recipes should leave things non-optional, especially when core modules have non-optional config and that means any two recipes that declare a dependency on those same core modules will not be able to be installed on the same site.