🇮🇳India @arunsahijpal

Good to hear that!
Then shall we move issue to RTBC?

Hi @tstoeckler,
I've added the missing space and has also fixed phpcs but there is one test failing pls check.

Working on it.

Hi @stado,
I've added a hook so that the content owner can't rate on his content, pls check.

Removed the help text, pls check.

Oops I missed that one, but I've updated it now pls check.

Working on it.

Hi @solideogloria,
I've added the null types, pls check.

Working on it.

Wroking on it.

@joachim , could you pls check now.

Removed the whitespace.

@joachim,
I've updated the ReindexForm and the pipeline is also green now, pls check.

@joachim, IDK why it is not finding ''confirm" key in SearchConfigSettingsFormTest could you pls check it, and the second SearchMultilingualEntityTest error is not due to the change made in getFormName() function.

I've fixed the indentation issue but now a phpunit functional is failing
I think it is due to this Line of code as it should be this if ($form_state->getValue('confirm')) { because Form submissions in Drupal are processed through $form_state.

Should i change it?

Corrected the indentation.

Hi @joachim,
Yes, I think we can remove the if ($form_state->getValue('confirm')) condition from UserMultipleCancelConfirm::submitForm() as the confirm field is no longer relevant. Since ConfirmFormInterface is inward-facing, I agree that getFormName() can be removed without deprecation.

I've done the changes pls check.

Thanks
Arun

Hi @abhiyanshu,
I've improved the styling of the contact form pls check.
Attaching ss for reference.

arunsahijpal → changed the visibility of the branch 3496701-styling-contact-form to hidden.

arunsahijpal → changed the visibility of the branch 3496701-UI-doesn’t-look to hidden.

Working on it.

I've tested the MR on my local and I assure that now the link is pointing to thecorrect destination.
Attaching ss for reference.
Hence moving it to RTBC.

Thanks

Hi @phenaproxima,
I've made the changes pls look.

Great work @kalash-j,
The MR LGTM as it has solved the deprecated method error, attaching ss for reference.
Hence moving it to RTBC.

Thanks,
Arun

Working on it.

Thanks @anish.ir for reporting this error.
I've removed the unnecessary part of code, please check.

Hi @narendrar,
I've parsed through whole codebase and corrected Drupal.t() where required, please check.

Hi @anish.ir, Great work!!
I assure that the changes made solves the issue, all the settings are loaded correctly attaching ss for reference.
Hence moving it to RTBC.

Thanks,
Arun

Working on it.

Hi @proweb.ua,
I've added all the necessary checks and now there is no error so moving it to NR, kindly check.

Thanks,
Arun

arunsahijpal → changed the visibility of the branch 3493976-error-call-to to hidden.

@trackleft2,
Here are the ss of the config_inspector report, pls check.

Hi @trackleft2,
I've updated the new configurations and also added the machine name as the type for role id, kindly check.

Working on it.

Hi @jibla,
I've tested this on Drupal 10.4.0-rc1 and php 8.3 as these are the module's requirement, and then the module is enabling perfectly.

Thanks,
Arun

Hi @roberttabigue,
Fixed the remaining phpcs errors, kindly check.

Working on it!

Hi @yasminorj ,
I've fixed the phpcs errors and the phpcs is also passing the pipeline, kindly check.

Hi @gurumurthy_r,
I have updated the configuration form to accept the custom texts for Zoom in/out buttons, I've removed the images folder as it was overriding the custom texts and also as the user is only entering the custom text not an image.
If you want to make it compatible with images too feel free to ask and if you also want the button size to be increased or decreased on Zooming in/out then we can remove this property

 font-size: 14px;

from css.
I've also enhanced the styling for better accessibility.

Attaching ss for reference.

Thanks
Arun

Woking on it!

@useernamee ,
I've ignored the word through .gitlab-ci.yml, please check.

I've tested the changes on my local and i assure there are no phpcs errors left.
Hence moving it to RTBC.

I've done the changes from my end please check it.
There are some phpunit tests that are failing see if we can skip them.

Great Work @kul.pratap and @john-franklin,
I've tested MR!22 and MR!24 on my local and phpcs doesn't reports any error, and phpcs is passing in the pipeline too!
Hence moving it to RTBC.

Nice work @kul.pratap !!
I've tested this on my local and I assure the issue has been completely resolved, uploading the ss for reference.
Hence moving it to RTBC.

Working on it!

@sbrandt,
I've added .gitlab-ci.yml, kindly check.

Hi @sbrandt,
Your repo seems to be empty, kindly check.

Working on it!

Working on it!

Hi @cmlara,
As the cspell is passing the pipeline so moving it to RTBC.

Hi @hablat and @marcoscano,
I've applied the patch and created MR for the same, please check it.

arunsahijpal → made their first commit to this issue’s fork.

Hi @mherchel,
I've removed the get started bullet point from oilvero theme, please check it.

Working on it!

arunsahijpal → made their first commit to this issue’s fork.

Hi @berdir,
I've removed all the drupal calls (mentioned by phpstan) and used dependency injection instead, please check it.

Hi @alexpott,
I've allowed phpcs failure and the phpcs is also passing the pipeline, kindly check.

The pipeline is all green now and the MR seems to be working fine
Hence moving it to RTBC.

Working on it!

Hi @alorenc,
When i am making a field of file_url type, i am encountering this error and it crashes the site
TypeError: Drupal\file_url\Plugin\Field\FieldType\FileUrlFieldItemList::defaultValuesForm(): Return value must be of type array, none returned in Drupal\file_url\Plugin\Field\FieldType\FileUrlFieldItemList->defaultValuesForm() (line 47 of /app/web/modules/contrib/file_url/src/Plugin/Field/FieldType/FileUrlFieldItemList.php).
Are you talking about this?

Hey @keiserjb,
I have installed this module and there is no errors in the settings.
Here is the ss for reference. Please add to steps to reproduce if it exists in your site.

Hi @cleavinjosh and @marcoscano,
I've removed all the phpcs errors , please check it once.

Working in it!

Hey @purencool,
could you please tell steps reproduce this issue.

@larowlan
I've added the presave method, please check it.

Working on it!

Hi @bolaghi,
I've tested it on
drupal 10.3.9
php 8.3.14
captcha 2.0.7

and it does not show any error.

Okay @larowlan,
I am thinking to add presave function in Linkitem class which will trim the URI.
Will it be a good approach?

Hi @dieterholvoet,
I've added the config schema, please check it.

Working on it!

Hi @larowlan,
I've checked this on the latest drupal 11.x version and there no widget like Link(with attributes), the one which present is Link widget,
Which is not causing any issue on giving spaces at the end of a link.
Could you please check it once.

Working on it!

Hi @jcnventura,
I've rebased the branch, Please have a look.

Hi @rajdip_755 and @manuel.adan
I've done the changes,
Now it is showing Failed attempt even if we enter email and incorrect password. Please have a look.

Hi @trackleft2,
I've resolved all the errors only the following error is left and it is due to the missing package of tinycon. Please look at this.
1:21 error Unable to resolve path to module 'tinycon' import/no-unresolved

Hi @astonvictor,
I don't find any hook_styles to add styles , can i use any other alternate hook to style?

Okay @rajdip_755,
Looking into this.

@trackleft2 I've ignored the tinycon.min.js and environment_indicator.js files and made the required changes and eslint job is also passing successfully so moving it to needs review. Please have a look .

Working on it.

Here is the screenshot of the footer.

Hi @alok_singh,
I've styled the footer, Please have a look and if there is something more to do you can telll me.

Hi @trackleft2,
I've resolved many eslint error , Please have a look.

Working on it!

Hi @john-franklin,
I have moved all the to new branch 3484416-addressed-pipelines-issues
and the new MR is : MR 7

arunsahijpal → changed the visibility of the branch 3484416-enable-gitlab-pipelines to hidden.

Working on it.

Hi @useernamee,
I've resolved the merge conflicts, Kindly check it.

hi @john-franklin,
I've removed all the errors almost but there are some errors which are problematic, Please have a look.

  168    Parameter $token_service of method                                                  
         Drupal\bg_img_field\Plugin\Field\FieldFormatter\BgImgFieldFormatter::__construct()  
         has invalid type Drupal\token\TokenServiceInterface.                                
        189    Access to an undefined property                                                     
         Drupal\bg_img_field\Plugin\Field\FieldFormatter\BgImgFieldFormatter::$logger.                                                                           
            https://phpstan.org/blog/solving-phpstan-access-to-undefined-property            
        396    Access to an undefined property                                                     
         Drupal\bg_img_field\Plugin\Field\FieldFormatter\BgImgFieldFormatter::$logger.

working on it.

Hi @astutonet,
I have tried to reproduce this and there was no issue on uninstalling this module.
I have enabled both the modules drush en social_media_links and drush en social_media_links_field and created a field in a content type then i tried to uninstall it it showed error because the module was being used in that content type then i deleted the field which i created on that content type and then the module uninstalls successfully.
So I think this works as designed.

Hi @vladimiraus,
Fixed all the phpcs errors, Kindly check it.

Working on it.