🇮🇳India @arunsahijpal

Working on it.

Hi @proweb.ua,
I've added all the necessary checks and now there is no error so moving it to NR, kindly check.

Thanks,
Arun

arunsahijpal → changed the visibility of the branch 3493976-error-call-to to hidden.

@trackleft2,
Here are the ss of the config_inspector report, pls check.

Hi @trackleft2,
I've updated the new configurations and also added the machine name as the type for role id, kindly check.

Working on it.

Hi @jibla,
I've tested this on Drupal 10.4.0-rc1 and php 8.3 as these are the module's requirement, and then the module is enabling perfectly.

Thanks,
Arun

Hi @roberttabigue,
Fixed the remaining phpcs errors, kindly check.

Working on it!

Hi @yasminorj ,
I've fixed the phpcs errors and the phpcs is also passing the pipeline, kindly check.

Hi @gurumurthy_r,
I have updated the configuration form to accept the custom texts for Zoom in/out buttons, I've removed the images folder as it was overriding the custom texts and also as the user is only entering the custom text not an image.
If you want to make it compatible with images too feel free to ask and if you also want the button size to be increased or decreased on Zooming in/out then we can remove this property

 font-size: 14px;

from css.
I've also enhanced the styling for better accessibility.

Attaching ss for reference.

Thanks
Arun

Woking on it!

@useernamee ,
I've ignored the word through .gitlab-ci.yml, please check.

I've tested the changes on my local and i assure there are no phpcs errors left.
Hence moving it to RTBC.

I've done the changes from my end please check it.
There are some phpunit tests that are failing see if we can skip them.

Great Work @kul.pratap and @john-franklin,
I've tested MR!22 and MR!24 on my local and phpcs doesn't reports any error, and phpcs is passing in the pipeline too!
Hence moving it to RTBC.

Nice work @kul.pratap !!
I've tested this on my local and I assure the issue has been completely resolved, uploading the ss for reference.
Hence moving it to RTBC.

Working on it!

@sbrandt,
I've added .gitlab-ci.yml, kindly check.

Hi @sbrandt,
Your repo seems to be empty, kindly check.

Working on it!

Working on it!

Hi @cmlara,
As the cspell is passing the pipeline so moving it to RTBC.

Hi @hablat and @marcoscano,
I've applied the patch and created MR for the same, please check it.

arunsahijpal → made their first commit to this issue’s fork.

Hi @mherchel,
I've removed the get started bullet point from oilvero theme, please check it.

Working on it!

arunsahijpal → made their first commit to this issue’s fork.

Hi @berdir,
I've removed all the drupal calls (mentioned by phpstan) and used dependency injection instead, please check it.

Hi @alexpott,
I've allowed phpcs failure and the phpcs is also passing the pipeline, kindly check.

The pipeline is all green now and the MR seems to be working fine
Hence moving it to RTBC.

Working on it!

Hi @alorenc,
When i am making a field of file_url type, i am encountering this error and it crashes the site
TypeError: Drupal\file_url\Plugin\Field\FieldType\FileUrlFieldItemList::defaultValuesForm(): Return value must be of type array, none returned in Drupal\file_url\Plugin\Field\FieldType\FileUrlFieldItemList->defaultValuesForm() (line 47 of /app/web/modules/contrib/file_url/src/Plugin/Field/FieldType/FileUrlFieldItemList.php).
Are you talking about this?

Hey @keiserjb,
I have installed this module and there is no errors in the settings.
Here is the ss for reference. Please add to steps to reproduce if it exists in your site.

Hi @cleavinjosh and @marcoscano,
I've removed all the phpcs errors , please check it once.

Working in it!

Hey @purencool,
could you please tell steps reproduce this issue.

@larowlan
I've added the presave method, please check it.

Working on it!

Hi @bolaghi,
I've tested it on
drupal 10.3.9
php 8.3.14
captcha 2.0.7

and it does not show any error.

Okay @larowlan,
I am thinking to add presave function in Linkitem class which will trim the URI.
Will it be a good approach?

Hi @dieterholvoet,
I've added the config schema, please check it.

Working on it!

Hi @larowlan,
I've checked this on the latest drupal 11.x version and there no widget like Link(with attributes), the one which present is Link widget,
Which is not causing any issue on giving spaces at the end of a link.
Could you please check it once.

Working on it!

Hi @jcnventura,
I've rebased the branch, Please have a look.

Hi @rajdip_755 and @manuel.adan
I've done the changes,
Now it is showing Failed attempt even if we enter email and incorrect password. Please have a look.

Hi @trackleft2,
I've resolved all the errors only the following error is left and it is due to the missing package of tinycon. Please look at this.
1:21 error Unable to resolve path to module 'tinycon' import/no-unresolved

Hi @astonvictor,
I don't find any hook_styles to add styles , can i use any other alternate hook to style?

Okay @rajdip_755,
Looking into this.

@trackleft2 I've ignored the tinycon.min.js and environment_indicator.js files and made the required changes and eslint job is also passing successfully so moving it to needs review. Please have a look .

Working on it.

Here is the screenshot of the footer.

Hi @alok_singh,
I've styled the footer, Please have a look and if there is something more to do you can telll me.

Hi @trackleft2,
I've resolved many eslint error , Please have a look.

Working on it!

Hi @john-franklin,
I have moved all the to new branch 3484416-addressed-pipelines-issues
and the new MR is : MR 7

arunsahijpal → changed the visibility of the branch 3484416-enable-gitlab-pipelines to hidden.

Working on it.

Hi @useernamee,
I've resolved the merge conflicts, Kindly check it.

hi @john-franklin,
I've removed all the errors almost but there are some errors which are problematic, Please have a look.

  168    Parameter $token_service of method                                                  
         Drupal\bg_img_field\Plugin\Field\FieldFormatter\BgImgFieldFormatter::__construct()  
         has invalid type Drupal\token\TokenServiceInterface.                                
        189    Access to an undefined property                                                     
         Drupal\bg_img_field\Plugin\Field\FieldFormatter\BgImgFieldFormatter::$logger.                                                                           
            https://phpstan.org/blog/solving-phpstan-access-to-undefined-property            
        396    Access to an undefined property                                                     
         Drupal\bg_img_field\Plugin\Field\FieldFormatter\BgImgFieldFormatter::$logger.

working on it.

Hi @astutonet,
I have tried to reproduce this and there was no issue on uninstalling this module.
I have enabled both the modules drush en social_media_links and drush en social_media_links_field and created a field in a content type then i tried to uninstall it it showed error because the module was being used in that content type then i deleted the field which i created on that content type and then the module uninstalls successfully.
So I think this works as designed.

Hi @vladimiraus,
Fixed all the phpcs errors, Kindly check it.

Working on it.

Working on it.

Hi @smustgrave,
I've fixed the all the eslint errors, Kindly check it once.

Trying to fix

Hi @trackleft2,
I've configured gitlab-ci.yml file to not allow merging if stylelint job doesn't pass.
Pls give it a look.

Hi @trackleft2,
I've fixed all the Stylelint errors and there is not any merge conflict in the MR, kindly review it.

Working on it!

Improved the styling of main navigation.

Hi @bramdriesen,
I have made all the necessary changes and added a language filter too. But there are some phpunit tests that are failing.

Working on it!

Fixed the remaining phpcs errors, kindly check it.

I have fixed the cspell error but it is showing some merge conflicts should i resolve them?

Okay,Rebasing it into my branch.

Working on it!

Hi @useernamee,
The readme.md does'nt exist in my branch, its in 1.0.x how can I fix it?

Hi @saschaeggi,

I've tested it with Claro admin theme and olivero theme and i dont't get any issue like this .
So it seems that it is a issue with Gin theme only.

Here are the screenshots of claro and olivero theme.

arunsahijpal → created an issue.

Hi @alok_singh,
I have used this theme and there was no code written there,
you can check the screenshot or if i am missing something you can tell me

Fixed the phpcs issue!

Working on it!

It works fine for both the entities.

Hi @kopeboy,
If you configure private file system then also anonymous user is able to download the file.

Hi @couloir007
I have reproduced this issue on user and node entity it works fine,
The provinces change to States. Here are the supporting screenshots.

Looking after it!

Fixed the phpcs issues.

Working on it!

How to reproduce this issue?