Account created on 27 September 2024, 7 months ago
#

Merge Requests

More

Recent comments

🇮🇳India arunsahijpal

I left the *_edit_form_alter() implementations alone because they already attach the correct checkbox UI and config submit logic.
The updated forms now use #after_build to simplify the form by hiding fields. Please review.

🇮🇳India arunsahijpal

Hey @astonvictor,
I am working on it.

🇮🇳India arunsahijpal

@smustgrave could you please guide me with best approach here.

🇮🇳India arunsahijpal

The dead link discussed various database strategies for storing hierarchical data, such as:

  • Materialized path (e.g., storing a path like /1/4/7)
  • Nested set model
  • Adjacency list
  • Closure table

While this was relevant in older versions of Drupal (e.g., 6/7), in modern Drupal (8+), menu trees are abstracted through MenuTreeStorageInterface and implemented by MenuTreeStorage. Internally, a materialized path-like structure is still used (e.g., storing parent, depth, and weight), but this is implementation-specific and subject to change — as the doc comment rightly warns.

Where should this documentation live?

I see two good options:

1- In-code documentation, e.g.:
A @defgroup menu_tree_storage block in menu.api.php
Or an @ingroup docblock in MenuTreeStorageInterface or MenuTreeStorage
This would describe the storage strategies, how ordering is applied, and what’s considered internal/subject to change

2- Drupal.org handbook or developer documentation:
A dedicated page under Menus or API > System > Menu System
More detailed and user-friendly, good for those exploring how menu links are built and ordered

Thanks,
Arun

🇮🇳India arunsahijpal

Hi @pfolk,
I've moved field.storage.node.layout_builder__layout.yml into optional folder so that it will be skipped if the file already defined in the site — avoiding the config conflict error.

Please check.

Thank,
Arun

🇮🇳India arunsahijpal

Hi @grallapa2,
As this issue in not like other issues which you can reproduce as I.S says that if you write a wrong attribute name in an element then the drupal just strips it silently without informing the user that he/she has used a wrong attribute so in order to follow a good practice we are going to log a warning before stripping the attribute.
So I've added a logger warning and a test case to check this.

For running this testcase you can do

phpunit core/tests/Drupal/Tests/Core/Template/AttributeTest.php

and if you want to do manual testing on your cli then you may write this

 drush php:eval ' 
  $attributes = new \Drupal\Core\Template\Attribute([
    "valid_attribute" => "value",
    "invalid attribute" => "value",
  ]); 
  dump($attributes->toArray()); 
  \Drupal::logger("debug")->notice("Attributes stored: @attributes", ["@attributes" => json_encode($attributes->toArray())]); 
'

and that issue no. mentioned in that commit is done by mistake, could you please correct it?

Feel free to ask any other query.

Thanks,
Arun

🇮🇳India arunsahijpal

Hi @mortona2k,
This doc was foundational reading for understanding how Drupal (especially 6 & 7) stored menu items, taxonomy terms, etc., before full-fledged entity trees and interfaces were in place.
Conceptually it is relevant but not for inline documentation that most devs read.

🇮🇳India arunsahijpal

This issue depends on another issue link 🐛 drupal_get_path() is deprecated in Drupal 9.3.0 and removed from Drupal 10.0.0 RTBC
so we need to apply changes of this issue first to use this theme otherwise it will throw error.

So by apply the changes of the above issue and this MR
Blockquote css have been applied correctly and the changes are present in both the files (.scss and .css).

So moving it to RTBC.

Arun,
Thanks

🇮🇳India arunsahijpal

The MR works fine and the spinner is appearing as expected so moving it to RTBC.

🇮🇳India arunsahijpal

Hi @arpitr,
I've updated the help text, please review.

🇮🇳India arunsahijpal

above MR fixed the issue, Working for me . moving RTBC++

🇮🇳India arunsahijpal

Hi @finex,
Could you please provide the step to reproduce the issue as I've enabled both the modules(Layout Builder, LinkChecker) and I've addded a link field in the Article and managed its layout through layout builder but I didn't get any error.

🇮🇳India arunsahijpal

Hi @alex9000,
This warning is due to the dynamic property $moduleHandler being assigned directly in the constructor of LinkCheckerAdminSettingsForm.
So we require a docblock comment in order to remove the warning.

I see that that docblock is present in 2.0.x and 2.1.x but it is not present when you do composer require 'drupal/linkchecker:^2.0' so you can use these versions instead or you can explicitly write this docblock.

  /**
   * ModuleHandler service.
   *
   * @var \Drupal\Core\Extension\ModuleHandlerInterface
   */
  protected $moduleHandler;

@vladimiraus please check this.

Thanks,
Arun

🇮🇳India arunsahijpal

Hi @kiwad,
I've installed the experience builder on drupal cms project but I didn't get any error.

🇮🇳India arunsahijpal

Hi @dcoppel,
I followed the steps you mentioned but didn't got any error, could you please elaborate the steps you mentioned.

Thanks,
Arun

🇮🇳India arunsahijpal

I've updated the HtmlConfigurationFormForm.php with backward compatibility. pls check.

🇮🇳India arunsahijpal

I've updated all the images mentioned above except the logo because its already small in size (13kb), also I've updated the configuration of respective images, but the pipeline is failing due to these changes so could you pls check the changes and pipeline.

🇮🇳India arunsahijpal

Opened MR and added the file, pls check.

🇮🇳India arunsahijpal

Hi @greg-boggs,

I've compressed the image and converted it into webp and now it is around 82kb.
The drupal file uploader doesn't allow me share it in the comment section as it doesn't support .webp format.
So how can I share the image could you pls tell.

🇮🇳India arunsahijpal

@tstoeckler,
Could please suggest me some changes to fix the pipeline.

🇮🇳India arunsahijpal

The MR changes are working fine.
Attaching ss for reference.

🇮🇳India arunsahijpal

Hi @laurentb,
I've updated the checkAccess method and now even when you set "View own profiles" without giving the edit access to the user you can see the fields for the profile, and for the field permission module could please create a separate issue, I've a solution for that too.

Thanks,
Arun

🇮🇳India arunsahijpal

Hi @berdir,

are you talking about this line" class="!text-blue-400 !no-underline" target="_blank" rel="nofollow" >line ?

🇮🇳India arunsahijpal

Ok @greg-boggs, I understood.

It would be very helpful if could you pls tell me the approach we can follow here, as I was thinking to update createDerivative method in Image module but we can't do this here as it is Drupal cms not core.

🇮🇳India arunsahijpal

Hi @greg-boggs,

I've tried to reproduce this by following the steps you have mentioned, but I didn't get the images of large sizes.
I think, as this issue 🐛 An image in latest content loads an extremely large image Active is fixed so the problem is solved now.

If something is left please do let me know.

Thanks,
Arun

🇮🇳India arunsahijpal

@peterwcm,

I've updated the code and now no more orphaned paragraphs and everything saves when the node saves by referencing the entity directly instead of manually setting target_id.
and I also think this condition !$item->entity->isNew() is not necessary.
For the translation thing there is one limitation that - Paragraphs are referenced entities, not simple text fields.
Drupal does not natively support translating entity reference fields.
When I tried to translate it shows this error

* (unsupported) Paragraphs fields do not support translation

. Yo can checkout this link for more info .

I think there is one tot check translation with Paragraphs Library module but I'm not sure.
Could you pls check it, if it works then I think we can safely remove that condition.

🇮🇳India arunsahijpal

Hi @peterwcm,
I've updated the createDuplicate method please check.

Also @berdir pls check is this a good solution?

Thanks,
Arun

🇮🇳India arunsahijpal

Hi @phenaproxima,
That makes sense—mixing test-related logic into production code with drupal_valid_test_ua() can make the codebase harder to maintain.
So I'm planning to Introduce a service to determine test mode (TestModeChecker), and will replace drupal_valid_test_ua() calls with service usage.

Would it be a good solution?

🇮🇳India arunsahijpal

Hi @marianrk,
I've added a hook_entity_update to delete the referenced paragraphs please check.
Also @berdir please check whether this should be the part of module behaviour or not.

Thanks,
Arun

🇮🇳India arunsahijpal

Hi @nginex,
I've added a backward compatibility of old approach, pls check.

🇮🇳India arunsahijpal

Hi @liam-morland,
I have reproduced the issue on my local and got the same warning,but after applying the patch the warning disappears.
So making a MR for it.
pls check.

Thanks
Arun.

🇮🇳India arunsahijpal

Hi @kunalratnani,
I've created a taxonomy named Category and referenced it in 2 CT (Article and Basic Page), and
I've applied your MR(patch) but is only showing "None" value for the referencing field and I can't see separate counts for Article and Basic page, so moving it to NW.
Attaching ss for reference.

@aleksandarborosgyevi pls look into this whether its a useful feature or not.

Thanks,
Arun

🇮🇳India arunsahijpal

Good work @sandip-poddar,
I've reproduced the issue on my local and by applying the MR the multilevel menu problem is fixed.
Attaching ss for reference.

Thanks,
Arun

🇮🇳India arunsahijpal

Good work @rajat4u ,
I tested this issue on my local and by applying the MR the issue is completely resolved as maintenance page is shown without clearing the cache.
Attaching ss for reference.

Hence moving it to RTBC.

Thanks
Arun

🇮🇳India arunsahijpal

Hi @lazzyvn,
I've followed the same steps but i didn't get any error.

@bojanz could pls look into this

Thanks

🇮🇳India arunsahijpal

Hi @chrisolof,
I've removed the hook_search_api_query_alter() and added a event subscriber instead pls check.

Thanks

🇮🇳India arunsahijpal

@bohart could you please suggest some method.

🇮🇳India arunsahijpal

Hi @murz,
Your changes are good and working fine but we also need to do the same thing in importFieldValue function in order to import content smoothly, so I've made the necessary changes, pls check.

Thanks,
Arun

🇮🇳India arunsahijpal

Hi @perryjanssen,
This solution is working fine for me as ConfirmFormInterface do not require entity locking since they do not modify entity data directly.
Attaching ss for reference.

But we would like to here best solution from @alexpott

Thanks

🐛 | Poll | Empty vote
🇮🇳India arunsahijpal

@chsdaiguil I think there may be some issue at your end or maybe you are using multilingual site that's why it is happening, I am not sure.

@bramdriesen and @berdir please look into this.

🐛 | Poll | Empty vote
🇮🇳India arunsahijpal

I meant- Check screenshot(ss) for more information.

🇮🇳India arunsahijpal

@joachim
I've made the changes in the original MR and hide the new MR, please check.

🇮🇳India arunsahijpal

arunsahijpal changed the visibility of the branch 3497021-deprecate-getFormName to hidden.

🇮🇳India arunsahijpal

arunsahijpal changed the visibility of the branch 3497021-confirmforminterfacegetformname-serves-no to active.

🐛 | Poll | Empty vote
🇮🇳India arunsahijpal

Hi @chsdaiguil,

It doesn't show 1 vote when its 0
see ss for reference

🇮🇳India arunsahijpal

Hi @cebab54,
I've sent mail using this module and I didn't see any warning so could you pls tell me the steps to reproduce this and how can I add tokens to this?

🇮🇳India arunsahijpal

@joachim,
I've made the changes that you suggested, pls review.

🇮🇳India arunsahijpal

Hi @liam-morland,
I've tried to add dependency using calculateDependencies() method present in BehaviorSettings.php file but it doesn't adding the dependency although I've tried it by modifying schema but it didn't work too , so it would be a great help if you could suggest me some approach that how can I add dependency to it.

Thanks

Production build 0.71.5 2024