Blockquote css is missing in ckeditor.

Created on 17 April 2024, about 1 year ago

Problem/Motivation

Blockquote tag are not styled

Steps to reproduce

1) Install the theme
2) Create any article or add content
3) Wrap content in to blockquote
4) Save the node and check

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Active

Version

3.0

Component

Code

Created by

🇮🇳India adarshv

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @adarshv
  • 🇮🇳India ravi kant Jaipur

    Blockquote can theme in custom theme.
    But what will be a design/style of BlockQuote?

  • First commit to issue fork.
  • 🇮🇳India manishvijay02

    Hi, I have added the blockquote styling.
    Attaching the screenshot for the reference.

  • Status changed to Needs work 3 months ago
  • 🇮🇳India sandip

    Hi @manishvijay02,

    Thank you for your merge request! I’ve applied the changes, and it resolves the issue as shown in the attached screenshot for reference. However, I noticed that the .css file corresponding to the .scss changes is missing from the MR. Could you please push the related .css file to complete the update?

    Once that's done, it will be ready to be marked RTBC. For now, I’m moving it back to Needs Work.

  • 🇮🇳India sandip

    Since there is no existing Gulpfile in the theme, I addressed this by leveraging the patch from an issue already in progress to create a Gulpfile. This issue has moved to RTBC as well, and I used its patch to convert SCSS to CSS.

    You can find more details about the issue here:
    https://www.drupal.org/project/school_theme/issues/3443060 📌 package.json and automation tools(gulpjs) are not in theme. Active

  • Status changed to RTBC 25 days ago
  • 🇮🇳India arunsahijpal

    This issue depends on another issue link 🐛 drupal_get_path() is deprecated in Drupal 9.3.0 and removed from Drupal 10.0.0 RTBC
    so we need to apply changes of this issue first to use this theme otherwise it will throw error.

    So by apply the changes of the above issue and this MR
    Blockquote css have been applied correctly and the changes are present in both the files (.scss and .css).

    So moving it to RTBC.

    Arun,
    Thanks

Production build 0.71.5 2024