- Issue created by @ravi kant
- First commit to issue fork.
- Status changed to Needs review
9 months ago 8:37am 24 April 2024 - Status changed to Needs work
9 months ago 11:51am 24 April 2024 - 🇮🇳India ravi kant Jaipur
@adarshv
I did not find changes.
I think you didnot commit changes or you did not attach patch. - Status changed to Needs review
9 months ago 4:47am 25 April 2024 - 🇮🇳India adarshv
Hello @ravi kant,
please check " https://git.drupalcode.org/issue/school_theme-3443060/-/compare/1.0.x......" - 🇮🇳India ravi kant Jaipur
ravi kant → changed the visibility of the branch 1.0.x to hidden.
- 🇮🇳India ravi kant Jaipur
you had added changes directly in main branch So i have moved changes in this branch and created MR !36
- Assigned to sourojeetpaul
- Status changed to Needs work
7 months ago 12:20pm 8 July 2024 Hello there,
Thanks for creating this issue, even I thought of implementing a build tool to provide a more robust solution in terms of SCSS compilation, while working on other issues of the theme.
While reviewing the MR I found a lot of scopes which can be improved and quite a lot of functionality can be introduced withing the gulpfile itself to make the live of the developers a bit more easy, as in we can add lint tasks for CSS and JS, autoprefixing with vendor prefixes to make it compatible with cross browsers, adding unit conversion to be able to use for relative units rather than defining static units, which might introduce some styling issue in future for responsive design. Also adding PostCSS processing will be great as in it provides a lot of new functionalities which are still in technical preview and gets to use them in a progressively enhanced manner.
Hence moving it to NW as of now, and I'd love to address the same!- Issue was unassigned.
- Status changed to Needs review
7 months ago 12:23pm 8 July 2024 Hi,
I've updated the gulpfile accordingly as I've mentioned on my previous comment. Pls have a look at it, would love to see it get merged :)I've created a child issue to incorporate the stylelint and eslint config, which will make the linting tasks of the gulp file work as expected.
Link to the child issue:
https://www.drupal.org/project/school_theme/issues/3460216 ✨ Configure stylelint and eslint ActiveTested MR !36 , the gulp file looks good and has all the required functonalities for scss compilation .
RTBC++- Status changed to RTBC
6 months ago 12:22pm 14 August 2024