@chsdaiguil the first issue for empty style attribute is reproduced and i have solved it , but the second issue of duplicate id is not reproduced at all . I have tried placing multiple disclosure menu on the same page but its not reproduced at all .
@asawari from the image it seemed like you tested the MR on issue page , not on local setup.
working on it
sourabhsisodia_ → made their first commit to this issue’s fork.
sourabhsisodia_ → made their first commit to this issue’s fork.
@niharika.s your MR is failing the if conditions are not correct
@zenimagine If everything looks good then please move the issue to RTBC state
This is the last Commit . And it has bring changes in css only . was the patch working previously ??
@tim-diels Resolved merge conflicts and test cases.
@zenimagine Resolved the issue as mentioned above , please review now.
hii @ady1503, if the patch works fine then please move the issue to " Review and Tested By Community " state and mention the maintainer to review and merge the MR . So that this issue get fixed in the dev version also.
@ady1503 Attaching a screenshot . Is it the correct configuration for the issue ??
sourabhsisodia_ → made their first commit to this issue’s fork.
sourabhsisodia_ → made their first commit to this issue’s fork.
@kongkx while installing the module i am getting this error - Error: Class "DeviceDetector\ClientHints" not found in Drupal\visitors\Service\DeviceService->getDeviceDetector()
@l-laziz issue did not reproduced at all , attaching screenshot for refernce,
sourabhsisodia_ → made their first commit to this issue’s fork.
sourabhsisodia_ → made their first commit to this issue’s fork.
working on it
@blacksnipe thanks for approving the MR , since the MR is merged then we have to move the issue to fixed state instead of RTBC . And also check the credit and commiting part present below in this issue page.
working on it
Working on it !
working on it
sourabhsisodia_ → made their first commit to this issue’s fork.
I think the issue is a duplicate of this Issue 🐛 Literal "_none" value saved for seelct fields Active
@siramsay I have reviewed the changes and the changes looks good. Although I have fixed some code formatting issue in your commit and after pushing code to a branch we need to create a MR into the branch we need to implement these changes . So raised a MR.
Attaching screenshot for reference . RTBC ++.
@i-trokhanenko Resolved the conflicts
@drumanuel i tried above steps , but the issue didnot reproduced at all .
sourabhsisodia_ → made their first commit to this issue’s fork.
working on it
@heddn In required textfield components i have tested that when we write _none then validation error is not triggering and _none is getting replaced by "" (empty strings) . When we write _blank then also there is no validation error and the field is having _blank value.
@arunsahijpal The alignment of menus and sub menus is fixed , but hover is not working on menu and also nested menus need to be styled. MOving it to needs work.
@zenimagine Please review the MR also.
working on it
sourabhsisodia_ → made their first commit to this issue’s fork.
sourabhsisodia_ → made their first commit to this issue’s fork.
Attaching screenshot for reference.