working on it
@blacksnipe thanks for approving the MR , since the MR is merged then we have to move the issue to fixed state instead of RTBC . And also check the credit and commiting part present below in this issue page.
working on it
Working on it !
working on it
sourabhsisodia_ → made their first commit to this issue’s fork.
I think the issue is a duplicate of this Issue 🐛 Literal "_none" value saved for seelct fields Active
@siramsay I have reviewed the changes and the changes looks good. Although I have fixed some code formatting issue in your commit and after pushing code to a branch we need to create a MR into the branch we need to implement these changes . So raised a MR.
Attaching screenshot for reference . RTBC ++.
@i-trokhanenko Resolved the conflicts
@drumanuel i tried above steps , but the issue didnot reproduced at all .
sourabhsisodia_ → made their first commit to this issue’s fork.
working on it
@heddn In required textfield components i have tested that when we write _none then validation error is not triggering and _none is getting replaced by "" (empty strings) . When we write _blank then also there is no validation error and the field is having _blank value.
@arunsahijpal The alignment of menus and sub menus is fixed , but hover is not working on menu and also nested menus need to be styled. MOving it to needs work.
@zenimagine Please review the MR also.
working on it
sourabhsisodia_ → made their first commit to this issue’s fork.
sourabhsisodia_ → made their first commit to this issue’s fork.
Attaching screenshot for reference.
sourabhsisodia_ → made their first commit to this issue’s fork.
Working on it
working on it
Looking into it
Attaching screenshot for refernce
sourabhsisodia_ → made their first commit to this issue’s fork.
sourabhsisodia_ → made their first commit to this issue’s fork.
sourabhsisodia_ → made their first commit to this issue’s fork.
Reviewed MR !33 , MR looks good and all the mentioned changes are there . Attaching screenshot for refernce.
Reviewed MR !80 The suggested changes were made and also tested changes made by MR !80, Attaching Screenshots for reference. RTBC++
Then @gaurav gupta it works good . I have added comment #10 attaching video for reference . RTBC++.
MR !3 works fine . The font family is getting applied. Attaching screenshot for reference. RTBC++.
@kwiseman @hamza_niazi @cedewey Okay , This is happening when we are selecting "Thumbnail " as a format instead of rendered entity.
@astonvictor working on it
sourabhsisodia_ → made their first commit to this issue’s fork.
@cedwey @kwiseman @hamza_niazi The issue did not reproduced at all , I have tried on drupal version 10.3.8 , php 8.1.3
Steps I followed
1. Uploaded images via bulk upload (on the bulk upload form there is not field for alt text . There is a issue for that -
https://www.drupal.org/project/media_bulk_upload/issues/3023825
✨
Provide a way to add alt text when doing bulk upload
Needs review
)
2. Added alt text after the image was uploaded
3. Added the image to a content of content type
4. The alt text was showing in the source
@kwiseman @hamza_niazi @cedewey Did i missed something
Looking into it !!
@cdmlb Tried it in drupal 10.3.8 , getting no error in console and ad is displaying properly.
Working on it