Aria label overrides link text

@drumanuel i tried above steps , but the issue didnot reproduced at all .

@sourabhsisodia_ I did some testing and found this:

It only seems to happen when "Prevent text wrapping separating the last word from the icon." is disabled AND font-awesome is enabled.

These values is extlink.settings.yml

extlink_use_font_awesome: true
extlink_prevent_orphan: false

Feedback on the MR.

I've updated the MR to address the review in #10.

Comparison of markup with the settings as in #7:

Before:

<p>Here is a mailto link: 
  <a href="mailto:me@example.com" class="mailto" data-extlink="" aria-label="(link sends email)">Email me
    <span class="fa-mailto extlink" role="img" aria-hidden="false">
      <span class="fa fa-envelope-o" data-extlink-placement="append">
      </span>
    </span>
  </a>.
</p>

After:

<p>Here is a mailto link: 
  <a href="mailto:me@example.com" class="mailto" data-extlink="">Email me
    <span class="fa-mailto extlink" aria-label="(link sends email)" role="img" aria-hidden="false">
      <span class="fa fa-envelope-o" data-extlink-placement="append"></span>
    </span>
  </a>.
</p>

Comparison of markup with these settings:

extlink_use_font_awesome: true
extlink_prevent_orphan: true

Before:

<p>Here is a mailto link: 
  <a href="mailto:me@example.com" class="mailto" data-extlink="">Email 
    <span class="extlink-nobreak" aria-label="(link sends email)">me
      <span class="fa-mailto extlink" role="img" aria-hidden="false">
        <span class="fa fa-envelope-o" data-extlink-placement="append"></span>
      </span>
    </span>
  </a>.
</p>

After:
<code>
<p>Here is a mailto link: 
  <a href="mailto:me@example.com" class="mailto" data-extlink="">Email 
    <span class="extlink-nobreak">me
      <span class="fa-mailto extlink" aria-label="(link sends email)" role="img" aria-hidden="false">
        <span class="fa fa-envelope-o" data-extlink-placement="append"></span>
      </span>
    </span>
  </a>.
</p>

This change should also fix 🐛 Text splitting prevents screen reader from reading multiword link text Needs work and 🐛 Accessibility issue - [role="img"] elements must have an alternative text Active . It will probably also make 🐛 Fix Font Awesome markup and CSS Needs review moot.