Glad to see that the logo has been finalised at last. Thanks @vladimiraus for the recognition :)
Hi @megachriz,
I just tried to adjust the strokes according to Feeds logo as you suggested. Please check once if it now looks good to you :)
Hi @ashutosh ahirwal,
Its been a while, haven't heard from you on this. Can kindly have a look at it and see if it properly aligns with your thoughts, then it'd be great if you can move it forward :)
Hi @megachriz,
As per our discussion on slack last night, here is the ai file for the feeds tamper logo.
I’ll leave this upto you from here as you’ve made the final adjustments on the feeds logo so it’ll be easier in that way to have persistent strokes throughout.
Thanks @megachriz, for finalising the logo!
Glad to see it getting a home. I’m super happy right now :)
Hi @Divyanshi,
The theme doesn't come up with any custom CT, the Countries CT that you're talking about is prolly a Custom CT. In order to have styling on that you can extend the theme and create a sub theme out of this and then proceed adding styling for that.
For the same reason it should be categorised as a 'Support Request' and not a 'Bug Report'. Hence I'm closing the issue here.
Moving to NW for resolving merge conflicts.
Back to NW for merge conflicts.
Thanks @akulsaxena, for your prompt action. The changes are reflecting properly, hence I'm moving ahead with this.
Attaching quick screenshot ref for better transparency :)
Ok cool! Thanks @ravi kant for your prompt reply.
Do let me know if I could be of any help :)
Thanks @jaydeep_patel for pointing out this issue. I've observed that it was a legit styling issue and with application of your patch its getting resolved. My testing findings will also echo with @tanuja bohra. Hence I'm moving this forward and recognising your contribution.
Thanks all :)
sourojeetpaul → made their first commit to this issue’s fork.
Hi @megachriz,
Glad to have you back at this issue. Its been a while and as far as I can remember based on our Slack conversations it was almost on the verge on finalisation. Didn't bother you guys in between as you guys might have been tied up.
So ya, waiting for @irinaz's feedback and please do let me know if I could be of any further help!
TIA :)
Thank you all for your time and efforts. The issue is fixed now :)
Hi @tanushree gupta,
Thanks for your prompt action and solving the merge conflicts. The issue is getting resolved by the patch. Attaching screenshots for better visibility and moving the issue forward!
Thank you all. The issue is resolved now :)
Hi @jaydeep_patel,
Thanks for your prompt action. The changes look good to me and its resolving the said issues. Attaching screenshot for quick reference.
Hence I'm moving this forward!
Hello,
@jaydeep_patel The changes on your MR looks good to me, but I don't there was need to open any further MR when there was already an opened MR, we just had to resolve the conflicts. On the other hand @alok_singh, even though the merge conflicts have been addressed and the MR is now mergable, but I don't see the issues which I pointed out have yet been taken care of. Hence moving the issue back to NW.
Please keep any one MR and try to address all these small changes. We shouldn't be opening multiple MRs unnecessarily.
Hi @alok_singh,
The issue is not getting resolved after applying the patch. I think you've missed some nested selectors for which the style is not getting applied properly on those buttons. Attaching screenshots for easy reference and moving it back to NW.
No issues @johnv, Glad to see the issue is fixed now :)
Thanks @danflanagan8, for shipping the logo in and for the recognition :)
@danflanagan8, Thanks for the approval. Raised the MR, please check now!
Hi @jaydeep_patel,
I think wrapping the button in a stacked way was better UI for smaller screens, and if not then atleast we should scale down the padding and font sizes according to the screen size, which I see is not being done yet!
Also at 320px, the buttons are overflowing. So we need to fix that! Moving it back to NW
Hi @shweta__sharma,
The MR is now having some merge conflicts, please resolve those. The changes look good though. So I'm moving it back to NW.
Also @divya.sejekan, The issue of top border disappearing that you've noticed is because you're viewing the responsive screen at 50% zoom level, on making it to 100% the issue doesn't persist. And its very unlikely that someone's gonna zoom out to that extent, so I think we can ignore that perhaps over here!
Hi @alok_singh,
Thanks for having a close look at it, but I don't think it can be considered as an issue, as in the previous version the 'About text formats' is properly aligned with the title and tbh doesn't look that bad to me. Hence I'm closing this now!
Hi @alok_singh,
The MR has now got merge conflicts, please resolve those. I'm moving it to NW for now!
Hi @ravi kant,
Thanks for your concern! Yes it was got behind for a while now. I'm maintaining this actively now and soon gonna make a new release for this. Stay tuned :)
Hello @everyone,
I've resolved all the merge conflicts and MR is now ready to be shipped in!
Thank you all for our kind help. Appreciating the efforts and time put forward by you guys by granting you all credits :)
Thank you all for your active participation on the issue. It'll be added on the new release :)
Hi @manojsaha,
Thanks for promptly acting on it! The changes look good and ready to ship in. I'm updating the MR :)
I think the screenshot can be improved further to showcase the functionality in a more vivid and attractive way! We can go about with the screenshot which is being used on the project page itself.
I'll ask my design team to come up with a nice screenshot for this one before shipping in! IMO stitching the banner and services section into a single image which will confirm to Drupal Theme screenshots dimensions and maintaining a reasonable file size will be a good point to start off!
I was working on it initially when I had very little design knowledge, and now after working on a plethora of PB logo issues, this seems a bit off, hence moving it back to NW :)
Hi @tanushree gupta,
Your MR has new merge conflicts now, can you kindly fix those so that I can ship that in?
Hence I've to move it back to NW!
Hi @alok_singh,
Thanks for creating and working on the issue. I've added a small comment on the MR, so if you can kindly adjust it accordingly, apart from that the MR has some merge conflicts also now, so we need to fix that as well!
Hence moving this back to NW :(
Hello,
Thanks for reporting the issue and working on it. There was legit no clear distinction between menu and main content. After applying the patch that issue is resolved, the MR also looks good.
On the front page it looks absolutely fine to me, but on the individual node page, I feel a scarcity of breathing space between menu and the breadcrumb. Attaching both the screenshots for quick refs. Please have a look and will be highly appreciated if you come up with any solution to fix that. Hence I'm moving that back to NW :(
Thanks and Regards!
Hi @shweta__sharma,
Thanks for pointing out the issue and working on it. The alignment of the buttons still seems a bit off to me, both should be aligned in a similar fashion. Also there's a merge error which needs to be fixed, hence moving this again back to NW
Thanks @shweta__sharma for reporting and addressing the issue. I've cross checked again and yes now the issue is resolved after applying the patch, also the changes look reasonable. The footer menu styling looks much better and cohesive this time. Hence I'm moving this forward to fixed :)
sourojeetpaul → made their first commit to this issue’s fork.
Thanks @shweta__sharma,
The issue is getting resolved with your patch, I've tested the same on drupal 10.3 as well and it works fine! I'm merging this right away.
It'll be fixed once a new release is rolled out, which I'll do real soon!
sourojeetpaul → made their first commit to this issue’s fork.
This is what wave tools is also reporting in terms of accessibility that I've mentioned on my previous comment!
Also on using img tag alt attribute is missing. Though I'd like to get rid of img tags here :)
Hello everyone,
Thanks for taking time out and working on the issue. I appreciate the efforts. Though the MR looks good and apparently solves the issue, but I see further scope of improvement on it.
1. The a tag is missing href, title and aria-label attribute which will cause accessibility issue.
2. Styling of cursor should be changed to a pointer on these, which generally done in case of all a tags.
3. It'll be better in terms of performance to use any icon-font library like fontawesome or icomoon icons instead of wrapping svg icons over an img tag.
4. To ease the UX, IMO it'll be better to have these configurable through a theme settings form. Its not handy to override templates to add desired social media links!
I loved the way the hover effects have been incorporated with the gradients, but a bit sceptical about the X logo hover effect, tbh not looking that great to me, on bonus if anyone can come up with any alternative hover effect that'll also be appreciated!
Hence I'm moving this issue to NW again and updating the IS for better clarity :)
Hi all,
I'm the new co-maintainer of this theme and in the coming days will be actively clearing up the issue queue and maintaining it. Today onwards I'm starting off with this one :)
Thanks for your contribution and making the theme compatible with D10. I've also tested the patch and its now compatible with 10.3 as well!
I'll create a new release very soon once a reasonable amount of issues have been addressed and it'll get fixed on that!
Hence moving it forward and recognising the efforts put forward on this by you guys :)
sourojeetpaul → made their first commit to this issue’s fork.
Hi @ravi kant,
First of all, I'd like to say I loved using your theme, and its good to see that you're open to have discussions regarding improvement scopes for the same. Though in this comment I'm not gonna talk about any UI changes, rather I'd like to highlight some parts regarding automation and coding standard. As of now, the theme is missing stylelint and eslint configuration, so I think it'll be a good idea to have these configurations on the theme, so as to align the Js and stylesheets with the widely used industry standard. Apart from that, we can have functions defined for these as well on the gulpfile, in order to get notified while building the assets on the go, which in turn can seem to be effective on streamlining the whole process.
So I was thinking to go about creating a couple of issues encompassing these:
1. Configure stylelint and eslint.
2. Have linting functions defined on gulp build tool.
3. Address the errors thrown while linting on the existing codebase.
4. Address Phpcs issues(if any) to have a clean and standardised codebase.
Moving the issue to NR, to listen to your thoughts!
Yes @danflanagan8, You got me right! That's what I thought while creating this version as basically Drupal View is used like a 'query builder' with an ability to create 'relationships' to fetch data accordingly, I came up with this one.
And obviously it'll look good in smaller dimensions as you've mentioned earlier. Attaching the new one here. Please have a look and let me know, should I open the corresponding MR!
Hello there,
Looks like @debdeep.mukhopadhyay might be caught up on something else, so in the mean time I've managed to get something done.
Please have a look and chime in your thoughts!
Hi @kristen pol,
Its been a while, and I've came up with one variant. Can you kindly have a look at it and share your thoughts on this?!
Hi @danflanagan8,
Sorry for the delay, I was on vacation in the mean time! Came up with one more with less busy stuff! Please have a look at it once and let me know your thoughts!
Hi @alok_singh,
I've applied your patch and it got applied cleanly. The styling issue is also getting resolved with this one. Though IMO the focus outline is bit too wide, so decreasing that a bit will be better. And for that reason I'm moving this again to NW.
I'm attaching before and after screenshots for better reference.
@riddhi.addweb I'm not sure how you're applying the patch, Please try once through composer way, I hope you'll able to get it applied cleanly!
Sorry, forgot to add the before and after screenshots for quick reference. Here it is!
Hi @debdeep.mukhopadhyay,
I appreciate your solution which will come handy in resolving the issue, but seems like a little mistake in the class name on which the CSS needs to be targeted!
I'm not sure why you haven't raised its corresponding MR, as its labelled as 'Bug Report' we should provide an MR/patch on addressing that.
Simply commenting an providing assistance is generally being done at 'Support Requests'. Also please make sure to unassign yourself from the issue after you've done your job , so that others can participate in!
I've made some tiny changes and raised the corresponding MR for the same. @leopathu Hope it'll help on resolution to your reported problem. Please have a look and help it move forward. Though I'm not sure whether the maintainer's would like to ship that in, cause I don't think its something of a style break or so.
sourojeetpaul → made their first commit to this issue’s fork.
Hi @mwjansen,
Thanks for pointing out the issue, I've successfully reproduced the same. Though your patch is getting applied cleanly, but I'm sorry to inform that it doesn't resolve the issue. Can you kindly re-check the same!
Attaching a before after screenshot for your reference along with how its behaving on setting Olivero as default theme. Hence moving it to NW as of now!
Hi @debdeep.mukhopadhyay,
I've had a quick glance at your logo, but it doesn't seem to be aligning well with the module's functionality IMO. So I'd prefer to see other alternatives as well! Hence moving it back to NW!
Hi @debdeep.mukhopadhyay,
I've reviewed your logo and tried to match it with the module's functionality. Idk what you tried to decipher through the 'shield', it looks more of security related thing to me. So I'm not happy with this logo! On the other hand its basically for download purpose whereas what you've shown is quite the opposite.
Hence I'd prefer to have a better alternative in this case and moving this to NW!
Hi @debdeep.mukhopadhyay,
The logo looks good and clean. It also aligns with the module's functionality and confirms with PB logo constraints. Hence I'm moving it to RTBC++
Hi @debdeep.mukhopadhyay,
The logo looks good and clean to me! It also aligns with the module's functionality and confirms with PB logo constraints.
Hence I'm taking this forward and moving it to RTBC++
Hello there,
On aligning with the module's functionality, I'll vote on @debdeep.mukhopadhyay's 2nd one or @AaronDeutsch's one.
I completely agree with @AaronDeutsch here, as having too much descriptive visual elements will make it quite busy and hard to visualize on a such a small render on 'Browse Projects' page. Where having a simple rudimentary version like the one provided by Aaron will look cleaner!
Moving the issue forward to RTBC++, but would like to defer to the maintainer's choice here.
HI @debdeep.mukhopadhyay,
The logo looks good to me. Though the 'in-place editing' aspect can not be guessed from here, but I think that'd be okay as its not possible to incorporate everything on such a small logo, which will in turn rather make it quite busy. So IMO we're good with it!
Hence moving it forward to RTBC++
Hi @AaronDeutsch,
Looks like you might be caught up on something else. So I tried to have a look back at it again and came up with my version of logo.
Please have a look at it and do let me know what do you think about my previous comment!
Hi @catch,
Though after fixing the syntactical errors, the patch is now cleanly getting applied and entity_links filter is getting listed among the available filters to be enabled, but on trying to enable the filter its trowing an Ajax error on the console, which is due to the fact that we're calling the loadMultiple() method of EntityLinkSuggester, but the entity was never defined in the codebase. So I think the MR is still missing some files!
Please correct me if I'm wrong :)
That's why I resorted back to the previous solution that @wim and others have provided, to experience the functionality. Also played around and performed a bit of testing on that to ensure that the previous issues which were mentioned have been addressed well and jotted down few pointers, which IMO will be an enhancement on top of that, or incorporate those in this latest approach.
1. On linking to a downloadable media, and coming back to that again on editing, the toggle as well as the downloadable state remains unchanged. So the issue that @mark_fullmer had mentioned seems to be resolved!
2. I wasn't able to reproduce the 'Update' button styling issue on the Link Suggester modal that @rkoller had mentioned. the 'Update' and 'Delete' button styling over there looks good to me!
3. Though the strike-through over the entity names doesn't seem to be causing much of a big deal in terms of accessibility to visual impaired users, but I think there's a design inconsistency happening. On deselecting the entity type the strike-through happens while deselecting the bundle remains clean with just the unchecking of the checkbox, so IMO it'd be better if we can style both of them in a single pattern.
4. Tested the issue that @pameeela had mentioned that link suggester settings not getting saved properly, but now I see its getting saved properly and coming into effect as expected. Keeping only Node A checked by deselecting Node B, as expected its restricting to the contents of Node A only and not showing any content of Node B while linking from CkEditor.
5. Performed a quick accessibility testing using Wave tools for the missing 'title' attribute on the a tag, on which there's a discussion on this issue, but honestly that doesn't seem to be an issue to me and Wave is also not reporting any issues for the same!
6. Coming to the linking aspect of Comments, I'll also echo the same as of you and @pameeela. Couldn't find major use case for this one, rather its a super confusing one with the fact that @pameeela already pointed on the earlier threads.
I found one difference from the way we're implementing here vs the way D.O does the same, as D.O uses specific comment id for each of the comments and uses the same as anchor linking, thereby we reach to that specific position of the webpage directly, whereas in our case as we're referring to the comment entity which in turn actually referring to the node, where the comment have been added. And let's say on such a blog post or webpage if there're tons of comments like this issue thread :) then there's no point on landing the user at the very beginning of the same, where the user have to manually scroll down to that specific comment again. It'll be a pretty bad UX IMO.
7.
you wouldn't link to the link, you'd link to the page that the link points to maybe
I'd partially agree with you and @pameeela on the 'Custom Menu Link' aspect. Though it'll link to a page but I think giving the ability to search and link to the page using menu titles might be easier for content editors, specifically when instead of referring to a node or any other internal link the link is of an external one.
Now coming to the part, which I think can be a great enhancement on top of it:
1. Moderation State Indication: On incorporating workflows and content moderation, though we can restrict the view permissions based on roles but there are no way we can restrict linking to 'Unpublished/Draft' contents as of now. I don't think that makes any sense at all to link to an Unpublished content that the end users might not access and without any sort of indication for the same on the list the content editor might accidentally link to such a content. So I strongly feel that you should somehow indicate about the content's current moderation state, which IMO will be more helpful than the authoring date information.
2. Permission based suggester access: As of now we can create multiple link suggesters, but there's no way to restrict and assign the same based on user role. Let's say we have multiple content editors and we want to give them different linking privileges and thus having the option of creating multiple suggesters will make more sense!
3. Suggester Clubbing: Though we can define multiple link suggesters and use them in different text formats and editors, I was thinking about from a more user role perspective.What if we give the user an ability to club multiple suggesters. Circling back to my previous example:
On a group of multiple content editors, we defined different link suggesters for each of the roles with defined access privileges, and for the Content Head/Editorial Head instead of creating a new suggester from scratch, we can just club all the suggester groups that we've created for other editors.(basically a multi-select of the existing ones).
Attaching the screenshots of my testing for quick reference!
I’ll be all ears for your feedback soon! Thanks :)
Hi @catch,
Thanks for your kind words and motivation. Its not that I haven't yet came across Core contributions, I've actually worked on a no of core issues and thankfully enough, got recognised for 3 of them as of now. I'm aware that Core issues are bit tricky and threads go on for a longer period of time. But this one is truly exceptional and interesting to work on, and lengthiest as of my experience. Sharing the similar thought I've started looking forward to Core issues as that provides a solid learning experience.
I've already pushed my changes on your branch before making the previous comment, but I was also wondering why that's not getting shown on the threads. Is it because you've kept the MR as draft?
Here's the commit link: https://git.drupalcode.org/project/drupal/-/merge_requests/9807/diffs?co...
Please have a look and pour in your valuable feedback :)
I'll dig up further from tomorrow, had to scratch my head a lot today on this. Was getting quite a few issues while applying the patch, but luckily resolved those, and now my system also gave up by running multiple instances xD
Hii,
Wooh quite a pretty long comment thread, probably the longest I've participated yet! I think I was living under the rock till now and just couple of days ago discovered this from Drupal Slack. I'm quite excited and thrilled about this new feature request, it'll be a complete game changer and much awaited one!
After going through all the comments from the beginning, I must acknowledge that I got an enriching learning experience, got to know about many intrecacies that I wasn't even aware of till now!
Though the issue seems to be requiring of supreme experience, but I couldn't resist myself to participate here.
As of now, just noticed some tiny syntactical errors for which after applying the patch, the site and drush was getting crashed, so did some quick tiny fixes. I'll keep on having a look at it from tomorrow again to investigate and test further!
Thanks and Regards :)
Thanks @mondrake for the recognition!
Hi @mondrake,
I've raised the MR. Please have a look :)
@mondrake, Thanks for the prompt feedback! Sure I'm raising the MR right away!
I'm having a look at this!
Relying on maintainer's review for this one, to finalise!
Hi @manojsaha,
Nice logo! This is properly aligning with PB logo constraints, hence moving this forward from here to RTBC++
Hello there,
Nice logos folks! As per the module's functionality I'll prefer the one provided by @manojsaha, and the first one of @siramsay.
Both of them are properly following the PB logo constraints, hence I'm moving the issue forward to RTBC++
Though I'll defer to the maintainer for finalising the one!
Hi all,
Sorry for late joining into the party! After having a look at all the logo alternatives that have been provided here and going through all the feedbacks, my take is going to align with @mparker17
I've worked on another PB logo issue for a project maintained by him: Sitemap
https://www.drupal.org/project/sitemap/issues/3459435
📌
Project Browser: Create a logo for Sitemap
Active
@louis-cuny Even there I had prepared the logo for the module in similar thought like yours but later on @mparker17's argument seemed legit to me, as that has high chances to set erroneous expectation among user.
We can definitely modify the logo according to the enhanced functionality that has been proposed by you, but as of now I think it'll be better to restrict the logo to visually represent only that aspect which is available right now.
In worst case scenarios it might happen that the newly proposed functionality might get shelved for quite a few time, which in turn will increase the wrong predictability in multi folds.
Thanks @manojsaha for your efforts and contribution. The logo looks good to me, hence I'm moving this forward to RTBC++
Hi @tirupati_singh,
Thanks for working on the feedbacks! This looks better to me now. Though not sure why we're providing patches, raising MR is the recommended way!
Moving this forward to RTBC++
Hi @heddn,
I've opened the MR, Please have a look and merge :)
Thanks!
Hi @heddn,
Glad you liked this one. Then should I proceed and raise the MR for the same?
Hi @danflanagan8,
Thanks for your valuable feedback! We can certainly have a look at an alternative but I'm quite sceptical on one point: Trying to make the logo nice and clear on a 48X48 dimension will make it look more like an icon rather than a logo. I'm not sure why we're concerned about how gitlab renders it! The project browser logo is intended to be shown on 'Browse Projects' page, for which as you've mentioned 60X60 can be a good starting point to keep in mind while making the proposed changes. On an attempt to make it prominent on 48X48 will make the logo more busy which will rather seem to be having much negative spaces on a larger dimension.
Hi @heddn,
Thanks for your feedback. By incorporating a version specific drupal logo I wanted to show migration from one drupal version to another.
As per your requested changes, I've now used same Drupal logo which is version independent! Please have a look once again
Hello there,
Sorry for the delay, I got caught up on something else in the mean time. Clearing up the issue queue today.
As per the latest conversation as the stated problem is getting resolved through another issue, thus I'm labelling it as a duplicate issue.
I highly appreciate the contribution from all of you, so I'd be granting credits to all of you for putting in your efforts and valuable time!
Thanks :)
Hi @tirupati_singh,
Thanks for your contribution. The MR is working effectively and making the theme compatible with D11. I think we can ship this and roll out a new release now. Moving it to RTBC++
Attaching before and after screenshots for quick reference!
Hi @esha_kundu,
I've applied the patch and the issue is resolving after patch application. Also the MR looks good to me. Hence moving this to RTBC++
Attaching before and after screenshots for quick reference!
Hi @manojsaha,
Thanks for your contribution! The logo perfectly aligns with the PB logo
constraints as well as it also aligns with the module's functionality. Hence moving this forward RTBC++
Hi @manojsaha,
The logo looks good to me and it was good idea to use the logo which was already there in the project page. And I agree with you that using gradient will increase the file size, so that's not a big deal over here.
I had a word with @kristen pol, on DS over another issue, where she said, the file size constraint is not that much of a hard and fast rule, but we should definitely keep the size below 20KB. So I'm ignoring the minor oversize in this case and moving it to RTBC++.
Hi @manojsaha,
Thanks for your contribution! The logo perfectly aligns with the PB logo
constraints as well as it also aligns with the module's functionality. Hence moving this forward RTBC++
Hi @gaurav gupta,
The changes seems reasonable. The theme is now compatible with D11. Hence moving it to RTBC++
Attaching before and after screenshots for quick reference!
Hi @johnv,
To address your doubts regarding the pointers 2 and 3.
Project Browser doesn't yet incorporate an API to pull realtime latest changes from D.O. That was in queue in the mean time and thus was not appearing on the 'Browse Projects' page. But now its clearly appearing on that page. I'm attaching a screenshot for quick reference!
As far as the pointer 3 is concerned, Project Browser logo won't appear on the add-field page, PB logo are not related to that. To have a nice icon over there we've to open a new issue and work on that, we can definitely ship this logo (a resized version) to fit as an icon for the field type.
Hope it answers your queries :)
Issues needs to be transitioned to proper state. I'm picking it up for review now!
Hi @tirupati_singh,
Thanks for the prompt action. The patch is resolving the alignment issue of the quick search form of admin toolbar, though there are a few styling changes which will be good to have. I compared the styling with Bootstrap5's styling and noticed some differences, which caught my eye. On Civic theme the border of the form is bit large and placeholder text too seems to be a bit large. We're getting to see a green border on focus which IMO is not looking that great, I'm just thinking if we can address these small styling issues so that the quick search panel looks cohesive on different themes as well! Thus I'm moving this once again to NW.
Attaching screenshots for both the themes for easy reference!
P.S: The patch name should incorporate the comment number instead of demarcating it with 'updated' so it'll be easy to track the progressive enhancements.
I'm testing this one, seems like @bbruno might be caught up on something else right now!
Hi, sorry for the delay. I was a bit tied up on other development work. As per the latest conversations over here, I'd echo with @richardgaunt,
as we're using visually hidden class, so it'll be accessible by screen readers on the other hand incorporating the title attribute so as that we can have a nice tooltip over it, sounds a good progressive enhancement.
Hi @tirupati_singh,
Thanks for the findings. Even I've faced the same issue and on investigation i'll report the same. On 1.8.1 onwards the admin toolbar search is not at all visible, but on 1.7.1 the toolbar is visible but positioning is not correct! On applying the patch the position of the admin toolbar search is getting fixed, however the styling seems to be a bit wrong. the input field is not taking full width of the same. So I was just thinking if we can address that over here as well! Also providing a MR will be preferable over a patch, so can you kindly covert the patch to an MR.
Attaching all the screenshots for reference.
Hi @tirupati_singh,
Thanks for reworking on it. I can see the feedbacks have been resolved properly now, and also limiting to the PB logo constraints. Hence I think we can move the issue forward to RTBC++
Hi @debdeep.mukhopadhyay,
I've reviewed your logo and I got a bit confused by the visual elements used in it. Can you kindly explain the significance of the visual elements that you've incorporated here?
In Drupal's POV View is not something related to the visual appearance of content, rather its more of a query builder which comes into play to show results based on certain parameters and can have filteration and sorting capabilities, hence the 'Eye' element in the logo seems to be a bit misinterpreted!
I'm a bit afraid that the logo is not at all showcasing the module's functionality. IMO here we should try to connote the module's functionality through the PB logo. Hence I'm moving this to NW!
Hi @manojsaha,
Thanks for your contribution! The logo perfectly aligns with the PB logo
constraints as well as it also aligns with the module's functionality. Hence moving this forward RTBC++
Hi @manojsaha,
Thanks for your contribution! The logo perfectly aligns with the PB logo
constraints as well as it also aligns with the module's functionality. Hence moving this forward RTBC++
Hi @manojsaha,
Thanks for your contribution! The logo perfectly aligns with the PB logo
constraints as well as it also aligns with the module's functionality. Hence moving this forward RTBC++