- Issue created by @Divyanshi
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 9:32am 22 February 2024 - Status changed to Needs work
about 1 year ago 10:15am 29 February 2024 - 🇮🇳India alok_singh
Hi @divyanshi Please rework on menu that is still distorted, when added some submenu.
Also when i add extra menu item is not shown styled.
Added screenshot for reference.
when applying patch there is also message of warning: 1 line adds whitespace errors.
Thanks.
- Assigned to niharika.s
- Merge request !20Issue #3423145: Menus get distorted while adding menus → (Merged) created by Unnamed author
Hi @sandip poddar,
Thanks for picking it up! The MR got applied cleanly, but I don't get to see any difference even after applying the patch. The submenu is not getting expanded on hover. Can you kindly have a look at it again?
Attaching before and after screenshots for ref.Hi @sourojeetpaul,
I was previously working on this issue in Drupal 9, and I have now reproduced it in Drupal 10. Could you please review the MR From my side, the hover effect appears to be working as expected.Additionally, I resolved the merge conflict and made updates to menu--main.html.twig to address the issue.
Hi @sandip poddar,
The merge conflicts have been resolved as I can see and now I'm able to see your results coming into play. But I've some concerns regarding the styling and the behaviour of the expanded menus. The sub menu panel is completely blending with the white background, so I'd like to see a distinction b/w them, we can implement that by adding a box shadow. Also we should also consider for multi-level expanded menu, which I think haven't been resolved! I'm moving it back to NW once again, please have a look.
Attaching screenshots for better ref.Hi @sandip poddar,
The changes look good to me now, the suggested changes have been incorporated well. Thanks for the prompt action. I'd be happy to ship it in!
Adding screenshots over here for better visibility and tracking.-
sourojeetpaul →
committed 418a4c25 on 1.0.x authored by
sandip poddar →
Issue #3423145: Menus get distorted while adding menus
-
sourojeetpaul →
committed 418a4c25 on 1.0.x authored by
sandip poddar →
Automatically closed - issue fixed for 2 weeks with no activity.