- 🇮🇳India Ashutosh Ahirwal India
Hi @sourojeetpaul Sorry for the late reply can you updated the color which is exist in the background color of login button found on tabs.
- @gauravvvv opened merge request.
- 🇮🇳India riddhi.addweb
The mentioned page issue is resolved, & I have also checked and it is working as expected. Attaching the Screenshots & doing RTBC for the same.
Note:- In our system Contact Us text is changed to the Website Feedback text. - 🇮🇳India riddhi.addweb
The mentioned page issue is resolved, & I have also checked and it is working as expected. Attaching the Screenshots & doing RTBC for the same. Also, need to create a new issue ticket as in mobile devices, the table and site are not displayed properly, attaching SS for the same.
- 🇮🇳India Gauravvv Delhi, India
Gauravvvv → made their first commit to this issue’s fork.
- 🇮🇳India Aakansha Tyagi
@tanuja bohra you didn't add
manually before table tag and give it overflow-x: auto; then it will work fine. - 🇮🇳India Aakansha Tyagi
@zkhan.aamir you are trying with wrong command. please use this one git apply -v [patchname.patch]
- 🇮🇳India Aakansha Tyagi
@Tanuja Bohra descriptuon field is usually bigger than other fields thats why there is difference between the fields width.
- 🇭🇺Hungary Balu Ertl Budapest 🇪🇺
Balu Ertl → made their first commit to this issue’s fork.
Hi @ravi kant, after making changes in scss file Comment section looks good. MR10 is working fine.
I have added the SCSS file that I mistakenly forgot to include. Here is the screenshot for reference.
Hy @pray_12 ,
I have applied patch #8, It fixes the issue of mobile responsiveness and table looks fine!
Thank You.
- 🇮🇳India zkhan.aamir
@Aakansha Tyagi This patch is not applying showing error
Can you please check once. @Aakansha Tyagi, Table is not responsive on mobile and top border grey line is missing.
Hello @Ashutosh, Haven't heard from from you for while now, regarding this.
Can you kindly clarify the confusion mentioned in the comment #6 🐛 Need to design login page with tabs Needs work@Aakansha Tyagi, can we make all input fields with same width? Check the "/contact" page
- 🇮🇳India zkhan.aamir
Hi,
Patch #2 applied successfully.
working as per the theme.
SS for reference. Hi, applied patch #8, the table looks good on desktop as well as mobile views. Attaching the screenshots for reference.
- @gauravvvv opened merge request.
- 🇺🇸United States smustgrave
Reviewing 🐛 Remove default colon behind inline labels Needs work and agree this appears to be a duplicate.
- 🇮🇳India Yashaswi18
I applied MR!30, I'm seeing some issues with spacing on top and bottom. Attached SS for reference.
Verified MR6 on 10.3.x, the space is added before read more button. RTBC++
- 🇮🇳India zkhan.aamir
Hi,
Applied MR#10
Comment section looks good also the code is also updated. - @silviaddweb opened merge request.
I have improved the CSS and the order of the content of the node. Additionally, if you want to further improve the design of the node, you can change the order of the navbar menu and the page title using the block layout. You can also remove any unwanted blocks from the header through the block layout.
Here is the MR: https://git.drupalcode.org/project/techy_news/-/merge_requests/30
Here is the screenshot I am attaching for the reference:- @tanushree-gupta opened merge request.
- Issue created by @dev16.addweb
- 🇮🇳India ravi kant Jaipur
Need to add styles in SCSS files then compile for css file.
- 🇮🇳India ehsann_95
The code changes seems fine and the spinner is rendering below gear icon. Attaching screen capture for reference.
- 🇮🇳India riddhi.addweb
I have applied the patch, but it is not working.
The table alignment is the same even after applying the patch.
Please check the SS for the Reference. - 🇮🇳India sdhruvi5142
Hi
Verified MR13! and the fixes are working as expected.Testing Steps followed:
1. Install Bulma theme with Drupal 10.
2. Install and enable the Web from module.
3. Create a form with some required fields. Changes observed here.Testing result:
The asterik(*) are being properly working as expected for the required fields.Status : PASS
Attaching SS for reference. - 🇮🇳India Gauravvv Delhi, India
Gauravvvv → made their first commit to this issue’s fork.
- @gauravvvv opened merge request.
- 🇮🇳India Gauravvv Delhi, India
Gauravvvv → made their first commit to this issue’s fork.
- 🇳🇿New Zealand quietone New Zealand
The MR here was created on 1 May and then this was set to RTBC with no review of the MR. This should have a a review of the latest MR and manual testing of that. Setting back to NW.
Automatically closed - issue fixed for 2 weeks with no activity.
The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇦🇺Australia VladimirAus Brisbane, Australia
- Switched to 11.0.x branch
- Fixed stylelint
The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇪🇨Ecuador jwilson3
I've mentioned this issue in docs in two places:
-
https://www.drupal.org/docs/develop/standards/css/css-file-organization →
Diff: https://www.drupal.org/node/1887922/revisions/view/13469196/13569583 → -
https://www.drupal.org/docs/develop/theming-drupal/adding-assets-css-js-... →
Diff: https://www.drupal.org/node/2216195/revisions/view/13563347/13569585 →
-
https://www.drupal.org/docs/develop/standards/css/css-file-organization →
Automatically closed - issue fixed for 2 weeks with no activity.
- 🇪🇨Ecuador jwilson3
Agree this is fairly frustrating and more than slightly nonsensical that there is no way to define a "base" SMACSS in a theme and make it appear first before module code and even before other SMACSS groups from the same theme.
Even stable9 theme in Drupal core suffers from this exact issue out of the box:
Given the following three examples...
stable9.libraries.yml:
css: base: css/core/assets/vendor/normalize-css/normalize.css: { weight: -20 }
core.libraries.yml:
internal.jquery_ui: css: component: assets/vendor/jquery.ui/themes/base/core.css: { weight: -11.8 } theme: assets/vendor/jquery.ui/themes/base/theme.css: { weight: -11.8 }
system.libraries.yml:
base: css: component: css/components/ajax-progress.module.css: { weight: -10 }
One would expect normalize.css to be the first CSS file in the HTML, but in fact, it shows up last.
Expected result:
/core/themes/stable9/css/core/assets/vendor/normalize-css/normalize.css /core/assets/vendor/jquery.ui/themes/base/core.css /core/themes/stable9/css/system/components/ajax-progress.module.css /core/assets/vendor/jquery.ui/themes/base/theme.css
Actual result:
/core/assets/vendor/jquery.ui/themes/base/core.css /core/themes/stable9/css/system/components/ajax-progress.module.css /core/assets/vendor/jquery.ui/themes/base/theme.css /core/themes/stable9/css/core/assets/vendor/normalize-css/normalize.css
- 🇮🇳India Mithun S Bangalore
Added a rebase and resolved the merge conflicts. Please review.
- 🇮🇳India Mithun S Bangalore
Mithun S → made their first commit to this issue’s fork.
@Divyanshi, getting this error on applying the patch -
error: contrib/business/css/style.css: No such file or directory