#CSS

Just following up if this should be re-open,. if no follow up in 3 months could be closed

Issue summary appears incomplete.

Was previously tagged for tests which still appear to be needed.

Hi @snehal-chibde, your question sounds good to me.

@catch, @nicxvan can you please guide here should i create tablesort.css inside claro/css/components folder or the above MR using claro/css/classy/components/tablesort.css is good to go ?

Hello @sandip, I have reviewed these changes on Drupal 11.x-dev, I see no regression but I have a question.
Why are we placing the file tablesort.css in 'themes/claro/css/classy/components/tablesort.css' whereas we have all table related files such as table.css, tabledrag.css etc in 'themes/claro/css/components/tabledrag.css'? Ideally it should be placed in same components folder. Can you please check once.
Added screenshots of tablesort part which is working fine.

Created MR but it is failed due to the Nightwatch pipeline on `ckEditor5EditorHeightTest.js`, which is unrelated. pipeline passed for the relevant areas.

sanket.tale → made their first commit to this issue’s fork.

Please review the changes.

I removed this piece of code as i think we dont need this part and also tested in local.

.sortable-heading > a:focus,
.sortable-heading > a:hover {
  -webkit-text-decoration: none;
  text-decoration: none;
}

It has been over a year and no one has responded to @smustgrave comment. I agree with closing this. Work on CSS standards is being done in #3257287: [Policy] Create CSS standards for core use of CSS custom properties (aka CSS Variables) →

I am looking into it.

@liquidcms A true revert would either be a patch or overriding the two JS files updated but the quickest way to go back to the earlier behavior is probably to disable the scroll lock immediately after it is activated.

in a custom module add a jQuery event listener on 'dialog:aftercreate', which is triggered immediately after the scroll lock is added.

In the callback, run the same code that is run when the modal dialog closes

const $scroll = $element.find('.scroll');
    if ($scroll.length) {
      bodyScrollLock.unlock($scroll.get(0));
    }

This might not be it line-for-line, I didn't actually try it, but this approach should work - fortunately an event is dispatched right after the scroll lock so it's quite available for disabling.

This seems to be "fixed" in 10.4. Can someone suggest how to revert this back to the way it was in D9 (despite everyone saying no one would want to scroll the background when a modal is open, my client is pretty annoyed this is now broken).