Montevideo
Account created on 24 May 2013, about 12 years ago
#

Merge Requests

More

Recent comments

🇺🇾Uruguay ruby232 Montevideo

ruby232 changed the visibility of the branch 1.0.x to hidden.

🇺🇾Uruguay ruby232 Montevideo

All jobs in the pipeline ran successfully. I'm closing this issue to prepare for the upcoming beta release.

🇺🇾Uruguay ruby232 Montevideo

@liuyuanchao
Thank you very much. GitLab CI works fine with your commit to review the code standards. Now, let's fix all the remaining code standard issues in this project.

🇺🇾Uruguay ruby232 Montevideo

@liuyuanchao
I agree with you—I had planned to add this configuration, but I haven’t had time to review the documentation.

Do you have the know-how to enable the CI job, or a link to the documentation?

🇺🇾Uruguay ruby232 Montevideo

I moved the CSS file to the root of the module, as I thought this was more appropriate.

🇺🇾Uruguay ruby232 Montevideo

@jleon1110
Thank you for your contributions. Kindly remove the 'Draft' status from the MR so I can proceed with the merge.

🇺🇾Uruguay ruby232 Montevideo

@jleon1110
Thanks for your MR. I’ve reviewed the code and left a few comments.
I believe this MR is missing two important cases:

  • Handling for existing sites
  • Setting a default value

You can add a config/install/lite_youtube.settings.yml file with the default configuration. This file will be loaded when the module is installed and will set the initial values.

Additionally, you need to create a hook update to update the configuration for sites where the module is already installed.

🇺🇾Uruguay ruby232 Montevideo

I think it's better to automatically add the language collection and only import it if the corresponding configuration files exist.

🇺🇾Uruguay ruby232 Montevideo

@apereira23
I think the best option is to create a plugin for generating ZIP files, and add a configuration form to allow users to select the option to create the ZIP.
Some sites might not have the ZIP extension installed, so in that case, it would be a good idea to use a third-party library to compress files.

🇺🇾Uruguay ruby232 Montevideo

@apereira23 I describe my interpretation of the problem and two possible solutions in a picture:

I prefer the last solution, but there are two problems. It always duplicates the storage usage, and the zips are always public. However, it is more efficient to create the zip when the admin saves the entity. Creating the zip is hard on the CPU and can be easily exploited if the zip is created when the user requests the file. It is better to create it beforehand.

🇺🇾Uruguay ruby232 Montevideo

I think it's a good idea to validate the label size to prevent exceeding the limit, and to save the download_fields using a method other than serialization.

🇺🇾Uruguay ruby232 Montevideo

One solution could be to generate the filename with a random name or using the timestamp.

🇺🇾Uruguay ruby232 Montevideo

Thanks for the feedback. I've implemented the changes and pushed them.

🇺🇾Uruguay ruby232 Montevideo

I'm waiting for the Automated Drupal 11 compatibility fixes for youtube 📌 Automated Drupal 11 compatibility fixes for youtube Needs review , because this module depends on the youtube module.

🇺🇾Uruguay ruby232 Montevideo

I reduced the logo size using pngquant tool and added the logo.png file to the Git repository.

🇺🇾Uruguay ruby232 Montevideo

I reduced the logo size using pngquant tool and added the logo.png file to the Git repository.

🇺🇾Uruguay ruby232 Montevideo

I reduced the logo size using pngquant tool and added the logo.png file to the Git repository.

🇺🇾Uruguay ruby232 Montevideo

I reduced the logo size using pngquant tool and added the logo.png file to the Git repository.

🇺🇾Uruguay ruby232 Montevideo

I reduced the logo size using pngquant tool and added the logo.png file to the Git repository

🇺🇾Uruguay ruby232 Montevideo

I reduced the logo size using pngquant tool and added the logo.png file to the Git repository

🇺🇾Uruguay ruby232 Montevideo

These are two logos options created by @luciana-cisneros. I prefer Tailwind-2.png.

🇺🇾Uruguay ruby232 Montevideo

These are three logos options created by @luciana-cisneros. I prefer Redirect 410-3.png.

🇺🇾Uruguay ruby232 Montevideo

These are three logos options created by @luciana-cisneros. I prefer YouTube-3.png.

🇺🇾Uruguay ruby232 Montevideo

These are three logo options created by @luciana-cisneros. I prefer Paragraphs Modal Add-3.png .

🇺🇾Uruguay ruby232 Montevideo

These are three logo options created by @luciana-cisneros. I prefer davatar-3.

🇺🇾Uruguay ruby232 Montevideo

These are three logo options created by @luciana-cisneros. I prefer devutils-3.

🇺🇾Uruguay ruby232 Montevideo

I reduced the logo size using pngquant tool and added the logo.png file to the Git repository.

🇺🇾Uruguay ruby232 Montevideo

Alpha 1 has been released.

🇺🇾Uruguay ruby232 Montevideo

This module is deprecated, Replaced by: Lite Youtube.

🇺🇾Uruguay ruby232 Montevideo

ruby232 created an issue.

Production build 0.71.5 2024