- Issue created by @pponcedeleona
- ๐ฎ๐ณIndia vinodhini.e chennai
@pponcedeleona,
I have fixed the coding standards issues.
Steps followed:
Ran phpcs to identify the violations.
Fixed the detected issues using a combination of automated and manual adjustments.
Re-ran phpcs to confirm that all violations have been resolved.
I have updated the two files โ please review them. Thanks.
- ๐ฏ๐ตJapan liuyuanchao
Isn't it better to add a .gitlab-ci.yml file to enable the ci job.
- ๐บ๐พUruguay ruby232 Montevideo
@liuyuanchao
I agree with youโI had planned to add this configuration, but I havenโt had time to review the documentation.Do you have the know-how to enable the CI job, or a link to the documentation?
- ๐ฏ๐ตJapan liuyuanchao
Here is the page
https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... โ
Adding a default template is very easy.
- ๐ฏ๐ตJapan liuyuanchao
@ruby232
I add a default .gitlab-ci.yml file in branch 1.0.x.
Could you make a MR to check if it could work. - ๐บ๐พUruguay ruby232 Montevideo
@liuyuanchao
Thank you very much. GitLab CI works fine with your commit to review the code standards. Now, let's fix all the remaining code standard issues in this project. - ๐ฏ๐ตJapan liuyuanchao
Thank you for testing.
And I fixed the phpcs errors. - 945dd927 committed on 1.0.x
Issue #3530630: Align Code with Drupal Coding Standards
- 945dd927 committed on 1.0.x
- ๐บ๐พUruguay ruby232 Montevideo
All jobs in the pipeline ran successfully. I'm closing this issue to prepare for the upcoming beta release.