🇯🇵Japan @liuyuanchao

Solve the conflicts.

liuyuanchao → made their first commit to this issue’s fork.

Fixed.
https://git.drupalcode.org/issue/violinist_projects-3278260/-/pipelines/...

Please review, thanks.

Run pipelines by updating fork and some phpstan errors appeared.
I will try to fix it.

liuyuanchao → made their first commit to this issue’s fork.

liuyuanchao → made their first commit to this issue’s fork.

Duplicate stylelint settings and I remove it.

liuyuanchao → made their first commit to this issue’s fork.

Hi, @jrb
> I think you must have the certData specified directly in your authsources.php file

Yes, you are right.
Thanks for your fixing.

But I'm sorry for slow response, because we are focus on samlauth migration.
And we had migrated manually to samlauth.

Thanks for you great project.

Fixed that the phpstan and phpunit run green.
Please review.

liuyuanchao → made their first commit to this issue’s fork.

This MR only adds comments and the pipelines have passed successfully, I approve the changes.

pipelines: https://git.drupalcode.org/issue/gin-3536107/-/pipelines/548146

The phpstan pipelines work without warnings,
change this to RTBC.

https://git.drupalcode.org/issue/field_formatter_class-3476292/-/pipelin...

liuyuanchao → made their first commit to this issue’s fork.

Create a MR to the latest 4.0.x branch.

liuyuanchao → made their first commit to this issue’s fork.

Loved src/Form/CallbackDeleteForm.php.
And fix some other warnings, and only cspell warnings left.
Please review.

liuyuanchao → made their first commit to this issue’s fork.

I tried to fix phpunit errors.
And pipelines worked fine, please review.

liuyuanchao → made their first commit to this issue’s fork.

Add test on previous major version.
Please review.

liuyuanchao → changed the visibility of the branch 3507096-setup-gitlba-ci to hidden.

The pipelines failed because the repository is out of date .
I update the repo from upstream and create a new MR.
The phpunit worked no error.

> We also need to test on the previous major given Drupal 10 is still supported, so the gitlab CI template needs to be updated.

Try to add the feature.

liuyuanchao → changed the visibility of the branch 3507096-set-up-gitlab to hidden.

liuyuanchao → made their first commit to this issue’s fork.

Defer only work in js file by script tags and not works in link tag.
So I just add it in js.

https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/scr...

liuyuanchao → made their first commit to this issue’s fork.

Hi @jannakha

I'm sorry that I forgot tp create MR.

And I created MR, the pipeline works without errors and warnings.
Please review.

liuyuanchao → made their first commit to this issue’s fork.

Fix in 3537990-fix-ci-issues branch, please review.

liuyuanchao → made their first commit to this issue’s fork.

I fix the issue in branch 3537989-fix-php-8.4.
Please review.

liuyuanchao → created an issue.

Hi @roderik

Thank you for the detailed explanation.

At the same time you create the user, you should insert a record in the authmap table: uid = Drupal userid, authname = [ that unique ID ], provider = 'samlauth'.

We prepare to create a custom drush command to do this.
And I am very agreed with you that this should be documented.
Thank you.

Hi @ jfurnas

Thank you for your advise.

I tried as what you said that access /user/login will redirect to the /saml/login route.

But I do not want to block the /user/login because I also use the drupal log in in some cases.

I update the issue description to be more detailed in what I want.

liuyuanchao → created an issue.

Maybe it is the influence of this commit.

https://git.drupalcode.org/project/mail_login/-/commit/abd79da75861f97bf...

The composer job failed just because the email is not right format.
I fix it and the job could run.

Should we fix the warnings in this issue or make other issues?

liuyuanchao → made their first commit to this issue’s fork.

Fix all the warnings. Please review.

liuyuanchao → made their first commit to this issue’s fork.

We are facing the same problem.

We use the r4032login module redirect to /saml/login, and redirect to /saml/login in fact.
But when using simplesamlphp module, it redirect to /{langcode}/saml_login when set as /saml_login.

It works fine when delete

default_url_options:
      path_processing: FALSE   

in samlauth.routing.yml as @roderik said.

Look forward to fix it.

Update the template to the latest

liuyuanchao → made their first commit to this issue’s fork.

liuyuanchao → created an issue.

Try to fix the error when use drupal10.5.
https://git.drupalcode.org/issue/ckeditor_tooltips-3531739/-/compare/1.0...

I am not familiar with the ckeditor5 plugins,
please review if it's OK.

liuyuanchao → made their first commit to this issue’s fork.

Fix the pipelines error. Please review.

liuyuanchao → made their first commit to this issue’s fork.

Thank you for testing.
And I fixed the phpcs errors.

Thank you for your quick response.
Fixed so that arrows do not shrink. How about this?

The issue is fixed in the latest version.
Print the right datetime in UTC.

liuyuanchao → made their first commit to this issue’s fork.

Hi @avpaderno

Fix the background repeat when in some cases.
Please review.

liuyuanchao → made their first commit to this issue’s fork.

Hi @lazzyvn

I add the version constraint in 3530298-too-few-arguments branch.
Please review.

https://git.drupalcode.org/issue/views_data_export_phpspreadsheet-353029...

liuyuanchao → changed the visibility of the branch 3530298-too-few-arguments-2 to hidden.

@ruby232

I add a default .gitlab-ci.yml file in branch 1.0.x.
Could you make a MR to check if it could work.

Error occurs when someone use the old version of views_data_export.
Should we add a restriction in composer.json?

Here is the page

https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... →

Adding a default template is very easy.

Add a fix in 1.0.x branch, please check.

liuyuanchao → created an issue.

Isn't it better to add a .gitlab-ci.yml file to enable the ci job.

The issue is fixed in the latest branch, maybe could be closed.

Maybe it's better to change like branch 3530298-too-few-arguments-2.
Please review.

liuyuanchao → made their first commit to this issue’s fork.

> D9 is no longer supported by this module, so all we need to do is make the parameters required:

You are right, I change the parameters not nullable, the phpunit passed.
And by the way, fix phpcs and phpstan warnings.
Please review.

liuyuanchao → made their first commit to this issue’s fork.

Hi @divya.sejekan, Thank you for your testing.

It seems like you didn't set the display format to plain.
The default display format is not problem.

Fix it in 3530242-fix-the-issues branch. Please check.

liuyuanchao → made their first commit to this issue’s fork.

liuyuanchao → changed the visibility of the branch 3528487-city-wont-display to active.

I change the twig file to display the city in the case that `locality.code` not exists.

liuyuanchao → changed the visibility of the branch 3528487-city-wont-display to hidden.

Maybe I can fix this.

Make the MR mergeable by updating fork. Please review.

liuyuanchao → made their first commit to this issue’s fork.

I test the MR, and it worked for me.

> AuthDecorator::lookupAccount() is doing a check for blocked accounts that it doesn't need to. I left it there but as far as I can tell it could be removed.

Maybe the check is for the error message.

Fix in 3193939-the-content-language branch.

liuyuanchao → made their first commit to this issue’s fork.

Fixed #4

liuyuanchao → made their first commit to this issue’s fork.

Isn't it better to set the version of symfony/intl same with symfony/expression-language?

I add the test code in 3115474-draft-available-text branch, but I can not make a MR.
Could anyone help to MR the code?

liuyuanchao → made their first commit to this issue’s fork.

Add a new MR for 4.x branch and add the functional test code.