- ๐ฆ๐บAustralia acbramley
Non aggregated CSS assets use a value from state which is derived from a timestamp and updated on cache clear. There is no need to append a version parameter as far as I can see? Honestly I'm not sure if JS files need it either? Marking PMNMI in case anyone disagrees
- Status changed to Active
almost 2 years ago 2:03pm 18 August 2023 - ๐ฌ๐งUnited Kingdom catch
I think this is valid, but it's a task rather than a bug.
Using the version instead of the hashed timestamp means that if the CSS version doesn't change, it can persist in CDN/varnish/browser caches even when the Drupal cache is cleared which should result in better hit rates.
If we have tests for the js version in the query string, we should be able to adapt those for CSS straightforwardly so adding the 'needs tests' tag.
- ๐ฎ๐ณIndia sanket.tale
sanket.tale โ made their first commit to this issueโs fork.
- Merge request !119083056065: Added the external CSS library version. โ (Open) created by sanket.tale
- ๐ฎ๐ณIndia sanket.tale
Created MR but it is failed due to the Nightwatch pipeline on `ckEditor5EditorHeightTest.js`, which is unrelated. pipeline passed for the relevant areas.
- ๐บ๐ธUnited States smustgrave
Issue summary appears incomplete.
Was previously tagged for tests which still appear to be needed.