Update CSS coding standards to include PostCSS and Drupal 10

Update the Issue Summary to include links to the current pages.

It may be helpful to state what is to happen to those pages. Is the format of https://docs.google.com/document/d/1rihTDDGy9-m0TGIadgz16TQ1aONc0OC3u2TkJ8bNaxg/edit related to the pages that will be created/edited? As in, would a 'Heading 2' correspond to a Drupal wiki page?

Not sure if it's in the scope, but can the standard also include a commitment to review every X years?

Drupal is a PHP framework and requires regular updates to PHP for security and stability.
CSS is constantly eveolving depending on current browser market and trends.

I think we to set a formal timeline for re-evaluating supported browsers, build processes and best practises to prevent CSS standards from becoming "woefully outdated" again.

I would suggest every 4 years, perhaps aligned with every even (or odd) major Drupal release.

It may be helpful to state what is to happen to those pages.

From my point of view, they should be replaced.

Is the format of https://docs.google.com/document/d/1rihTDDGy9-m0TGIadgz16TQ1aONc0OC3u2Tk... related to the pages that will be created/edited? As in, would a 'Heading 2' correspond to a Drupal wiki page?

I'm assuming so. I'm not 100% sure how we'll split the content across separate pages. Most of the work has been just updating and creating the content, as well as organizing it. I'm willing to work with the documentation team or whoever else as needed.

Not sure if it's in the scope, but can the standard also include a commitment to review every X years?

I'm not opposed to this, but not 100% certain its needed. CSS is changing very fast, but the standards don't dictate what rules we use, just how we format it. Additionally, PostCSS will automatically update compiled CSS as it's updated and our supported browsers change. At some point we'll need to discuss things like native CSS nesting (when we won't need PostCSS), when all our supported browsers support this... but that's probably 2-3 years off.

This reads as a reasonable change for the css docs. Only one thing I kinda miss in "Format Class Names using BEM". Can we have a state for the button also so we also show a state class structure? I understand there is a paragraph under St that regarding js state changes but shouldn't state also be shown if we are showing the other bem structures?

Perhaps a --primary state or --disabled?

This could be a Followup though to change. It's pretty minor.

I would suggest every 4 years, perhaps aligned with every even (or odd) major Drupal release.

I do support regular review of any policy but it is not something built into the existing practices. For myself, it is a long term plan.

What's the next step in this process? From what I gather, the https://www.drupal.org/project/coding_standards → process text has changed since the last time I looked at it, so we're in a weird place.

The issue should have a change record.

It looks like we need a change record. Should that be on this project, or Drupal core?

If the committee agrees to the change the issue is tagged “Needs documentation updates” and is announced on https://www.drupal.org/about/core → with a consideration period of 14 days. If there are concerns or conversation is ongoing, the issue consultation time may be extended. If the committee does not agree to the change the status may be set to "Won't fix" or to "Needs work" with an explanatory comment.

I think this already happened. It was announced at https://www.drupal.org/about/core/blog/coding-standards-proposals-for-fi... →

If the issue affects core it is discussed at the next core committer meeting.

Has this happened yet? Is it on the agenda for the next core committer meeting?

This was discussed #3375432: Coding Standards Meeting 2023-08-15 → and there was no objection to proceeding. So that step is done.

No, it hasn't been brought up at a core meeting. The next on is early next month. I have left a note in committer Slack for it to be added to the agenda.

I am updating this to the new process.

The first thing is to set this to RTBC and remove the 'final discussion tag'. This now puts us at Step 6. But since core is affected that moves to step 7, where this needs to go to a committer meeting. It was scheduled to be added to the latest core meeting but instead the issue for updating the process was discussed. I have now re-added that to the schedule.

As for the change record, that should be in this project. I am adding the tag for the change record.

Thanks for you patience!

Did this make it to the core meeting yet? If so when is that scheduled?

Also, what information needs to go in the change record? I don't see any at https://www.drupal.org/list-changes/coding_standards → Does the info need to be extensive, or does it just need to note that CSS coding standards have changed?

There are open threads in the Google doc

It would be good to resolve them

For the record I'm in support of the changes

@larowlan

Just resolved all the threads. Thanks for your feedback in there. Let me know what's next.

Gonna set rtbc, and suggest it will be added to core meeting.

We doel still need a change record it seems though. Quietone did point at the correct project in #16

Change record can be found here: [#3406417].

@mherchel there seems to be one line not removed from the document yet, a placeholder for example code, which seems to have examples right above it? Quite minimal imo, so not gonna remove rtbc.

done! The code sample was actually there. Just forgot to remove the placeholder!

Change record is at https://www.drupal.org/node/3406417 → , since the syntax above doesn't work with CR's, I guess.

This was discussed at core committers meeting on Wed December 5th (UTC)
There were no objections

There was however a desire to split the tooling (e.g. stylelint) from the standard.

Can we review the document and remove any specific mentions of a particular tooling.

This will make it easier to change tooling without needing to change the standard.

I think is ready for a draft blog post now.

Updated the IS for the full new process, so that we can see all steps 1-9.

Discussion post is published 11 Dec so removing the 'Needs announcement for final discussion' tag
https://www.drupal.org/about/core/blog/coding-standards-proposals-for-fi... →

This has been ready to go for a while - can someone do the honours of the actual documentation update so we can mark this fixed?

yeah, this is on me (sorry!). I've been a bit snowed under with both work and personal stuff.

I updated CSS formatting guidelines → by replacing content with what is in the google doc. That is available for review. Also, the text is using 'whitespace' which is not in American English dictionaries. Should it be changed to 'white space'?

https://github.com/prettier/stylelint-prettier

in core now. https://www.drupal.org/project/drupal/issues/3409048 🐛 Configure postcss formatting after stylelint and stylelint-config-standard update Fixed

This still needs documentation updates.