Account created on 25 November 2005, about 19 years ago
#

Merge Requests

More

Recent comments

🇷🇸Serbia pivica

Merged, 2.0.0-beta1 release created.

🇷🇸Serbia pivica

> Are we going to do a 2.0.0 release?

All the same to me.

If we want to add some more features from project page todo list to 2.x before first stable release then it make sense to do beta release now. If not then we can do 2.0.0 release now.

I do not have time in next months to work on this module, so from my side new features will be added only when I need them in some client project.

@jackwrfuller what would you prefer, 2.0.0 stable release or some 2.x-beta1 release for now?

🇷🇸Serbia pivica

@jackwrfuller did some additional minor depreciation warning fixes and I've prepared 2.x branch. Do you have time to quickly test latest MR version before we merge this?

🇷🇸Serbia pivica

Thx for pushing this implementation.

I didn't test anything because I didn't use https://www.drupal.org/project/cookies contrib module for now so not sure how all this works.

Did a quick review of the MR and I think the name of the submodule should be microsoft_clarity_cookies and not cookies_microsoft_clarity. Can we rename this string in all places?

Provided couple of additional minor feedbacks in MR.

After this is done all I can do it, to test this, is to enable modules locally and check is there some exception, I can not test actual integration. If somebody else can test this and verify that it works that would be great. If not we can merge this and then check future issues in follow-ups.

🇷🇸Serbia pivica

@jackwrfuller thx for doing an effort to port this to D11, great stuff.

I've provided some feedback in MR.

What do you think, should we do this in 2.x branch so we keep 1.x branch compatible with D9?

🇷🇸Serbia pivica

Added list of removed SASS vars.

🇷🇸Serbia pivica

Fixed. I've also used new CSS vars for this instead of old SASS vars.

🇷🇸Serbia pivica

Tags one more time.

🇷🇸Serbia pivica

Edited tags a bit.

🇷🇸Serbia pivica

Moved to Misc section.

🇷🇸Serbia pivica

Done in https://www.drupal.org/node/3487223 . I will add more nice examples over time, feel free to add examples you built in the past.

🇷🇸Serbia pivica

Removed width from images.

🇷🇸Serbia pivica

Added unicef.ch screenshot.

🇷🇸Serbia pivica

Added unicef.ch to the listing.

🇷🇸Serbia pivica

Tweaking layout.

🇷🇸Serbia pivica

This is ready for a full review/test. One thing that needs additional thinking is handling of text like links - this are the links that starts and ends with text and that can have simple html elements between text. Simple html elements are elements that do not have additional child elements inside. The idea is that wrapping should work for links like

<a>link with just some text</a>
<a>link with some <strong>bold</strong> formatting</a>

But complex links like

<a><div class="card"><div class="title">link card title</div><div class="body">link card</div></div></a>

will not be wrapped.

The questions are edge cases like

<a><span>link</span> with just some text</a>
<a>link with just some <span>text</span></a>

Is this a text like link or not, current assumption is that it is not because there are elements on start or end.

Maybe we should just say, link is text like if there is no elements inside of it or it has only elements that have text and no additional inner elements?

🇷🇸Serbia pivica

Decided to try to push this to 8.x-1.x version.

Introduced CSS vars are part taken from Bootstrap 5.3.x and the rest is added. I didn't want to push too much changes here, just to try to simplify overrides for current custom implementation, so this should not cause any problems when updating current child themes.

New CSS vars that are introduced are for heading and links colors

:root {
  --bs-heading-color: inherit;
  --bs-link-color: #026bc5;
  --bs-link-hover-color: #026bc5;
  --bsb-link-active-color: #026bc5;
}

And for nav link element:

.nav {
  --bs-nav-link-color: #026bc5;
  --bs-nav-link-hover-color: #026bc5;
  --bs-nav-link-disabled-color: #757575;
  --bsb-nav-link-hover-border-color: #026bc5;
  --bsb-nav-link-active-color: #026bc5;
  --bsb-nav-link-active-border-color: #026bc5;
}

New SASS variables:

$headings-color:                inherit !default;

// BS5 CSS vars prefix.
$prefix: bs- !default;

I'll test this against at least 3-4 custom projects before merging it.

🇷🇸Serbia pivica

pivica changed the visibility of the branch 3436198-switch-to-css to hidden.

🇷🇸Serbia pivica

Actually just figured we removed it from our custom child themes that are using bs_bootstrap theme. However I just noticed we still have pnpm-lock.yaml in bs_base and it is making problems if you used `npm install` and then `npm run build` which will try to use pnpm first if available and throw all kind of errors because of previous `npm install`.

Also npm feels much faster now and there are no benefits using pnpm in ddev enviroment, so let's remove pnpm support now and not latter. You can still use it in your custom themes if needed, just edit your child themes package.json and bring back pnpm there in build scripts.

🇷🇸Serbia pivica

Both core issues are still open, moving this to 2.x.

🇷🇸Serbia pivica

Not sure about this now, let's move it to 2.x version for now.

🇷🇸Serbia pivica

Done, Slack #bs_base channel is created, project page updated with support link and info, see you there ;)

🇷🇸Serbia pivica

Tweaking content.

🇷🇸Serbia pivica

Just as an idea maybe we can solve this with CSS vars approach, check what Bootstrap 5 is doing here when we update to it.

🇷🇸Serbia pivica

Just as an idea maybe we can solve this with CSS vars approach, check what Bootstrap 5 is doing here when we update to it.

🇷🇸Serbia pivica

Closing for now for a lack of feedback, feel free to reopen if this issue arise again.

🇷🇸Serbia pivica

We will need to move this to next major version.

🇷🇸Serbia pivica

Moving to next major version.

Production build 0.71.5 2024