Consider using clean_unique_id instead of manual ID calculation

working on it.

@anirudhsingh19 thx for trying to work on this.

Note that bs_bootstrap subtheme is deprecated in 2.0.x dev version and most code from it is removed or moved to parent bs_base theme. The template that needs fixing is now located in templates/navigation/menu--navbar.html.twig.

@pivica Thanks for letting me know. I have implemented the requested changes. Please review!!

I have also encountered that only level 1 of menu is getting rendered. Although, this isn't the scope of this issue, still attaching screenshots for your reference.

> I have also encountered that only level 1 of menu is getting rendered.

In order to render child levels, parent menu items needs to be expanded, so you need to enable 'Show as expanded' option for parent menus.

I've reviewed MR and I think we do not need a second `clean_unique_id` call for aria_id.

Instead of reverting to this: {% set aria_id = parent_id ~ loop.index0 %}
Added a '-' : {% set aria_id = parent_id ~ '-' ~ loop.index0%}

I've decided to remove suffix `-label` from id - it does not add any value to the id itself.

The rest is good now, merged.

Thx for your work anirudhsingh19.

Automatically closed - issue fixed for 2 weeks with no activity.