Issue reported by Druxt user:
it's failing when there's a URL like: "/fr/test?query=value"
Patch attached cleans additional query string from resolver.
Deciphered β created an issue.
Needs work as it will no longer apply since the automated d10 compatibility fix.
Merged
Deciphered β made their first commit to this issueβs fork.
That issue/patch, also references a session logout, which this module does not appear to handle. Are the plans or is there another project that you are involved with that handles the logout callback as well?
Deciphered β created an issue.
Deciphered β created an issue.
There is already a good amount of this information available from the `view--view` resource, so it's best not to duplicate work too much.
The biggest issue with the `view--view` resource is that it contains too much unfilterable data, and returns all displays. I think it would be better to concentrate on improvements in that area and then using the relationship from this resource to get that data as required.
+ Added feature branch / MR
+ Updated core version
+ Updated patch from MR
Deciphered β made their first commit to this issueβs fork.
JSON:API Views 8.x-1.1 released, unblocking this. Marking it RTBC
RTBC, thanks everyone
Thanks @e.bogatyrev, that looks great, I'll run a few manual tests, but this looks like it should be good to go for a merge and release.
I added the patch to an issue branch so that I could use it in composer without the need for the patch, allowing me to upgrade to Drupal 10.
The following (or similar) is required in your projects composer.json:
"repositories": {
"drupal": {
"type": "composer",
"url": "https://packages.drupal.org/8",
"exclude": [
"drupal/m4032404"
]
},
"drupal/m4032404": {
"type": "git",
"url": "https://git.drupalcode.org/issue/m4032404-3288400.git"
}
},
Then add the module using: composer require drupal/m4032404:dev-feature/3288400-automated-drupal-10
I hope this is helpful to others.
Deciphered β made their first commit to this issueβs fork.
I added a composer.json file so that I could use it in composer without the need for the patch, allowing me to upgrade to Drupal 10.
The following (or similar) is required in your projects composer.json:
"repositories": {
"drupal": {
"type": "composer",
"url": "https://packages.drupal.org/8",
"exclude": [
"drupal/field_tools"
]
},
"drupal/field_tools": {
"type": "git",
"url": "https://git.drupalcode.org/issue/field_tools-3297214.git"
}
},
Then add the module using: composer require drupal/field_tools:dev-3297214-automated-drupal-10
I hope this is helpful to others.
Deciphered β made their first commit to this issueβs fork.
I added the patch to an issue branch, as well as updating composer.json file so that I could use it in composer without the need for the patch, allowing me to upgrade to Drupal 10.
The following (or similar) is required in your projects composer.json:
"repositories": {
"drupal": {
"type": "composer",
"url": "https://packages.drupal.org/8",
"exclude": [
"drupal/entity_display_mode"
]
},
"drupal/entity_display_mode": {
"type": "git",
"url": "https://git.drupalcode.org/issue/entity_display_mode-3287230.git"
}
},
Then add the module using: composer require drupal/entity_display_mode:dev-feature/3287230-automated-drupal-10
I hope this is helpful to others.
Deciphered β made their first commit to this issueβs fork.
This can't be merged until the JSON:API Views module has it's D10 compatibility issue resolved, but in the meantime you can use the issue branch in your composer file to install with Drupal 10.
The following (or similar) is required in your projects composer.json:
"repositories": {
"drupal": {
"type": "composer",
"url": "https://packages.drupal.org/8",
"exclude": [
"drupal/druxt"
]
},
"drupal/druxt": {
"type": "git",
"url": "https://git.drupalcode.org/issue/druxt-3287092.git"
}
},
Then add the module using: composer require drupal/druxt:dev-feature/3287092-drupal-10
I hope this is helpful to others.
I added the patch to an issue branch, as well as adding a composer.json file so that I could use it in composer without the need for the patch, allowing me to upgrade to Drupal 10.
The following (or similar) is required in your projects composer.json:
"repositories": {
"drupal": {
"type": "composer",
"url": "https://packages.drupal.org/8",
"exclude": [
"drupal/anonymous_redirect"
]
},
"drupal/anonymous_redirect": {
"type": "git",
"url": "https://git.drupalcode.org/issue/anonymous_redirect-3286076.git"
}
},
Then add the module using: composer require drupal/anonymous_redirect:dev-feature/3286076-automated-drupal-10
I hope this is helpful to others.
Deciphered β made their first commit to this issueβs fork.
@stomusic
I ran into the following issue when using the 2.1.x-dev release:
PHP message: Uncaught PHP Exception Drupal\Core\Extension\InfoParserException: "The 'core_version_requirement' constraint (^9 || ^10) requires the 'core' key not be set in modules/contrib/paragraphs_ee/modules/paragraphs_ee_sets/paragraphs_ee_sets.info.yml" at /var/www/html/web/core/lib/Drupal/Core/Extension/InfoParserDynamic.php line 88" while reading response header from upstream, client: 172.21.0.6, server: , request: "GET /admin/reports HTTP/1.1", upstream:
I found both the main and sub-module still had the core:
key set. MR incoming.
It appears that the JSON:API Views exposed sorts provides a different result in Drupal 10, causing the tests to fail.
Further investigation / work required.
Updated MR and Patch, should now be passing tests.
Deciphered β made their first commit to this issueβs fork.
For me, as the developer and user of DruxtJS, having the bundle information opens up the ability for the frontend to pre-filter the requested JSON:API data as well as apply Bundle specific templating, which if is of great benefit to the frontend developer.
While I could certainly load the entity without knowing the bundle, via a non-core solution, it negates the ability to be able to pre-filter the query based on the bundle information.
I have put together a repository to demonstrate the issue, and to be my sandbox while I work on a solution. You can check it out @ https://github.com/Decipher/druxt-experiments/tree/feature/drupal_media
The repo is setup to be run on Gitpod @ https://gitpod.io#github.com/Decipher/druxt-experiments/tree/feature/dru...
Currently I have the frontend transpiling the unprocessed text field (as Drupal Media doesn't allow you to disable the filter if the CKEditor plugin is in use) which renders the DrupalMedia component: https://github.com/Decipher/druxt-experiments/blob/feature/drupal_media/...
Deciphered β created an issue. See original summary β .
I can confirm that the patch from #152 works with Tome and JSON:API whereas the current MR works with JSON:API but not Tome, with the errors reported in #150.
It would be ideal to get the MR synced back to the patch.