Add phpcs fixes

Needs work as it will no longer apply since the automated d10 compatibility fix.

Rerolled patch #2, please review it.

Thanks & Regards,
Mrinalini

Hello,
I looked over patch #6. Everything is operating as it should, although I discovered a new error, which I have resolved in the attached file.

FILE: /home/addweb/Drupal8-vagrant/web/web/patches/field_tokens/src/Tests/FieldTokensGeneralTest.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait.
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------

Hi @silvi

I applied the patch #7 and I confirmed that it fixes all the PHPCS issues.

➜  field_tokens git:(main) ✗ curl https://www.drupal.org/files/issues/2024-06-07/field_tokens-3266313-7.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  4804  100  4804    0     0  10286      0 --:--:-- --:--:-- --:--:-- 10489
patching file field_tokens.tokens.inc
patching file 'src/Tests/FieldTokensGeneralTest.php'
patching file 'src/Tests/FieldTokensTestBase.php'
➜  field_tokens git:(main) ✗ ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml field_tokens 

FILE: ...ts/d10/drupal_local/web/modules/contrib/field_tokens/field_tokens.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by
   |         | drupal.org packaging automatically
 1 | WARNING | Remove "datestamp" from the info file, it will be added by
   |         | drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by
   |         | drupal.org packaging automatically
--------------------------------------------------------------------------------

Time: 218ms; Memory: 12MB

➜  contrib git:(main) ✗ 

Can you make your patch into an MR? for the convenience of maintainers to merge it? I will transition this issue to needs work for that.

Thanks.

Please review the patch.

liam morland → made their first commit to this issue’s fork.