Created on 24 February 2022, almost 3 years ago
Updated 30 June 2024, 8 months ago

Problem/Motivation

Steps to reproduce

Run phpcs

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

šŸ“Œ Task
Status

Needs work

Version

2.0

Component

Code

Created by

šŸ‡®šŸ‡³India bendale

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • šŸ‡¦šŸ‡ŗAustralia Deciphered

    Needs work as it will no longer apply since the automated d10 compatibility fix.

  • Status changed to Needs review over 1 year ago
  • šŸ‡®šŸ‡³India mrinalini9 New Delhi

    Rerolled patch #2, please review it.

    Thanks & Regards,
    Mrinalini

  • šŸ‡®šŸ‡³India dev16.addweb

    Hello,
    I looked over patch #6. Everything is operating as it should, although I discovered a new error, which I have resolved in the attached file.

    FILE: /home/addweb/Drupal8-vagrant/web/web/patches/field_tokens/src/Tests/FieldTokensGeneralTest.php
    ----------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    ----------------------------------------------------------------------------------------------------------------------------------------------
     6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait.
    ----------------------------------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ----------------------------------------------------------------------------------------------------------------------------------------------
    
  • Status changed to Needs work 8 months ago
  • šŸ‡µšŸ‡­Philippines clarkssquared

    Hi @silvi

    I applied the patch #7 and I confirmed that it fixes all the PHPCS issues.

    āžœ  field_tokens git:(main) āœ— curl https://www.drupal.org/files/issues/2024-06-07/field_tokens-3266313-7.patch | patch -p1
      % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                     Dload  Upload   Total   Spent    Left  Speed
    100  4804  100  4804    0     0  10286      0 --:--:-- --:--:-- --:--:-- 10489
    patching file field_tokens.tokens.inc
    patching file 'src/Tests/FieldTokensGeneralTest.php'
    patching file 'src/Tests/FieldTokensTestBase.php'
    āžœ  field_tokens git:(main) āœ— ..
    āžœ  contrib git:(main) āœ— phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml field_tokens 
    
    FILE: ...ts/d10/drupal_local/web/modules/contrib/field_tokens/field_tokens.info.yml
    --------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
    --------------------------------------------------------------------------------
     1 | WARNING | Remove "project" from the info file, it will be added by
       |         | drupal.org packaging automatically
     1 | WARNING | Remove "datestamp" from the info file, it will be added by
       |         | drupal.org packaging automatically
     1 | WARNING | Remove "version" from the info file, it will be added by
       |         | drupal.org packaging automatically
    --------------------------------------------------------------------------------
    
    Time: 218ms; Memory: 12MB
    
    āžœ  contrib git:(main) āœ— 
    

    Can you make your patch into an MR? for the convenience of maintainers to merge it? I will transition this issue to needs work for that.

    Thanks.

Production build 0.71.5 2024