silvi.addweb → made their first commit to this issue’s fork.
@hetalsolanki,
Have you checked after applying MR !17?
modules/custom/activecampaign$ curl https://git.drupalcode.org/project/activecampaign/-/merge_requests/17.diff | git apply -v
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 11063 0 11063 0 0 20795 0 --:--:-- --:--:-- --:--:-- 20795
Checking patch .cspell-project-words.txt...
Checking patch modules/activecampaign_dashboard/activecampaign_dashboard.links.menu.yml...
Checking patch modules/activecampaign_dashboard/css/admin-menu.css...
Checking patch modules/activecampaign_dashboard/src/Form/ActiveCampaignDashboard.php...
Checking patch modules/activecampaign_webform/src/Plugin/WebformHandler/ActiveCampaignFormHandler.php...
Checking patch src/Plugin/Field/FieldFormatter/ActiveCampaignFormFormatter.php...
Checking patch src/Plugin/Field/FieldWidget/ActiveCampaignFormAutocompleteWidget.php...
Checking patch src/Plugin/Field/FieldWidget/ActiveCampaignFormSelectListWidget.php...
Applied patch .cspell-project-words.txt cleanly.
Applied patch modules/activecampaign_dashboard/activecampaign_dashboard.links.menu.yml cleanly.
Applied patch modules/activecampaign_dashboard/css/admin-menu.css cleanly.
Applied patch modules/activecampaign_dashboard/src/Form/ActiveCampaignDashboard.php cleanly.
Applied patch modules/activecampaign_webform/src/Plugin/WebformHandler/ActiveCampaignFormHandler.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/ActiveCampaignFormFormatter.php cleanly.
Applied patch src/Plugin/Field/FieldWidget/ActiveCampaignFormAutocompleteWidget.php cleanly.
Applied patch src/Plugin/Field/FieldWidget/ActiveCampaignFormSelectListWidget.php cleanly.
MR !17 applied cleanly and also please ignore css file on phpcs testing, Because I have fixed stylelint issues and it has been passed.
www-data@a57cb9704236:/app$ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml web/modules/custom/activecampaign/
www-data@a57cb9704236:/app$Hi,
I have updated the issue fork repo and fixed the remaining PHPCS issues. The Cspell and Stylelint jobs have also passed. The only remaining error is in the PHPStan job, which is due to the Webform dependent module.
All other jobs have passed. Please review it.
Before --> https://git.drupalcode.org/issue/activecampaign-3459297/-/pipelines/230763
After -->https://git.drupalcode.org/issue/activecampaign-3459297/-/pipelines/230843
Hi,
I have tested MR !1, It applied cleanly.
custom/opencollective$ curl https://git.drupalcode.org/project/opencollective/-/merge_requests/1.diff | git apply -v
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 22171 0 22171 0 0 44253 0 --:--:-- --:--:-- --:--:-- 44253
Checking patch README.md...
Checking patch modules/opencollective_api/README.md...
Checking patch modules/opencollective_api/css/api-events.css...
Checking patch modules/opencollective_api/src/ApiQueryPluginBase.php...
Checking patch modules/opencollective_api/src/Service/ApiClient.php...
Checking patch modules/opencollective_api/src/Service/ApiClientFactory.php...
Checking patch modules/opencollective_api_funding/src/Plugin/Funding/ApiFundingProviderBase.php...
Checking patch modules/opencollective_commerce/assets/css/status-report.css...
Checking patch modules/opencollective_commerce/opencollective_commerce.module...
Checking patch modules/opencollective_commerce/src/Plugin/Commerce/PaymentGateway/ContributionFlowPaymentGateway.php...
Checking patch modules/opencollective_commerce/src/PluginForm/ContributionFlowPaymentForm.php...
Checking patch modules/opencollective_commerce/src/Service/EventSyncManager.php...
Checking patch modules/opencollective_funding/src/Plugin/Funding/FundingProviderBase.php...
Checking patch modules/opencollective_openid_connect/src/Plugin/OpenIdConnectClient/OpenIDConnectOpenCollective.php...
Checking patch modules/opencollective_webhooks/opencollective_webhooks.links.menu.yml...
Checking patch modules/opencollective_webhooks/src/Controller/IncomingWebhookController.php...
Checking patch modules/opencollective_webhooks/src/Controller/PollingController.php...
Checking patch modules/opencollective_webhooks/src/Entity/WebhookEventInterface.php...
Checking patch modules/opencollective_webhooks/src/Form/TestForm.php...
Checking patch modules/opencollective_webhooks/src/Service/IncomingWebhooksFactory.php...
Checking patch modules/opencollective_webhooks/src/Service/PollingTokenManager.php...
Checking patch opencollective.routing.yml...
Applied patch README.md cleanly.
Applied patch modules/opencollective_api/README.md cleanly.
Applied patch modules/opencollective_api/css/api-events.css cleanly.
Applied patch modules/opencollective_api/src/ApiQueryPluginBase.php cleanly.
Applied patch modules/opencollective_api/src/Service/ApiClient.php cleanly.
Applied patch modules/opencollective_api/src/Service/ApiClientFactory.php cleanly.
Applied patch modules/opencollective_api_funding/src/Plugin/Funding/ApiFundingProviderBase.php cleanly.
Applied patch modules/opencollective_commerce/assets/css/status-report.css cleanly.
Applied patch modules/opencollective_commerce/opencollective_commerce.module cleanly.
Applied patch modules/opencollective_commerce/src/Plugin/Commerce/PaymentGateway/ContributionFlowPaymentGateway.php cleanly.
Applied patch modules/opencollective_commerce/src/PluginForm/ContributionFlowPaymentForm.php cleanly.
Applied patch modules/opencollective_commerce/src/Service/EventSyncManager.php cleanly.
Applied patch modules/opencollective_funding/src/Plugin/Funding/FundingProviderBase.php cleanly.
Applied patch modules/opencollective_openid_connect/src/Plugin/OpenIdConnectClient/OpenIDConnectOpenCollective.php cleanly.
Applied patch modules/opencollective_webhooks/opencollective_webhooks.links.menu.yml cleanly.
Applied patch modules/opencollective_webhooks/src/Controller/IncomingWebhookController.php cleanly.
Applied patch modules/opencollective_webhooks/src/Controller/PollingController.php cleanly.
Applied patch modules/opencollective_webhooks/src/Entity/WebhookEventInterface.php cleanly.
Applied patch modules/opencollective_webhooks/src/Form/TestForm.php cleanly.
Applied patch modules/opencollective_webhooks/src/Service/IncomingWebhooksFactory.php cleanly.
Applied patch modules/opencollective_webhooks/src/Service/PollingTokenManager.php cleanly.
Applied patch opencollective.routing.yml cleanly.
addweb@addweb-HP-ZBook-15-G2:~/Drupal8-vagrant/web/web/contribution/lando-d10/web/modules/custom/opencollective$Also there is no phpcs error or warning found. Please review it.
www-data@a57cb9704236:/app$ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css web/modules/custom/opencollective
www-data@a57cb9704236:/app$Hi,
As per the documentation
here →
, we can only add one category in the module's info file. Moving to "Needs Review".
Hi,
As per the documentation
here →
, we can only add one category in the module's info file. Moving to "Needs Review".
silvi.addweb → made their first commit to this issue’s fork.
Hello,
I have tested MR !5 and it's applied successfully. I've also checked that into Drupal 11 and it's working as expected as well.
Hi,
Modified README.md as per #9, Please review it.
Hi,
After applying the MR, I have not found any issues in the ConfigPagesValueAccess.php file.
Here is the command I used to run PHP CodeSniffer:
addweb@addweb-HP-ZBook-15-G2:~$ .config/composer/vendor/squizlabs/php_codesniffer/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css,js Drupal8-vagrant/web/web/contribution/lando-d10/web/modules/custom/config_pages/
addweb@addweb-HP-ZBook-15-G2:~$
To avoid issues with the info file, please download the module through:
git clone repo-url
Move to "Need review" so other users can review as well.
I have updated README.md as per #11, Please review it.
Hi,
Patch changes are updated in MR, Please review MR
Thanks for reviewing,
Metion error is coming from ClockifyDeleteForm which is extended by ContentEntityDeleteForm, So this is core error and it will automatically remove during core update. Here is related core
issue #3256539 →
which is fixed.
Hi,
I have fixed error mention on #6, Please review it.
Hi,
I have created MR, Please review it
silvi.addweb → changed the visibility of the branch 3125187-add-configure-link to hidden.
silvi.addweb → made their first commit to this issue’s fork.
Hi,
I have tested the MR, and there are no errors except for the README.txt file. This will be fixed in the related issue #3460485 📌 Replace README.txt to Readme.md file RTBC . Therefore, I am moving this to RTBC
silvi.addweb → created an issue.
Hi,
I have tested MR, working as expected.
Before --
After --
Hi, I have tested MR and configure button is now visible on module list page.
step perform during testing
- Clone module, applied MR
- Visited module list page Administration >> Extends
- Enable module and checked configure button
silvi.addweb → created an issue.
silvi.addweb → made their first commit to this issue’s fork.
silvi.addweb → created an issue.
Hello,
Although my test MR!3 applied successfully, I discovered a few new issues and warnings, which I have listed below.
FILE: /home/addweb/Drupal8-vagrant/web/web/drupal8_9/web/modules/contrib/clockify_report/README.md
--------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------
13 | WARNING | Line exceeds 80 characters; contains 134 characters
--------------------------------------------------------------------------------------------------
FILE: /home/addweb/Drupal8-vagrant/web/web/drupal8_9/web/modules/contrib/clockify_report/clockify_report.info.yml
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
-----------------------------------------------------------------------------------------------------------------
1 | WARNING | "core_version_requirement" property is missing in the info.yml file
7 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
8 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
9 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
-----------------------------------------------------------------------------------------------------------------
FILE: /home/addweb/Drupal8-vagrant/web/web/drupal8_9/web/modules/contrib/clockify_report/clockify_report.module
---------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES
---------------------------------------------------------------------------------------------------------------
98 | WARNING | Unused variable $split_week.
175 | WARNING | Unused variable $array.
289 | WARNING | Unused variable $weekday_name.
471 | WARNING | Unused variable $key.
483 | WARNING | Unused variable $key.
504 | WARNING | Unused variable $weekday_name.
687 | WARNING | Unused variable $key.
---------------------------------------------------------------------------------------------------------------
FILE: /home/addweb/Drupal8-vagrant/web/web/drupal8_9/web/modules/contrib/clockify_report/templates/invoice-download.html.twig
-----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------
3 | ERROR | [x] Expected 1 newline at end of file; 0 found
-----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------Hi,
I've tested the MR ! 4 and it applied successfully, no phpcs issues were found after applying MR. Also, I've attached screenshots for the same.
I think we need to update the fork. What do you think?
I fixed another issue which is reported by phpcs.
Hello @dtfabio,
I created an MR and fixed phpcs problems. Review, please.
Hi @Hetal.Solanki,
I reviewed MR!81 and confirmed it fixes all the errors and warnings reported by phpcs.
Thanks!
Hello,
I created an MR and fixed phpcs problems. Review, please.
Hello,
I created an MR and fixed phpcs problems. Review, please.
silvi.addweb → made their first commit to this issue’s fork.
Hello,
I created an MR and fixed phpcs problems. Review, please.
silvi.addweb → made their first commit to this issue’s fork.
Hello,
I created an MR and fixed phpcs problems. Review, please.
silvi.addweb → made their first commit to this issue’s fork.
silvi.addweb → made their first commit to this issue’s fork.
Hello,
I created an MR and fixed phpcs problems. Review, please.
silvi.addweb → made their first commit to this issue’s fork.
silvi.addweb → made their first commit to this issue’s fork.
Hello @i-trokhanenko,
I've Updated and made it compatible with Drupal 11. For more clarification, I've included a screenshot as well. Kindly check and merge this PR.
Thanks.
silvi.addweb → made their first commit to this issue’s fork.
Hello,
The errors and warnings listed above have been resolved. Examine the MR, please.
Thanks
Hello,
I reviewed #10 and confirmed it fixes all the errors and warnings reported by phpcs and also raised MR for the same. Please review.
Thank You.
silvi.addweb → made their first commit to this issue’s fork.
silvi.addweb → made their first commit to this issue’s fork.
Hi, I have fix warning mention on #7, Please review
silvi.addweb → made their first commit to this issue’s fork.
Hello,
I reviewed MR!3 and confirmed it fixes all the errors and warnings reported by phpcs.
I added screenshots for reference.
Thank You.
Hii,
I reviewed MR!10 and confirmed it fixes all the errors and warnings reported by phpcs.
I added screenshots for reference.
Thank You.
I applied MR!6, however several errors and warnings were still present.
FILE: /home/addweb/patches/sfc/README.md
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | An error occurred during processing; checking has been aborted. The error message was: Undefined index: scope_closer in
| | /home/addweb/.config/composer/vendor/slevomat/coding-standard/SlevomatCodingStandard/Helpers/UseStatementHelper.php on line 238
| | The error originated in the SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses sniff on line 70.
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /home/addweb/patches/sfc/src/LoaderInterfaceShim.php
---------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------
9 | ERROR | Interface name doesn't match filename; expected "interface LoaderInterfaceShim"
---------------------------------------------------------------------------------------------
Hi, I have updated screenshot. Please review
silvi.addweb → created an issue.
Fixed all the following issues. Please review.
silvi.addweb → made their first commit to this issue’s fork.
Hi,
I reviewed patch #10 and noticed that the help page looks off. I have attached a screenshot for reference.
Mr !1 looks good but help page should follow the standard format →
silvi.addweb → made their first commit to this issue’s fork.
silvi.addweb → made their first commit to this issue’s fork.
I have tested #5 and raised MR for the same. Please review and merge this MR.
silvi.addweb → made their first commit to this issue’s fork.
Hello,
I have tested the MR !10 and I found some errors and warnings after applying the patch.
FILE: /home/addweb/patches/consultation-3423317/src/Plugin/WebformHandler/ConsultationNotify.php
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------
54 | ERROR | The $_POST super global must not be accessed directly; inject the request_stack service and use $stack->getCurrentRequest()->request->get('form_id') instead
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /home/addweb/patches/consultation-3423317/src/Plugin/views/filter/ConsultationState.php
---------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------
21 | WARNING | Unused variable $operators.
---------------------------------------------------------------------------------------------
FILE: /home/addweb/patches/consultation-3423317/src/ConsultationNodeHelper.php
------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------
134 | WARNING | Unused variable $end.
------------------------------------------------------------------------------
FILE: /home/addweb/patches/consultation-3423317/src/ConsultationUninstallValidator.php
---------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------
28 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------------------
FILE: /home/addweb/patches/consultation-3423317/consultation.module
-------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
-------------------------------------------------------------------------------------
17 | WARNING | Global constants should not be used, move it to a class or interface
21 | WARNING | Global constants should not be used, move it to a class or interface
25 | WARNING | Global constants should not be used, move it to a class or interface
28 | WARNING | Global constants should not be used, move it to a class or interface
-------------------------------------------------------------------------------------
Time: 426ms; Memory: 12MB
silvi.addweb → made their first commit to this issue’s fork.
silvi.addweb → made their first commit to this issue’s fork.
Hi,
I have fixed error mention in #21, Please review.
Hi, I have tested phpcs issues, Need to fix one minor phpcs issue
modules/custom/cl_editorial/
PHPCBF RESULT SUMMARY
----------------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE FIXED REMAINING
----------------------------------------------------------------------------------------------------------------------------------------------------------------------
modules/custom/cl_editorial/modules/sdc_tags/src/Controller/ComponentTaggingController.php 1 0
----------------------------------------------------------------------------------------------------------------------------------------------------------------------
A TOTAL OF 1 ERROR WERE FIXED IN 1 FILE
----------------------------------------------------------------------------------------------------------------------------------------------------------------------
Time: 432ms; Memory: 14MBHi,
I have tested the MR. After applying the MR, the remove button is now green as expected. Please see the attached screenshot for reference
silvi.addweb → made their first commit to this issue’s fork.
Hi, I have fix error mention in #18 and updated patch.
I tested the MR !18 and it's working fine. I found no errors or warnings after applying the patch even though I have added a screenshot for the same. please check.
I tested the MR !1 and it's working fine. I found no errors or warnings after applying the patch even though I have added a screenshot for the same. please check.
Hi, I have reviewed MR and it has been applied cleanly,
www-data@e137cbd96b5e:/app/web/modules/custom$ git clone https://git.drupalcode.org/project/fullcalendar_dynamic.git
Cloning into 'fullcalendar_dynamic'...
cd fullca remote: Enumerating objects: 182, done.
remote: Counting objects: 100% (8/8), done.
remote: Compressing objects: 100% (7/7), done.
remote: Total 182 (delta 0), reused 0 (delta 0), pack-reused 174
Receiving objects: 100% (182/182), 55.17 KiB | 1.90 MiB/s, done.
Resolving deltas: 100% (82/82), done.
www-data@e137cbd96b5e:/app/web/modules/custom$ cd fullcalendar_dynamic/
www-data@e137cbd96b5e:/app/web/modules/custom/fullcalendar_dynamic$ git branch
* 1.x
www-data@e137cbd96b5e:/app/web/modules/custom/fullcalendar_dynamic$ curl https://git.drupalcode.org/project/fullcalendar_dynamic/-/merge_requests/1.diff |git apply -v
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 1190 0 1190 0 0 316 0 --:--:-- 0:00:03 --:--:-- 316
Checking patch README.md...
Applied patch README.md cleanly.
Hi,
I have tested MR, It has been applied cleanly and Now configure settings links is present on module list page.
modules/custom/tome$ curl https://git.drupalcode.org/project/tome/-/merge_requests/20.diff | git apply -v
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 1676 0 1676 0 0 3086 0 --:--:-- --:--:-- --:--:-- 3086
Checking patch modules/tome_static/modules/tome_static_cron/tome_static_cron.info.yml...
Checking patch modules/tome_static/tome_static.info.yml...
Checking patch modules/tome_sync/tome_sync.info.yml...
Applied patch modules/tome_static/modules/tome_static_cron/tome_static_cron.info.yml cleanly.
Applied patch modules/tome_static/tome_static.info.yml cleanly.
Applied patch modules/tome_sync/tome_sync.info.yml cleanly.Hi, I have fix issue mention in #8. Please review
Hi,
The README.md looks good according to the
README.md template. →
However, I found some PHPCS warnings in the README.md file.
modules/custom/huggingface/README.md
----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------
43 | WARNING | Line exceeds 80 characters; contains 81 characters
45 | WARNING | Line exceeds 80 characters; contains 91 characters
----------------------------------------------------------------------------------------------------------
Time: 100ms; Memory: 10MBHi,
I have tested the MR. The "Configure settings" link is now present on the module list page. Moving to RTBC