🇮🇳India @dev16.addweb

Hi,
I have found an alternative solution. This patch wasn't download library via Composer, but it might still be helpful. If it looks good, we can proceed to create a merge request for this patch.

Thanks @tanuja-bohra for reviewing,
Could you please create a new issue for the footer white space? Let's keep this issue focused only on specific tabs change.

Hi, I have updated style as per #7. Please review.

Hi @kenyoowen,
I have updated README.md as per #9. Please review it.

Thanks @kenyoowen, I have updated README.md as per #9. Please review it.

silvi.addweb → changed the visibility of the branch 8.x-1.x to hidden.

Hi @apaderno, Should we check and create a new merge request against the 8.x-1.x branch?

@pray_12 Thanks for review, I have created MR.

Added patch(#2) changes and also resolve below mentioned phpcs issues in MR !1, please review.

FILE: /commerce_shipping_mondial_relay-3379421/src/Plugin/Commerce/CheckoutPane/MondialRelay.php
------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------------
 117 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
 132 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------


FILE: /commerce_shipping_mondial_relay-3379421/src/Plugin/Commerce/ShippingMethod/MondialRelay.php
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------------------------------------------
 51 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 32
 52 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 32
 55 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
--------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------

silvi.addweb → made their first commit to this issue’s fork.

Hi, While applying patch #2, It give me error. It might be version issue, And also found phpcs issue in latest version 4.0.0-alpha2. So change version and let's work on latest version

modules/custom/simplenews_scheduler# git apply -v 3127030-2.patch
Checking patch simplenews_scheduler_views.inc...
Checking patch src/Controller/EditionsController.php...
Checking patch src/Tests/SimplenewsSchedulerDaylightSavingSwitchTest.php...
Checking patch src/Tests/SimplenewsSchedulerEditionDueTest.php...
Checking patch src/Tests/SimplenewsSchedulerEditionTimeTest.php...
Checking patch src/Tests/SimplenewsSchedulerNextRunTimeTest.php...
Checking patch src/Tests/SimplenewsSchedulerNodeCreationTest.php...
error: while searching for:

  public static $modules = ['block'];

  function setUp() {
    parent::setUp();

    $this->drupalPlaceBlock('local_tasks_block');
    $admin_user = $this->drupalCreateUser(array(
      'access content',
      'administer nodes',
      'create simplenews_issue content',

error: patch failed: src/Tests/SimplenewsSchedulerNodeCreationTest.php:19
error: src/Tests/SimplenewsSchedulerNodeCreationTest.php: patch does not apply

Added patch(#2) changes and also resolve below mentioned phpcs issues in MR !6, please review.

FILE: optional_end_date-3328949/src/Plugin/Field/FieldFormatter/OptionalEndDateDateRangePlainFormatter.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\datetime_range\Plugin\Field\FieldFormatter\DateRangePlainFormatter.
-------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: optional_end_date-3328949/src/Plugin/Field/FieldFormatter/OptionalEndDateDateRangeCustomFormatter.php
--------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\datetime_range\Plugin\Field\FieldFormatter\DateRangeCustomFormatter.
--------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: optional_end_date-3328949/src/Plugin/Field/FieldFormatter/OptionalEndDateDateRangeDefaultFormatter.php
---------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\datetime_range\Plugin\Field\FieldFormatter\DateRangeDefaultFormatter.
---------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: optional_end_date-3328949/src/Plugin/Field/FieldWidget/OptionalEndDateDateRangeDefaultWidget.php
-------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Field\FieldItemListInterface.
-------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------


FILE: optional_end_date-3328949/src/Plugin/Field/FieldWidget/OptionalEndDateDateRangeDatelistWidget.php
--------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Field\FieldItemListInterface.
--------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------

silvi.addweb → made their first commit to this issue’s fork.

Hi, I have fixed below phpcs issue in README.md and committed file. Please review it

modules/custom/livechat/README.md 

PHPCBF RESULT SUMMARY
-----------------------------------------------------------------------------------------------------------------------------
FILE                                                                                                         FIXED  REMAINING
-----------------------------------------------------------------------------------------------------------------------------
/home/addweb/Drupal8-vagrant/web/web/contribution/d9_contribution2/web/modules/custom/livechat/README.md     1      0
-----------------------------------------------------------------------------------------------------------------------------
A TOTAL OF 1 ERROR WERE FIXED IN 1 FILE
-----------------------------------------------------------------------------------------------------------------------------

Time: 51ms; Memory: 10MB

And also MR 3 applied cleanly.

modules/custom/livechat# curl https://git.drupalcode.org/project/livechat/-/merge_requests/3.diff | git apply -v
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  3653    0  3653    0     0   4077      0 --:--:-- --:--:-- --:--:--  4072
Checking patch README.md...
Applied patch README.md cleanly.

silvi.addweb → made their first commit to this issue’s fork.

silvi.addweb → made their first commit to this issue’s fork.

silvi.addweb → made their first commit to this issue’s fork.

Hi, README.md looks good as per standard template → And also MR applied cleanly. Moving to RTBC

modules/custom/simplenews_scheduler# curl https://git.drupalcode.org/project/simplenews_scheduler/-/merge_requests/13.diff | git apply -v
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  4210    0  4210    0     0   8470      0 --:--:-- --:--:-- --:--:--  8453
Checking patch README.md...
Checking patch README.txt...
Applied patch README.md cleanly.
Applied patch README.txt cleanly.

Hi, I have reviewed README.md file and it is as per standard format → , Moving to RTBC

Hi @yashaswi18, I have created MR Please review.

silvi.addweb → made their first commit to this issue’s fork.

silvi.addweb → made their first commit to this issue’s fork.

Hello, I've fixed below remaining issues, please review.

FILE: paragraphs_asymmetric_translation_widgets-3354154/tests/src/Functional/ParagraphsAsymmetricTranslationTest.php
---------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------------------
 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Tests\BrowserTestBase.
---------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: paragraphs_asymmetric_translation_widgets-3354154/src/Plugin/Field/FieldWidget/ParagraphsClassicAsymmetricWidget.php
---------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 4 WARNINGS AFFECTING 6 LINES
---------------------------------------------------------------------------------------------------------------------------------------------------------------
   7 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Utility\Html.
 524 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
 527 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
 601 | ERROR   | [ ] Doc comment is empty
 662 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
 679 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
---------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: paragraphs_asymmetric_translation_widgets-3354154/credits.txt
--------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------
 6 | WARNING | Line exceeds 80 characters; contains 441 characters
--------------------------------------------------------------------------------------------------------

silvi.addweb → made their first commit to this issue’s fork.

Hello,

I've examined patch #2. and I have raised MR for the same. It is working fine.

Hello,
Get an error saying "patch failed" relocating it to the needs work

silvi.addweb → made their first commit to this issue’s fork.

Fixed the mentioned issues which are reported by phpcs.

FILE: /home/addweb/patches/coffee/tests/src/Kernel/CoffeeCommandsTest.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
 65 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 71 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/addweb/patches/coffee/tests/src/Functional/CoffeeTest.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
 79 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 80 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/addweb/patches/coffee/tests/modules/coffee_test/src/Controller/CoffeeTestController.php
---------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
---------------------------------------------------------------------------------------------------
  8 | ERROR | [x] Missing class doc comment
 10 | ERROR | [x] Missing function doc comment
 12 | ERROR | [x] Expected 1 blank line after function; 0 found
 13 | ERROR | [x] The closing brace for the class must have an empty line before it
---------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------


FILE: /home/addweb/patches/coffee/tests/modules/coffee_test/coffee_test.routing.yml
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
 6 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
-----------------------------------------------------------------------------------------------------------------


FILE: /home/addweb/patches/coffee/src/Form/CoffeeConfigurationForm.php
--------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------
 79 | WARNING | Menu::loadMultiple calls should be avoided in classes, use dependency injection instead
--------------------------------------------------------------------------------------------------------


FILE: /home/addweb/patches/coffee/src/Controller/CoffeeController.php
-------------------------------------------------------------------------------
FOUND 4 ERRORS AND 1 WARNING AFFECTING 3 LINES
-------------------------------------------------------------------------------
  65 | ERROR   | [ ] Parameter $url_generator is not described in comment
  65 | ERROR   | [ ] Parameter $route_match is not described in comment
 136 | ERROR   | [x] Expected newline after closing brace
 136 | ERROR   | [x] Expected 1 space after CATCH keyword; 0 found
 213 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
-------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------


FILE: /home/addweb/patches/coffee/coffee.module
----------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Routing\RouteMatchInterface.
 41 | ERROR | [x] Use null coalesce operator instead of ternary operator.
 44 | ERROR | [x] Expected 1 space after "="; 2 found
----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------

Time: 273ms; Memory: 10MB

I've tested the MR !4 and it applied successfully , no phpcs issues found after applying MR.

 % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  5267    0  5267    0     0   9289      0 --:--:-- --:--:-- --:--:--  9272
Checking patch login_time_restriction.install...
Checking patch login_time_restriction.module...
Checking patch src/Controller/AccessTimeController.php...
Checking patch src/EventSubscriber/ValidRequestEventSubscriber.php...
Checking patch src/Facade/TimeRangeFacade.php...
Checking patch src/Form/LoginTimeRestrictionAdminSettings.php...
Applied patch login_time_restriction.install cleanly.
Applied patch login_time_restriction.module cleanly.
Applied patch src/Controller/AccessTimeController.php cleanly.
Applied patch src/EventSubscriber/ValidRequestEventSubscriber.php cleanly.
Applied patch src/Facade/TimeRangeFacade.php cleanly.
Applied patch src/Form/LoginTimeRestrictionAdminSettings.php cleanly.

Re-roll the #11 patch according to the latest code changes. Please review this.

Hi @ravi-kant,
The README.md looks good. I have tested it for PHPCS issues and fixed the ones I found. Please review.

custom/taxonomy_breadcrumb/README.md
-------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------
 76 | ERROR | [x] Expected 1 newline at end of file; 0 found
-------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------

Time: 49ms; Memory: 10MB

silvi.addweb → made their first commit to this issue’s fork.

silvi.addweb → made their first commit to this issue’s fork.

silvi.addweb → made their first commit to this issue’s fork.

Hi, I have fix below remaining phpcs issue, Please review.

modules/custom/datarange_picker/src/Plugin/Field/FieldFormatter/DateRangePickerFormatter.php
----------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Field\FieldItemListInterface.
----------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------------------------------

Time: 97ms; Memory: 12MB

silvi.addweb → made their first commit to this issue’s fork.

silvi.addweb → made their first commit to this issue’s fork.

Need to add new Maintainers in README.md file.

- Mansi Agarwal - [Mansi Agarwal](https://www.drupal.org/u/mansi-agarwal)
- Samata soni - [Samata soni](https://www.drupal.org/u/samata-soni)

silvi.addweb → created an issue.

silvi.addweb → made their first commit to this issue’s fork.

silvi.addweb → made their first commit to this issue’s fork.

silvi.addweb → made their first commit to this issue’s fork.

Applied MR !3 and discovered no errors and warnings.

silvi.addweb → made their first commit to this issue’s fork.

silvi.addweb → made their first commit to this issue’s fork.

After applying the MR !1, I tested this issue and found no errors or warnings.

Hi @kenyoowen,
I have fixed mention issue on #5. Please review it.

silvi.addweb → made their first commit to this issue’s fork.

silvi.addweb → changed the visibility of the branch 3428011-module-have-some to hidden.

Hi @tanuja-bohra,
I have fixed the mention issue in #9. Please review it.

silvi.addweb → made their first commit to this issue’s fork.

silvi.addweb → made their first commit to this issue’s fork.

Thanks @ravi-kant, I have tested MR, It Applied cleanly. Also README.md looks good as per standard format. Moving to RTBC

modules/custom/addtocopy# curl https://git.drupalcode.org/project/addtocopy/-/merge_requests/4.diff | git apply -v
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  4140    0  4140    0     0   8884      0 --:--:-- --:--:-- --:--:--  8884
Checking patch README.md...
Checking patch README.txt...
Checking patch addtocopy.info.yml...
Checking patch addtocopy.permissions.yml...
Checking patch addtocopy.routing.yml...
Applied patch README.md cleanly.
Applied patch README.txt cleanly.
Applied patch addtocopy.info.yml cleanly.
Applied patch addtocopy.permissions.yml cleanly.
Applied patch addtocopy.routing.yml cleanly.

silvi.addweb → made their first commit to this issue’s fork.

Hi, I have reviewed MR 2, Looks good and it is as per README.md → template. Moving to RTBC.

Hi, I have added dependant module and created MR. Please review.

silvi.addweb → created an issue.

Hi, I have updated README.md as per standard templates. Please review.

silvi.addweb → made their first commit to this issue’s fork.

Hi, I have added configure link. Please review.

silvi.addweb → created an issue.

Looks good @kenyoowen,

If we need to restrict access by role, we can use the following method. However, using permissions (as shown in #4) is more convenient because it allows us to give access to any user based on their permissions.

metatag_ai.admin_settings:
  path: '/admin/config/content/metatag-ai'
  defaults:
    _form: '\Drupal\metatag_ai\Form\MetatagAIConfigForm'
    _title: 'Metatag AI Settings'
  requirements:
    _role: 'administrator'

metatag_ai.content_settings:
  path: '/admin/config/content/metatag-ai/content-type'
  defaults:
    _form: '\Drupal\metatag_ai\Form\MetatagAISettingsForm'
    _title: 'Metatag Content Type Settings'
  requirements:
    _role: 'administrator+content_editor'

Need to Modified as per standards of help page → .

silvi.addweb → made their first commit to this issue’s fork.

Thanks @kalpanajaiswal, I have reviewed MR, README.md looks good and file is as per README.md → template. Moving to RTBC.

Hello,

I've tested this problem, and I don't see any issues or warnings without the patch.

Re-roll the #4 patch according to the latest code changes.

Hi, I have fix some phpcs issue, Please review.

silvi.addweb → made their first commit to this issue’s fork.

Hi,
There is an issue #3334370 📌 Fix the issues reported by phpcs RTBC which covers t() call warnings. The version is different, but it will be fixed during a subsequent release.

Hi, I have fix below remaining phpcs issues. Please review

custom/masqurade_log/seeds_layouts/

FILE: /home/addweb/Drupal8-vagrant/web/web/contribution/drupal-10-3/web/modules/custom/seeds_layouts/src/Plugin/LayoutField/BackgroundImageField.php
------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------------------------
 42 | ERROR | Function return type is not void, but function has no return statement
 42 | ERROR | Description for the @return value is missing
------------------------------------------------------------------------------------------------------------------------------------------------------------------

Time: 447ms; Memory: 12MB

silvi.addweb → made their first commit to this issue’s fork.

Hi, I have tested phpcs issues and fix below issues and created patch, Please review.

/modules/custom/views_rss/

FILE: /home/addweb/Drupal8-vagrant/web/web/contribution/drupal-10-3/web/modules/custom/views_rss/src/Plugin/views/style/RssFields.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------
 52 | ERROR | Class property $channel_elements should use lowerCamel naming without underscores
-------------------------------------------------------------------------------------------------------------------------------------

FILE: /home/addweb/Drupal8-vagrant/web/web/contribution/drupal-10-3/web/modules/custom/views_rss/tests/src/Functional/DisplayFeedTest.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
 199 | WARNING | [ ] Line exceeds 80 characters; contains 89 characters
 199 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
-----------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------

Time: 646ms; Memory: 14MB

Hello,

Without adding the patch, I haven't noticed any issues or warnings. Perhaps it has already been fixed.

Attached image

Hi, I have tested Breadcrumb, Need to fix breadcrumb on mobile.

After testing, I was unable to locate any issues or warnings.

Hi, I have tested phpcs issue, all issue are resolved. And also Node picture upload form working fine.

addweb@addweb-HP-ZBook-15-G2:~$ .config/composer/vendor/squizlabs/php_codesniffer/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css Drupal8-vagrant/web/web/contribution/drupal-10-3/web/modules/custom/upload_node_picture/
addweb@addweb-HP-ZBook-15-G2:~$

Hi, attaching a patch. Please review.

Hello,
After testing the MR!5, I discovered no errors or warnings. I've included SS for the same as well.

silvi.addweb → made their first commit to this issue’s fork.

Thanks chetan-11, I have created MR 12 from 3.0.x branch, Please review MR 12 will apply cleanly.

silvi.addweb → made their first commit to this issue’s fork.

Hello,
I have tested MR !4 and found no errors or warnings. I have attached SS for the same.

Hello,

Re-rolled the patch according to the latest code changes.

Hi, I have added style for mini pager and created MR. Please review.

Hi, I have compile scss and added media css file. Please review

silvi.addweb → made their first commit to this issue’s fork.

silvi.addweb → made their first commit to this issue’s fork.

Hello,
I have tested MR !2 and found no errors or warnings.

Hello,
I have tested MR !3 and it's working as accepted. found no errors or warnings.

Hello,
After checking, I discovered one more error.

Hi @pray_12, I have removed horizontal bar, please review

Hello,

After testing the #19 patch, I discovered that there were still a few issues, which I have rectified in the attached patch. Please check.

I have Updated font awesome library, Please review.