Fix the issues reported by phpcs

Finding coding standard issues as detailed in the summary. I will work on fixing them.

I have solved all the issues except for dependency injections and the errors related to documentation... which should be ideally done by the mtaintainers themselves. I have issued an MR. Please review.

+  /**
+   *
+   */
   interface ExistsLoaderInterface {}

Documentation comments must not be empty.

Hi

I applied MR !1 and there are still many PHPCS errors/issues being flagged.

➜  sfc git:(8.x-1.11) curl https://git.drupalcode.org/project/sfc/-/merge_requests/6.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     100 24735    0 24735    0     0  36905      0 --:--:-- --:--:-- --:--:-- 37251
patching file 'modules/sfc_dev/src/Ajax/RefreshComponentAssetsCommand.php'
patching file 'modules/sfc_dev/src/Controller/ComponentDevController.php'
patching file 'modules/sfc_example/css/dist/tailwind.css'
patching file 'modules/sfc_example/sfc_example.module'
patching file 'src/ComponentBase.php'
patching file 'src/ComponentConsumerTrait.php'
patching file 'src/LoaderInterfaceShim.php'
patching file 'src/Plugin/Block/ComponentBlock.php'
patching file 'src/Plugin/Derivative/SimpleComponentDeriver.php'
patching file 'src/Plugin/Field/FieldFormatter/ComponentFieldFormatter.php'
patching file 'src/Plugin/Layout/ComponentLayout.php'
patching file 'src/RenderCallbacks.php'
patching file 'tests/modules/sfc_test/src/Controller/TestController.php'
patching file 'tests/modules/sfc_test/src/Plugin/Block/InvalidBlock.php'
patching file 'tests/modules/sfc_test/src/Plugin/SingleFileComponent/BoldFormatter.php'
patching file 'tests/modules/sfc_test/src/Plugin/SingleFileComponent/TwoColumnLayout.php'
patching file 'tests/src/Functional/ActionControllerTest.php'
patching file 'tests/src/Unit/ComponentBaseTest.php'
patching file 'tests/src/Unit/ComponentCommandsTest.php'
patching file 'tests/src/Unit/TwigComponentLoaderTest.php'
patching file 'tests/themes/sfc_sub_theme/templates/sfc--simple-test.html.twig'
➜  sfc git:(8.x-1.11) ✗ ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml sfc

FILE: ...ing-subing/Projects/d9/d9-local/web/modules/contrib/sfc/sfc.routing.yml
-----------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------
 6 | WARNING | Open page callback found, please add a comment before the
   |         | line why there is no access restriction
-----------------------------------------------------------------------------


FILE: ...cal/web/modules/contrib/sfc/tests/modules/sfc_test/sfc_test.routing.yml
-----------------------------------------------------------------------------
FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES
-----------------------------------------------------------------------------
  6 | WARNING | Open page callback found, please add a comment before the
    |         | line why there is no access restriction
 13 | WARNING | Open page callback found, please add a comment before the
    |         | line why there is no access restriction
 20 | WARNING | Open page callback found, please add a comment before the
    |         | line why there is no access restriction
 28 | WARNING | Open page callback found, please add a comment before the
    |         | line why there is no access restriction
 36 | WARNING | Open page callback found, please add a comment before the
    |         | line why there is no access restriction
 44 | WARNING | Open page callback found, please add a comment before the
    |         | line why there is no access restriction
 53 | WARNING | Open page callback found, please add a comment before the
    |         | line why there is no access restriction
-----------------------------------------------------------------------------


FILE: ...es/contrib/sfc/tests/modules/sfc_test/src/Controller/TestController.php
-----------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------
 57 | WARNING | \Drupal calls should be avoided in classes, use dependency
    |         | injection instead
-----------------------------------------------------------------------------


FILE: ...-local/web/modules/contrib/sfc/tests/src/Unit/ComponentCommandsTest.php
-----------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------
 11 | ERROR | [x] Use statements should be sorted alphabetically. The first
    |       |     wrong one is Drupal\sfc\Commands\ComponentCommands.
-----------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------


FILE: ...arksubing-subing/Projects/d9/d9-local/web/modules/contrib/sfc/README.md
-----------------------------------------------------------------------------
FOUND 35 ERRORS AND 1 WARNING AFFECTING 36 LINES
-----------------------------------------------------------------------------
   1 | ERROR   | [ ] An error occurred during processing; checking has been
     |         |     aborted. The error message was: Undefined array key
     |         |     "scope_closer" in
     |         |     /Users/clarksubing-subing/.composer/vendor/slevomat/coding-standard/SlevomatCodingStandard/Helpers/UseStatementHelper.php
     |         |     on line 194
  52 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters
 185 | ERROR   | [x] Line indented incorrectly; expected 0 spaces, found 2
 187 | ERROR   | [x] Line indented incorrectly; expected 0 spaces, found 2
 199 | ERROR   | [x] Line indented incorrectly; expected at least 8 spaces,
     |         |     found 0
 200 | ERROR   | [x] Line indented incorrectly; expected at least 8 spaces,
     |         |     found 0
 201 | ERROR   | [x] Line indented incorrectly; expected at least 10 spaces,
     |         |     found 2
 202 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 0
 205 | ERROR   | [x] Line indented incorrectly; expected at least 4 spaces,
     |         |     found 2
 227 | ERROR   | [x] Line indented incorrectly; expected 0 spaces, found 2
 228 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 229 | ERROR   | [x] Line indented incorrectly; expected 0 spaces, found 2
 230 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 231 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 233 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 235 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 236 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 238 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 239 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 240 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 242 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 243 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 244 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 245 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 246 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 248 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 249 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 251 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 252 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 258 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 260 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 262 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 264 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 265 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 2
 268 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 352 | ERROR   | [x] Line indented incorrectly; expected 0 spaces, found 2
-----------------------------------------------------------------------------
PHPCBF CAN FIX THE 34 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------


FILE: ...ing-subing/Projects/d9/d9-local/web/modules/contrib/sfc/CONTRIBUTING.md
-----------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------
 51 | WARNING | Line exceeds 80 characters; contains 87 characters
-----------------------------------------------------------------------------


FILE: ...b/modules/contrib/sfc/modules/sfc_dev/src/Form/ComponentPreviewForm.php
-----------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------
 15 | ERROR | [x] Use statements should be sorted alphabetically. The first
    |       |     wrong one is Drupal\sfc\ComponentConsumerTrait.
-----------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------


FILE: ...s/contrib/sfc/modules/sfc_dev/src/Controller/ComponentDevController.php
-----------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
-----------------------------------------------------------------------------
 14 | ERROR   | [x] Use statements should be sorted alphabetically. The
    |         |     first wrong one is Drupal\Component\Serialization\Json.
 57 | WARNING | [ ] \Drupal calls should be avoided in classes, use
    |         |     dependency injection instead
-----------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------


FILE: ...cal/web/modules/contrib/sfc/modules/sfc_example/sfc_example.routing.yml
-----------------------------------------------------------------------------
FOUND 0 ERRORS AND 8 WARNINGS AFFECTING 8 LINES
-----------------------------------------------------------------------------
  7 | WARNING | Open page callback found, please add a comment before the
    |         | line why there is no access restriction
 14 | WARNING | Open page callback found, please add a comment before the
    |         | line why there is no access restriction
 21 | WARNING | Open page callback found, please add a comment before the
    |         | line why there is no access restriction
 27 | WARNING | Open page callback found, please add a comment before the
    |         | line why there is no access restriction
 35 | WARNING | Open page callback found, please add a comment before the
    |         | line why there is no access restriction
 42 | WARNING | Open page callback found, please add a comment before the
    |         | line why there is no access restriction
 49 | WARNING | Open page callback found, please add a comment before the
    |         | line why there is no access restriction
 56 | WARNING | Open page callback found, please add a comment before the
    |         | line why there is no access restriction
-----------------------------------------------------------------------------


FILE: ...bing/Projects/d9/d9-local/web/modules/contrib/sfc/src/TwigExtension.php
-----------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------
 9 | ERROR | [x] Use statements should be sorted alphabetically. The first
   |       |     wrong one is
   |       |     Drupal\Component\Plugin\PluginManagerInterface.
-----------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------


FILE: ...rojects/d9/d9-local/web/modules/contrib/sfc/src/LoaderInterfaceShim.php
-----------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------
 9 | ERROR | Interface name doesn't match filename; expected "interface
   |       | LoaderInterfaceShim"
-----------------------------------------------------------------------------


FILE: .../d9-local/web/modules/contrib/sfc/src/Plugin/Layout/ComponentLayout.php
-----------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------
 12 | ERROR | [x] Use statements should be sorted alphabetically. The first
    |       |     wrong one is Drupal\sfc\ComponentConsumerTrait.
-----------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------


FILE: ...ects/d9/d9-local/web/modules/contrib/sfc/src/ComponentConsumerTrait.php
-----------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first
   |       |     wrong one is Drupal\Core\Form\SubformState.
-----------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------


FILE: ...rojects/d9/d9-local/web/modules/contrib/sfc/src/TwigComponentLoader.php
-----------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------
 8 | ERROR | [x] Use statements should be sorted alphabetically. The first
   |       |     wrong one is Twig\Error\LoaderError.
-----------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------

Time: 1.71 secs; Memory: 16MB

➜  contrib git:(master) ✗

pray_12 → made their first commit to this issue’s fork.

Hi, patch #12 applied cleanly but still there are phpcs issues.

$ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig sfc/

FILE: C:\Users\Nisha\sfc\CONTRIBUTING.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 51 | WARNING | Line exceeds 80 characters; contains 87 characters
----------------------------------------------------------------------


FILE: C:\Users\Nisha\sfc\modules\sfc_dev\src\Ajax\RefreshComponentAssetsCommand.php
-----------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------
  1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
 54 | ERROR | [x] list(...) is forbidden, use [...] instead.
-----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------


FILE: C:\Users\Nisha\sfc\modules\sfc_dev\src\Controller\ComponentDevController.php
----------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES
----------------------------------------------------------------------------------------------------
  1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
 14 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is
    |         |     Drupal\Component\Serialization\Json.
 57 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
 85 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------


FILE: C:\Users\Nisha\sfc\modules\sfc_dev\src\Form\ComponentPreviewForm.php
----------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------
  1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
 15 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is
    |       |     Drupal\sfc\ComponentConsumerTrait.
----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------


FILE: C:\Users\Nisha\sfc\modules\sfc_dev\src\Plugin\SingleFileComponent\ComponentLibrary.php
--------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
--------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------


FILE: C:\Users\Nisha\sfc\modules\sfc_dev\src\Plugin\SingleFileComponent\ComponentPicker.php
-------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
-------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------


FILE: C:\Users\Nisha\sfc\modules\sfc_dev\src\Plugin\SingleFileComponent\ComponentPreview.php
--------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
--------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------


FILE: C:\Users\Nisha\sfc\modules\sfc_dev\src\Plugin\SingleFileComponent\ComponentTemplate.php
---------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
---------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------


FILE: C:\Users\Nisha\sfc\modules\sfc_dev\tests\src\FunctionalJavascript\ComponentLibraryTest.php
------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------


FILE: C:\Users\Nisha\sfc\modules\sfc_dev\tests\src\Kernel\ComponentDevControllerTest.php
----------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------


FILE: C:\Users\Nisha\sfc\modules\sfc_dev\tests\src\Kernel\ComponentPreviewFormTest.php
--------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
--------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------


FILE: C:\Users\Nisha\sfc\modules\sfc_dev\tests\src\Kernel\ComponentPreviewTest.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------


FILE: C:\Users\Nisha\sfc\modules\sfc_dev\tests\src\Kernel\ComponentTemplateTest.php
-----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
-----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY