As mentioned in comment #5 menu alignment is perfect without applying the patch.
I have fixed the spacing issue of search icon. Please review the MR.
nisha_j → made their first commit to this issue’s fork.
Menu dropdown is not visible properly created MR.
nisha_j → made their first commit to this issue’s fork.
nisha_j → made their first commit to this issue’s fork.
nisha_j → made their first commit to this issue’s fork.
Hi @Hamid
added a patch for mini pager styles please review it.
Updated the Patch.
Hi, I reviewed MR !18. The README.md file follows the standard format except for the "two lines prior to ##/### headings" as mentioned in the README.md document.
Hi, @Arijit Acharya. I reviewed the README.md file. In the file, there are no two lines prior to the ## headings. Please refer to the standard template and update the file according to the recommended template standards.
So changing the status to Needs Work.
Thankyou.
Hi I have reviewed the updated README.md it follows the standard template.
So changing the status to RTBC.
Thankyou.
Hi, the suggested changes in the comment #5 has been addressed by @silvi.addweb
Now the updated README.md follows standard template.
Can be moved to RTBC.
Thankyou.
Hi, MR!6 fixes the issue. Attached screenshot for reference.
So changing the status to RTBC.
Thankyou.
Hi, MR 12 applied cleanly and it fixes the error.
So changing the status to RTBC.
Thankyou.
Hi Applied MR!10, the login form looks good and the search block overlapping the menus issue is also resolved.
Even I am unable to find the issue mentioned in comment #10.
Attached screenshot for reference.
RTBC +1
Thankyou.
Hi, @Rajan Kumar@2026 I have reviewed MR19. The styles of the mini pager have been updated. There are some alignment issues that need to be fixed between the "Page 1" and "Next" buttons. Please see the attached screenshot for reference.
Hi, I have reviewed MR 2, Looks good and it is as per the
https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or-distribution-project/documenting-your-project/readmemd-template →
So moving this to RTBC.
Thanks.
Hi, I applied MR!5 Styling on the cancel button looks good.
RTBC ++
Thankyou
Hi, Reviewed MR!14 the twitter logo has been updated.
Attached screenshot for reference.
RTBC ++
Thankyou.
Hi, MR!10 fixes the social icon alignment.
So changing the status to RTBC.
Thankyou.
Hi MR! The issue mentioned here has been fixed. Attached screenshot for reference.
So changing the status to RTBC.
Thankyou.
Hi MR! The issue mentioned here has been fixed. Attached screenshot for reference.
Thankyou.
Hi, The MR!6 looks good on other resolution but it need to be fixed on the screen around 760px to 601px.
Attached screenshot for reference.
So changing the status to Needs work.
Thanks.
Hi,
I have reviewed the README file. The structure generally follows Drupal's recommended format, with clear sections and meaningful links.
RTBC ++
Thankyou.
Hi, @Tirupati_Singh I have verified the issue by adding more menu items under the main menu, and it is now working fine. Regarding the multi-level menu in mobile view, I understand the points mentioned.
So changing the status to RTBC
Thanks
Hi, I have reviewed MR!35
The overlapping of the hamburger menu and user account menu has been fixed for mobile responsiveness.
The styling of the multi-level menu has also been improved. It is now appearing in a single line, but it would be better if it displayed step-by-step for a better user experience.
Additionally, there is an issue with the multi-level menu in the mobile view, it briefly opens and then disappears this needs to be fixed.
So changing the status to Needs Work.
Thankyou.
Hi, I have reviewed the README file. Overall, it follows Drupal's recommended format and provides clear instructions for installation, configuration, and usage. The usage section's one-liner for analyzing output is particularly useful.
RTBC++
Thanks.
Hi, menu looks good. So changing the status to RTBC++
Thankyou.
Hi, as @pray_12 mentioned, the site slogan is now visible, but the alignment between the logo and slogan needs to be fixed.
@Nupur Badola, I think there might be an issue with saving the configuration or another step might be missed. Attached are the screenshots for reference.
Hi, @ravi kant I have reviewed the changes and verified that the styling issue for tags on the homepage teasers has been fixed for mobile. The tags are now properly styled and no longer overflow. The issue is resolved as expected.
RTBC +
Thankyou.
Hi, MR!1 applied cleanly with any error or file rejection, Shared code snippet for reference.
RTBC ++
Thankyou.
Test@LAPTOP-6VFKUABC MINGW64 ~/freshchat (8.x-2.x)
$ curl -o freshchat.patch https://git.drupalcode.org/project/freshchat/-/merge_requests/1.diff
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 2168 0 2168 0 0 2714 0 --:--:-- --:--:-- --:--:-- 2716
Test@LAPTOP-6VFKUABC MINGW64 ~/freshchat (8.x-2.x)
$ git apply -v freshchat.patch
Checking patch README.md...
Checking patch README.txt...
Checking patch freshchat.info.yml...
Applied patch README.md cleanly.
Applied patch README.txt cleanly.
Applied patch freshchat.info.yml cleanly.
Test@LAPTOP-6VFKUABC MINGW64 ~/freshchat (8.x-2.x)
Hi, the countup animation is now working as expected. The animation waits until the element comes into view before starting, which resolves the issue.
RTBC ++
Thanks.
Hi @mahyarsbt I tried the commmand that you have mentioned and that installed the animatecss_aos module.
Shared snippet for reference.
RTBC ++
Thankyou
test@LAPTOP-6VFKUABC:~/contribution$ lando composer require 'drupal/animatecss_aos:1.0.x-dev@dev' --with-all-dependencies
__ __ __ __ ___ _ __ __ __ ______
/ / / /__ ___/ /__ _/ /____ / _ |_ _____ _(_) /__ _/ / / /__ / / / /
/ /_/ / _ \/ _ / _ `/ __/ -_) / __ | |/ / _ `/ / / _ `/ _ \/ / -_)_/_/_/
\____/ .__/\_,_/\_,_/\__/\__/ /_/ |_|___/\_,_/_/_/\_,_/_.__/_/\__(_|_|_)
/_/
Updating helps us provide the best support and saves us tons of time
Use the link below to get the latest and greatest
https://github.com/lando/lando/releases/tag/v3.21.0
Lando is FREE and OPEN SOURCE software that relies on contributions from developers like you!
If you like Lando then help us spend more time making, updating and supporting it by contributing at the link below
https://github.com/sponsors/lando
If you would like to customize the behavior of this message then check out:
https://docs.lando.dev/config/releases.html
./composer.json has been updated
Running composer update drupal/animatecss_aos --with-all-dependencies
Gathering patches for root package.
Loading composer repositories with package information
Updating dependencies
Lock file operations: 4 installs, 18 updates, 0 removals
- Upgrading behat/mink (v1.10.0 => v1.11.0)
- Upgrading doctrine/deprecations (v1.1.0 => 1.1.3)
- Upgrading doctrine/reflection (1.2.3 => 1.2.4)
- Locking drupal/animatecss (dev-1.1.x 10df662)
- Locking drupal/animatecss_aos (dev-1.0.x 5cd8f06)
- Locking drupal/animatecss_ui (1.1.0)
- Locking drupal/aosjs (1.0.1)
- Upgrading egulias/email-validator (3.2.5 => 3.2.6)
- Upgrading pear/pear-core-minimal (v1.10.13 => v1.10.15)
- Upgrading psr/http-client (1.0.2 => 1.0.3)
- Upgrading symfony/css-selector (v5.4.21 => v5.4.40)
- Upgrading symfony/deprecation-contracts (v2.5.2 => v2.5.3)
- Upgrading symfony/finder (v5.4.21 => v5.4.40)
- Upgrading symfony/http-client-contracts (v2.5.2 => v2.5.3)
- Upgrading symfony/http-kernel (v4.4.50 => v4.4.51)
- Upgrading symfony/polyfill-php72 (v1.27.0 => v1.29.0)
- Upgrading symfony/polyfill-php73 (v1.27.0 => v1.29.0)
- Upgrading symfony/polyfill-php81 (v1.27.0 => v1.29.0)
- Upgrading symfony/service-contracts (v2.5.2 => v2.5.3)
- Upgrading symfony/translation-contracts (v2.5.2 => v2.5.3)
- Upgrading symfony/var-dumper (v5.4.24 => v5.4.40)
- Upgrading twig/twig (v2.15.5 => v2.15.6)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 5 installs, 18 updates, 0 removals
- Downloading symfony/polyfill-php72 (v1.29.0)
- Downloading symfony/css-selector (v5.4.40)
- Downloading behat/mink (v1.11.0)
- Downloading symfony/deprecation-contracts (v2.5.3)
- Downloading symfony/finder (v5.4.40)
- Downloading symfony/polyfill-php81 (v1.29.0)
- Downloading symfony/translation-contracts (v2.5.3)
- Downloading symfony/service-contracts (v2.5.3)
- Downloading symfony/polyfill-php73 (v1.29.0)
- Downloading doctrine/deprecations (1.1.3)
- Downloading twig/twig (v2.15.6)
- Downloading symfony/http-client-contracts (v2.5.3)
- Downloading symfony/var-dumper (v5.4.40)
- Downloading symfony/http-kernel (v4.4.51)
- Downloading pear/pear-core-minimal (v1.10.15)
- Downloading egulias/email-validator (3.2.6)
- Downloading doctrine/reflection (1.2.4)
- Downloading drupal/aosjs (1.0.1)
- Syncing drupal/animatecss (dev-1.1.x 10df662) into cache
- Syncing drupal/animatecss_aos (dev-1.0.x 5cd8f06) into cache
- Downloading psr/http-client (1.0.3)
Gathering patches for root package.
Gathering patches for dependencies. This might take a minute.
- Upgrading symfony/polyfill-php72 (v1.27.0 => v1.29.0): Extracting archive
- Upgrading symfony/css-selector (v5.4.21 => v5.4.40): Extracting archive
- Upgrading behat/mink (v1.10.0 => v1.11.0): Extracting archive
- Upgrading symfony/deprecation-contracts (v2.5.2 => v2.5.3): Extracting archive
- Upgrading symfony/finder (v5.4.21 => v5.4.40): Extracting archive
- Upgrading symfony/polyfill-php81 (v1.27.0 => v1.29.0): Extracting archive
- Upgrading symfony/translation-contracts (v2.5.2 => v2.5.3): Extracting archive
- Upgrading symfony/service-contracts (v2.5.2 => v2.5.3): Extracting archive
- Upgrading symfony/polyfill-php73 (v1.27.0 => v1.29.0): Extracting archive
- Upgrading doctrine/deprecations (v1.1.0 => 1.1.3): Extracting archive
- Upgrading twig/twig (v2.15.5 => v2.15.6): Extracting archive
- Upgrading symfony/http-client-contracts (v2.5.2 => v2.5.3): Extracting archive
- Upgrading symfony/var-dumper (v5.4.24 => v5.4.40): Extracting archive
- Upgrading symfony/http-kernel (v4.4.50 => v4.4.51): Extracting archive
- Upgrading pear/pear-core-minimal (v1.10.13 => v1.10.15): Extracting archive
- Upgrading egulias/email-validator (3.2.5 => 3.2.6): Extracting archive
- Upgrading doctrine/reflection (1.2.3 => 1.2.4): Extracting archive
- Installing drupal/aosjs (1.0.1): Extracting archive
- Installing drupal/animatecss (dev-1.1.x 10df662): Cloning 10df6625d7 from cache
- Installing drupal/animatecss_ui (1.1.0)
- Installing drupal/animatecss_aos (dev-1.0.x 5cd8f06): Cloning 5cd8f066ef from cache
- Installing drupal/dempo (4.0.7): Extracting archive
- Upgrading psr/http-client (1.0.2 => 1.0.3): Extracting archive
Cleaning: symfony/css-selector
Cleaning: behat/mink
Cleaning: symfony/finder
Cleaning: twig/twig
Cleaning: symfony/var-dumper
Cleaning: symfony/http-kernel
Cleaning: pear/pear-core-minimal
Cleaning: egulias/email-validator
require [--dev] [--dry-run] [--prefer-source] [--prefer-dist] [--prefer-install PREFER-INSTALL] [--fixed] [--no-suggest] [--no-progress] [--no-update] [--no-install] [--update-no-dev] [-w|--update-with-dependencies] [-W|--update-with-all-dependencies] [--with-dependencies] [--with-all-dependencies] [--ignore-platform-req IGNORE-PLATFORM-REQ] [--ignore-platform-reqs] [--prefer-stable] [--prefer-lowest] [--sort-packages] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--apcu-autoloader-prefix APCU-AUTOLOADER-PREFIX] [--] [<packages>]...
test@LAPTOP-6VFKUABC:~/contribution$
I've reviewed the changes in merge request !13, and the detailed installation and configuration instructions have been added to the README file as discussed. These additions should help users set up the module correctly and address the initial confusion.
RTBC +
Thankyou.
Hi,
MR applied cleanly and the angle-up icon is now added. Attached a screenshot for reference.
Thankyou.
RTBC+
Hi,
The hamburger is now centre aligned. Attached screenshot for reference.
Thankyou
RTBC+
nisha_j → made their first commit to this issue’s fork.
Reviewed the MR there were no coding standards issue found.
So changing the status to RTBC.
Thankyou.
Thank you, @sanket.addweb, for the patch updating the README.txt file for compatibility with Drupal 9 and 10. I have reviewed the changes, and they look accurate and appropriate.
+RTBC
nisha_j → made their first commit to this issue’s fork.
nisha_j → made their first commit to this issue’s fork.
nisha_j → made their first commit to this issue’s fork.
Hi @adarshv verified the pages the scroll bar is not appearing on any of the pages it is looking fine.
Steps followed
1) Installed the theme and set as default.
2) Verified in home page, login page and contact page.
Attached snapshot for your reference.
So changing the status to RTBC
After applying MR the module is successfully uninstalled. However, thorough testing is required to ensure that the functionality still works as expected.
So changing the status to RTBC.
Hi #2 applied cleanly and we are able to add multiple values in recipeYield.
Hi, patch #2 applied cleanly, support for physician type schema is added and also attached a screenshot for reference.
Thankyou.
nisha_j → made their first commit to this issue’s fork.
nisha_j → made their first commit to this issue’s fork.
Patch #10 applied successfully. But it won't fixes all the mentioned phpcs issues.
So changing the status to Needs work.
Thankyou.
Addressed comment #9 and created an updated patch.
Hi, The changes suggested in comment #38 has been incorporated in the patch #39.
Thankyou.
Hi, I reviewed the MR and there are Line exceeds 80 characters error in .md files that needs to be fixed.
Thankyou.
Hi,
@Anjali Mehta has addressed the changes mentioned in comment #14
Thankyou
Hi, patch #10 fixes all the issues reported by phpcs and patch #12 addresses the issue mentioned in #12.
Thankyou.
Hi, patch #28 applied cleanly, but left with minor errors.
FILE: C:\Users\Nisha\Contribution\libraries\tests\src\Functional\LibrariesWebTest.php
-------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------
280 | ERROR | Public method name "LibrariesWebTest::_testLibrariesLoad" is not in lowerCamel format
411 | ERROR | Public method name "LibrariesWebTest::_testLibrariesOutput" is not in lowerCamel format
-------------------------------------------------------------------------------------------------------
Time: 1.7 secs; Memory: 14MB
Patch #30 applied cleanly and addresses all the issues mentioned in #22.
Hi, reviewed patch #24, but it couldn't be applied. Attached screenshot for reference.
Hi, patch #10 applied cleanly, and it is showing some whitespace warning.
git apply -v 3033027-10.patch Checking patch businessplus_lite.theme...
Checking patch config/install/block.block.businessplus_lite_breadcrumbs.yml...
Checking patch css/base/elements.css...
Checking patch css/components/buttons.css...
Checking patch css/components/call-to-action.css...
Checking patch css/components/detailed-feature-block.css...
Checking patch css/components/dropdowns.css...
Checking patch css/components/fa-icons-list.css...
Checking patch css/components/icons-list.css...
Checking patch css/components/menu.css...
Checking patch css/components/messages.css...
Checking patch css/components/pricing-tables.css...
Checking patch css/components/progress-bars.css...
Checking patch css/components/slideout.css...
Checking patch css/components/to-bottom-button.css...
Checking patch css/components/username.css...
Checking patch css/components/views.css...
Checking patch css/theme/color-blue.css...
Checking patch css/theme/color-green.css...
Checking patch css/theme/local-theme.css...
3033027-10.patch:2967: new blank line at EOF.
Checking patch js/init/flexslider-in-page-init.js...
Checking patch js/init/magnific-popup-field-image-init.js...
Checking patch js/init/owl-carousel-features-slideshow-init.js...
Checking patch js/init/owl-carousel-testimonials-init.js...
Checking patch js/init/slideout-init.js...
Checking patch js/init/waypoints-animations-init.js...
Checking patch js/init/waypoints-fixed-header-init.js...
Applied patch businessplus_lite.theme cleanly.
Applied patch config/install/block.block.businessplus_lite_breadcrumbs.yml cleanly.
Applied patch css/base/elements.css cleanly.
Applied patch css/components/buttons.css cleanly.
Applied patch css/components/call-to-action.css cleanly.
Applied patch css/components/detailed-feature-block.css cleanly.
Applied patch css/components/dropdowns.css cleanly.
Applied patch css/components/fa-icons-list.css cleanly.
Applied patch css/components/icons-list.css cleanly.
Applied patch css/components/menu.css cleanly.
Applied patch css/components/messages.css cleanly.
Applied patch css/components/pricing-tables.css cleanly.
Applied patch css/components/progress-bars.css cleanly.
Applied patch css/components/slideout.css cleanly.
Applied patch css/components/to-bottom-button.css cleanly.
Applied patch css/components/username.css cleanly.
Applied patch css/components/views.css cleanly.
Applied patch css/theme/color-blue.css cleanly.
Applied patch css/theme/color-green.css cleanly.
Applied patch css/theme/local-theme.css cleanly.
Applied patch js/animate/animate.css cleanly.
Applied patch js/custom/in-page-navigation-scroll.js cleanly.
Applied patch js/custom/to-top.js cleanly.
Applied patch js/flexslider/changelog.txt cleanly.
Applied patch js/flexslider/jquery.flexslider.js cleanly.
Applied patch js/init/flexslider-in-page-init.js cleanly.
Applied patch js/init/magnific-popup-field-image-init.js cleanly.
Applied patch js/init/owl-carousel-features-slideshow-init.js cleanly.
Applied patch js/init/owl-carousel-testimonials-init.js cleanly.
Applied patch js/init/slideout-init.js cleanly.
Applied patch js/init/waypoints-animations-init.js cleanly.
Applied patch js/init/waypoints-fixed-header-init.js cleanly.
Applied patch js/magnific-popup/jquery.magnific-popup.js cleanly.
Applied patch js/owl-carousel/assets/owl.carousel.css cleanly.
Applied patch js/owl-carousel/assets/owl.theme.default.css cleanly.
Applied patch js/owl-carousel/assets/owl.theme.green.css cleanly.
Applied patch js/owl-carousel/owl.carousel.js cleanly.
Applied patch js/slideout/slideout.css cleanly.
Applied patch js/waypoints/jquery.waypoints.js cleanly.
Applied patch js/waypoints/shortcuts/inview.js cleanly.
Applied patch js/waypoints/shortcuts/sticky.js cleanly.
Applied patch theme-settings.php cleanly.
warning: 1 line adds whitespace errors.
Thankyou.
Hi, In patch #17, the changes suggested in comment #16 have not been fully addressed; there are still pending changes that need to be addressed.
Thankyou.
Hi, patch #3 applied cleanly but still few errors need to be fixed.
Added a screenshot for reference.
Thankyou.
Hi, I am not able to apply patch #30 it is throwing error.
sha@LAPTOP-6VFKUABC MINGW64 ~/entity_print (8.x-2.x)
$ git apply issues-3352346-Fixed-error-reported-by-phpcs.patch
error: patch failed: src/Asset/AssetCollector.php:5
error: src/Asset/AssetCollector.php: patch does not apply
error: patch failed: src/Plugin/EntityPrint/PrintEngine/DomPdf.php:2
error: src/Plugin/EntityPrint/PrintEngine/DomPdf.php: patch does not apply
So changing the status to Needs work.
Thankyou.
Fixed the addressed changes.
Hi, patch #2 applied cleanly, the issue has been resolved.
Attached screenshot for reference.
So changing the status to RTBC.
Thankyou.
Hi, patch #12 applied cleanly but still there are phpcs issues.
$ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig sfc/
FILE: C:\Users\Nisha\sfc\CONTRIBUTING.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
51 | WARNING | Line exceeds 80 characters; contains 87 characters
----------------------------------------------------------------------
FILE: C:\Users\Nisha\sfc\modules\sfc_dev\src\Ajax\RefreshComponentAssetsCommand.php
-----------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
54 | ERROR | [x] list(...) is forbidden, use [...] instead.
-----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------
FILE: C:\Users\Nisha\sfc\modules\sfc_dev\src\Controller\ComponentDevController.php
----------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES
----------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
14 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is
| | Drupal\Component\Serialization\Json.
57 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
85 | ERROR | [x] Use null coalesce operator instead of ternary operator.
----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------
FILE: C:\Users\Nisha\sfc\modules\sfc_dev\src\Form\ComponentPreviewForm.php
----------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
15 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is
| | Drupal\sfc\ComponentConsumerTrait.
----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------
FILE: C:\Users\Nisha\sfc\modules\sfc_dev\src\Plugin\SingleFileComponent\ComponentLibrary.php
--------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
--------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------
FILE: C:\Users\Nisha\sfc\modules\sfc_dev\src\Plugin\SingleFileComponent\ComponentPicker.php
-------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
-------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------
FILE: C:\Users\Nisha\sfc\modules\sfc_dev\src\Plugin\SingleFileComponent\ComponentPreview.php
--------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
--------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------
FILE: C:\Users\Nisha\sfc\modules\sfc_dev\src\Plugin\SingleFileComponent\ComponentTemplate.php
---------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
---------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------
FILE: C:\Users\Nisha\sfc\modules\sfc_dev\tests\src\FunctionalJavascript\ComponentLibraryTest.php
------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------
FILE: C:\Users\Nisha\sfc\modules\sfc_dev\tests\src\Kernel\ComponentDevControllerTest.php
----------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------
FILE: C:\Users\Nisha\sfc\modules\sfc_dev\tests\src\Kernel\ComponentPreviewFormTest.php
--------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
--------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------
FILE: C:\Users\Nisha\sfc\modules\sfc_dev\tests\src\Kernel\ComponentPreviewTest.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------
FILE: C:\Users\Nisha\sfc\modules\sfc_dev\tests\src\Kernel\ComponentTemplateTest.php
-----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
-----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
Hi, I verified MR!21 still found some phpcs issues.
Attached screenshot for reference.
Thankyou.
Hi, patch #11 failed to apply.
$ git apply 3356331-11.patch -v
Checking patch custom_google_maps_block.module...
error: while searching for:
<?php
/**
* Implements hook_theme().
*/
function custom_google_maps_block_theme($existing, $type, $theme, $path)
{
return array(
'maps' => array(
'variables' => array(
'width' => NULL,
'height' => NULL,
'border' => NULL,
'border_radius' => NULL,
'color_border' => NULL,
'padding_maps' => NULL,
)
)
);
}
function custom_google_maps_block_preprocess_page(&$variables)
{
$config = \Drupal::config('maps.settings');
$variables['#attached']['drupalSettings']['maps_key'] = $config->get('maps_key');
}
error: patch failed: custom_google_maps_block.module:1
error: custom_google_maps_block.module: patch does not apply
Checking patch src/Form/MapsForm.php...
error: while searching for:
use Drupal\Core\Form\ConfigFormBase;
use Drupal\Core\Form\FormStateInterface;
class MapsForm extends ConfigFormBase
{
/**
* {@inheritdoc}
*/
public function getFormId()
{
return 'maps_form';
}
/**
* Gets the configuration names that will be editable.
*
* @return array
* An array of configuration object names that are editable if called in
* conjunction with the trait's config() method.
*/
protected function getEditableConfigNames()
{
return [
'maps.settings',
];
}
/**
* {@inheritdoc}
*/
public function buildForm(array $form, FormStateInterface $form_state)
{
$form = parent::buildForm($form, $form_state);
$config = $this->config('maps.settings');
$form['maps_key'] = array(
'#type' => 'textfield',
'#title' => $this->t('api key for google map'),
'#required' => TRUE,
'#default_value' => $config->get('maps_key'),
'#description' => $this->t('Go to <a target="_blank" href="https://console.developers.google.com">https://console.developers.google.com</a> to get a free API key'),
);
return $form;
}
/**
* {@inheritdoc}
*/
public function validateForm(array &$form, FormStateInterface $form_state)
{
$maps_key = $form_state->getValue('maps_key');
if (empty($maps_key)) {
$form_state->setErrorByName('maps_key', $this->t('this field is required '));
}
}
/**
* {@inheritdoc}
*/
public function submitForm(array &$form, FormStateInterface $form_state)
{
$config = $this->config('maps.settings');
$config->set('maps_key', $form_state->getValue('maps_key'));
$config->save();
parent::submitForm($form, $form_state);
}
}
error: patch failed: src/Form/MapsForm.php:5
error: src/Form/MapsForm.php: patch does not apply
Checking patch src/Plugin/Block/MapsBlock.php...
So changing the status to Needs work.
Thankyou.
Hi, patch #21 applied cleanly and changes suggested in #19 has been addressed in the patch #21
Thankyou.
Hi, patch #13 applied cleanly and changes suggested in #11 has been incorporated in patch #13.
Attached screenshot for reference.
Thankyou.
Hi, there are no phpcs errors found. So changing the status to RTBC.
Thankyou.
Hi, Patch #5 applied cleanly and also the changes mentioned in the #7 is also clearly addressed.
Thankyou.
Hi, patch #35 failed to apply.
$ git apply 2958038-35.patch -v
Checking patch README.txt...
error: while searching for:
* The administrative user interface can be found at
http://yoursite.com/admin/config/people/accounts
* Under Registration and cancellation section, select "New user registration by invitation only."
MAINTAINERS
error: patch failed: README.txt:38
error: README.txt: patch does not apply
Checking patch registration_invite.info.yml...
error: while searching for:
name: 'Registration Invite'
type: module
description: 'User registration by invitation only'
core: 8.x
package: 'Custom'
dependencies:
- invite
error: patch failed: registration_invite.info.yml:1
error: registration_invite.info.yml: patch does not apply
Checking patch registration_invite.routing.yml...
error: while searching for:
defaults:
_controller: '\Drupal\registration_invite\Controller\RegisterRedirect::content'
requirements:
_permission: 'access content'
error: patch failed: registration_invite.routing.yml:3
error: registration_invite.routing.yml: patch does not apply
Checking patch registration_invite.services.yml...
error: while searching for:
services:
registration_invite.default:
class: Drupal\registration_invite\EventSubscriber\RegisterSubscriber
arguments: []
tags:
- { name: event_subscriber }
error: patch failed: registration_invite.services.yml:1
error: registration_invite.services.yml: patch does not apply
Checking patch src/Controller/RegisterRedirect.php...
error: while searching for:
use Drupal\Core\Controller\ControllerBase;
/**
* Class RegisterRedirect.
*/
class RegisterRedirect extends ControllerBase {
error: patch failed: src/Controller/RegisterRedirect.php:5
error: src/Controller/RegisterRedirect.php: patch does not apply
Checking patch src/EventSubscriber/RegisterSubscriber.php...
error: while searching for:
namespace Drupal\registration_invite\EventSubscriber;
use Symfony\Component\EventDispatcher\EventSubscriberInterface;
use Symfony\Component\EventDispatcher\Event;
use Symfony\Component\HttpFoundation\RedirectResponse;
use Symfony\Component\HttpKernel\KernelEvents;
use Symfony\Component\HttpKernel\Event\GetResponseEvent;
/**
* Class RegisterSubscriber.
*/
class RegisterSubscriber implements EventSubscriberInterface {
/**
* {@inheritdoc}
*/
public function checkIfReferred(GetResponseEvent $event) {
$request = $event->getRequest();
$config = \Drupal::config('user.settings');
if ($request->attributes->get('_route') == 'user.register' && $config->get('register') === 'invie_only') {
$access = TRUE;
if (empty($_SESSION['invite_code']) && !(\Drupal::currentUser()->hasPermission('administer uses'))) {
$access = FALSE;
}
if (!$access) {
error: patch failed: src/EventSubscriber/RegisterSubscriber.php:3
error: src/EventSubscriber/RegisterSubscriber.php: patch does not apply
Checking patch templates/registration-invite.html.twig...
error: while searching for:
<!-- Add you custom twig html here -->
error: patch failed: templates/registration-invite.html.twig:1
error: templates/registration-invite.html.twig: patch does not apply
So changing the status to Needs work.
Thankyou.
Hi, patch #27 applied cleanly but it not fixes all the phpcs issues.
phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml galleryslider/
FILE: C:\Users\Nisha\galleryslider\css\galleryslider.css
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------
FILE: C:\Users\Nisha\galleryslider\css\gridslide.css
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------
FILE: C:\Users\Nisha\galleryslider\galleryslider.install
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------
FILE: C:\Users\Nisha\galleryslider\galleryslider.module
------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
121 | ERROR | [x] Use null coalesce operator instead of ternary operator.
------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------
FILE: C:\Users\Nisha\galleryslider\src\Plugin\Field\FieldFormatter\GallerySliderFieldFormatter.php
-----------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
172 | WARNING | [x] 'TODO: Implement settings summary.' should match the format '@todo Fix problem
| | X here.'
242 | ERROR | [x] Use null coalesce operator instead of ternary operator.
-----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------
FILE: C:\Users\Nisha\galleryslider\src\Plugin\views\style\GallerySlider.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------
Time: 474ms; Memory: 10MB
Hi, the patch #17 is throwing as mentioned above so changing the status to Needs work.
Thankyou.
Hi, patch #23 applied cleanly but it not fixes all the phpcs issues.
$ phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml ajans/
FILE: C:\Users\Nisha\ajans\ajans.theme
-----------------------------------------------------------------------------------------------------
FOUND 78 ERRORS AND 13 WARNINGS AFFECTING 67 LINES
-----------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
8 | WARNING | [x] Unused use statement
9 | WARNING | [x] Unused use statement
9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is
| | Drupal\Core\Template\Attribute.
10 | WARNING | [x] Unused use statement
11 | WARNING | [x] Unused use statement
12 | WARNING | [x] Unused use statement
13 | WARNING | [x] Unused use statement
15 | WARNING | [x] Unused use statement
16 | WARNING | [x] Unused use statement
17 | ERROR | [x] There must be one blank line after the last USE statement; 2 found;
22 | ERROR | [x] There must be no blank lines after the function comment
41 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks,
| | colons, or closing parentheses
42 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
42 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 1 space but
| | found 2 spaces
43 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
44 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
48 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
49 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
49 | ERROR | [x] Expected one space after the comma, 0 found
50 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
51 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
52 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
53 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
54 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
55 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
56 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
57 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
64 | ERROR | [x] There should be no white space after an opening "{"
64 | ERROR | [x] Comments may not appear after statements
66 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
67 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
68 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
70 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
71 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 6
72 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 6
73 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
74 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
75 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
75 | ERROR | [x] Closing brace indented incorrectly; expected 2 spaces, found 0
80 | ERROR | [ ] Doc comment short description must be on a single line, further text should be
| | a separate paragraph
83 | ERROR | [x] Short array syntax must be used to define arrays
87 | ERROR | [x] Concat operator must be surrounded by a single space
88 | ERROR | [x] Concat operator must be surrounded by a single space
95 | ERROR | [x] Missing function doc comment
96 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
97 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
98 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
99 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
99 | ERROR | [x] Concat operator must be surrounded by a single space
99 | ERROR | [x] Expected one space after the comma, 0 found
100 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
101 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
102 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
103 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
104 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
105 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
106 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
107 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
110 | ERROR | [x] Expected 1 blank line after function; 2 found
116 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements
241 | ERROR | [x] Whitespace found at end of line
245 | WARNING | [ ] Translatable strings must not begin or end with white spaces, use placeholders
| | with t() for variables
245 | ERROR | [ ] Concatenating translatable strings is not allowed, use placeholders instead and
| | only one string literal
245 | ERROR | [x] Concat operator must be surrounded by a single space
251 | WARNING | [ ] Translatable strings must not begin or end with white spaces, use placeholders
| | with t() for variables
251 | ERROR | [ ] Concatenating translatable strings is not allowed, use placeholders instead and
| | only one string literal
251 | ERROR | [x] Concat operator must be surrounded by a single space
251 | ERROR | [x] Concat operator must be surrounded by a single space
252 | ERROR | [x] Concat operator must be surrounded by a single space
252 | ERROR | [x] Expected one space after the comma, 0 found
257 | WARNING | [ ] Translatable strings must not begin or end with white spaces, use placeholders
| | with t() for variables
257 | ERROR | [ ] Concatenating translatable strings is not allowed, use placeholders instead and
| | only one string literal
257 | ERROR | [x] Concat operator must be surrounded by a single space
257 | ERROR | [x] Concat operator must be surrounded by a single space
258 | ERROR | [x] Expected one space after the comma, 0 found
262 | WARNING | [ ] Translatable strings must not begin or end with white spaces, use placeholders
| | with t() for variables
262 | ERROR | [ ] Concatenating translatable strings is not allowed, use placeholders instead and
| | only one string literal
262 | ERROR | [x] Concat operator must be surrounded by a single space
262 | ERROR | [x] Concat operator must be surrounded by a single space
263 | ERROR | [x] Expected one space after the comma, 0 found
264 | ERROR | [x] Whitespace found at end of line
267 | WARNING | [ ] Translatable strings must not begin or end with white spaces, use placeholders
| | with t() for variables
267 | ERROR | [ ] Concatenating translatable strings is not allowed, use placeholders instead and
| | only one string literal
267 | ERROR | [x] Concat operator must be surrounded by a single space
267 | ERROR | [x] Concat operator must be surrounded by a single space
268 | ERROR | [x] Expected one space after the comma, 0 found
272 | ERROR | [x] Concat operator must be surrounded by a single space
272 | ERROR | [x] Expected one space after the comma, 0 found
273 | ERROR | [x] Expected 1 space after IF keyword; 0 found
273 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
-----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 80 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------
FILE: C:\Users\Nisha\ajans\assets\css\bootstrap.css
-------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
3030 | ERROR | [ ] Style definitions must end with a semicolon
-------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------
FILE: C:\Users\Nisha\ajans\assets\css\custom.css
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------
FILE: C:\Users\Nisha\ajans\assets\css\templatemo.css
------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
163 | ERROR | [ ] Style definitions must end with a semicolon
199 | ERROR | [ ] Style definitions must end with a semicolon
------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------
FILE: C:\Users\Nisha\ajans\css\style.css
------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
52 | ERROR | [ ] Style definitions must end with a semicolon
137 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------
FILE: C:\Users\Nisha\ajans\css\theme.css
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------
Time: 10.43 secs; Memory: 124MB
Hi, patch #12 applied cleanly but it not fixes all the phpcs issues.
$ phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml news_zymphonies_theme/
FILE: ...isha\news_zymphonies_theme\config\optional\block.block.news_zymphonies_theme_page_title.yml
-------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------
17 | ERROR | [x] Expected 1 newline at end of file; 0 found
-------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------
FILE: C:\Users\Nisha\news_zymphonies_theme\css\global.css
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
----------------------------------------------------------------------
FILE: C:\Users\Nisha\news_zymphonies_theme\css\media.css
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
----------------------------------------------------------------------
FILE: C:\Users\Nisha\news_zymphonies_theme\includes\flexslider\css\flexslider.css
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------
FILE: C:\Users\Nisha\news_zymphonies_theme\includes\fontawesome\css\font-awesome.css
------------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
121 | ERROR | [ ] Style definitions must end with a semicolon
127 | ERROR | [ ] Style definitions must end with a semicolon
133 | ERROR | [ ] Style definitions must end with a semicolon
139 | ERROR | [ ] Style definitions must end with a semicolon
145 | ERROR | [ ] Style definitions must end with a semicolon
------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------
FILE: C:\Users\Nisha\news_zymphonies_theme\includes\owl\assets\owl.carousel.css
------------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 5 LINES
------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
1 | ERROR | [x] Whitespace found at end of line
40 | ERROR | [x] Whitespace found at end of line
51 | ERROR | [x] Whitespace found at end of line
146 | ERROR | [x] Whitespace found at end of line
161 | ERROR | [x] Whitespace found at end of line
------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------
FILE: C:\Users\Nisha\news_zymphonies_theme\includes\smartmenus\sm-core-css.css
------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
179 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------
FILE: C:\Users\Nisha\news_zymphonies_theme\news_zymphonies_theme.theme
------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
114 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 6
115 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 6
------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------
Time: 2.51 secs; Memory: 18MB
Hi,
I have reviewed patch #12, it looks good to me. It applied cleanly and fixed phpcs errors and warning.
So changing the status to RTBC.
Thankyou.
Create a patch to fix the phpcs errors.
These errors are remaining:
$ phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml tmgmt_cdt/
FILE: C:\Users\Nisha\tmgmt_cdt\src\TmgmtCdtApi.php
-----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------
1415 | ERROR | [x] Closing brace indented incorrectly; expected 4 spaces, found 2
-----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------
FILE: C:\Users\Nisha\tmgmt_cdt\src\TmgmtCdtFormatHelper.php
-------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-------------------------------------------------------------------------------
134 | WARNING | Code after the THROW statement on line 133 cannot be executed
140 | WARNING | Code after the THROW statement on line 139 cannot be executed
-------------------------------------------------------------------------------
Thankyou.
Hi, the patch #17 applied cleanly.
So changing the status to RTBC.
Thanks
Hi,
I applied patch, and it applied cleanly.
So changing the status to RTBC.
Thankyou
nisha_j → made their first commit to this issue’s fork.
nisha_j → made their first commit to this issue’s fork.
Hi, patch 3370874-2.patch #2 cleanly.
Attached screenshot for reference.
Hi, patch 3353697-5.patch #5 applied cleanly.
Tested on drupal 10.1 and php version 8.1
Applied patch and ran these commands:
phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml ui_styles_paragraphs/
uploaded screenshot for reference.
Patch #6 fixes issues reported by phpcs.
Applied patch and ran these commands:
phpcs --standard=DrupalPractice --extensions='php,module,inc,install,test,profile,theme,info,txt,md'
phpcs --standard=Drupal --extensions='php,module,inc,install,test,profile,theme,info,txt,md'
Patch #6 fixes issues reported by phpcs.
Applied patch and ran these commands:
phpcs --standard=DrupalPractice --extensions='php,module,inc,install,test,profile,theme,info,txt,md'
phpcs --standard=Drupal --extensions='php,module,inc,install,test,profile,theme,info,txt,md'