- Issue created by @Asheesh kumar Pal
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 7:53am 27 April 2023 - 🇮🇳India Asheesh kumar Pal New Delhi
I have applied a patch for the above issue, please review it.
- Status changed to RTBC
over 1 year ago 9:47am 27 April 2023 - 🇵ðŸ‡Philippines clarkssquared
Hi Asheesh kumar Pal
I applied your patch #3 and to View Marquee version 8.0.x-dev and confirmed that the PHPCS issues were fixed.
Please look at the screenshot attached for your reference
Thank you.
- Status changed to Needs work
over 1 year ago 3:57pm 20 May 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
- '#description' => t('The class to provide on each row. You may use field tokens from as per the "Replacement patterns" used in "Rewrite the output of this field" for all fields. .'), + '#description' => $this->t('The class to provide on each row. You may use field tokens from as per the "Replacement patterns" used in "Rewrite the output of this field" for all fields. .'),
Since that line is changed, the extra space and period must be removed too.
+/** + * @file + * View Marquee Views module help and theme functions. + */
The usual module description is Hook implementations for the [module name] module. where [module name] is replaced by the module name shown in the .info.yml file.
- First commit to issue fork.
- Merge request !6Issue#3356791-Addressed Review comments and opening an MR. → (Open) created by Unnamed author
- Status changed to Needs review
over 1 year ago 4:23pm 20 May 2023 - Status changed to Needs work
over 1 year ago 4:29pm 20 May 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
The files for which errors/warnings are reported are:
- src/Plugin/views/style/ViewMarquee.php
- css/style.css
- view-marquee.theme.inc
- view_marquee/view_marquee.info.yml
The MR changes the following files:
- src/Plugin/views/style/ViewMarquee.php
- README.md
- view_marquee.module
The changed files must match with the files for which errors/warning have been reported.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
The MR is still changing less files than the files reported by PHP_CodeSniffer.
- Assigned to nitin_lama
- 🇮🇳India nitin_lama India
@apaderno I believe IS needs to be updated. I don't see any PHPCS issue on branch "issue#3356791/fix-phpcs-issues".
Command used:alias drupalcs="phpcs --standard=Drupal --extensions='php,module,inc,install,test,profile,theme,info,txt,md,css'" alias drupalcsp="phpcs --standard=DrupalPractice --extensions='php,module,inc,install,test,profile,theme,info,txt,md,css'"
Thanks.
- Issue was unassigned.
- Assigned to radheymkumar
- Status changed to Fixed
9 months ago 12:39pm 28 February 2024 - 🇮🇳India radheymkumar Jaipur, Rajasthan, India
Hi @Asheesh Kumar Pal
Thanks, I applied your patch and created a new release.
Automatically closed - issue fixed for 2 weeks with no activity.