#Needs reroll

I apologize: I reverted the changes.

I apologize: I reverted the changes.

Drupal 7 is no longer supported. If this applies to Drupal 10/11, please re-open.

Thank you! The changes have been committed.

Thank you! The changes have been committed.

The order of the CSS properties needs to be changed.

Thank you! The changes have been committed.

The code in the user.permissions.js file has been changed, and it now removes the form-checkbox CSS class.

// Create fake checkboxes. We use fake checkboxes instead of reusing
// the existing checkboxes here because new checkboxes don't alter the
// submitted form. If we'd automatically check existing checkboxes, the
// permission table would be polluted with redundant entries. This is
// deliberate, but desirable when we automatically check them.
const $fakeCheckbox = $(Drupal.theme('checkbox'))
  .removeClass('form-checkbox')
  .addClass('fake-checkbox js-fake-checkbox')
  .attr({
    disabled: 'disabled',
    checked: 'checked',
    title: Drupal.t(
      'This permission is inherited from the authenticated user role.',
    ),
  });
const $wrapper = $('<div></div>').append($fakeCheckbox);
const fakeCheckboxHtml = $wrapper.html();

We should implement code similar to the one used by the Claro theme.

The initial commit already included a file with the following content.

/**
 * @file
 * Seven specific styling for CKEditor admin.
 */

/*
 * This rule is needed to provide Seven's blue focus outline.
 */
.ckeditor-toolbar-disabled .ckeditor-buttons li a:focus {
  box-shadow:
    inset 0 1px 3px rgba(0, 0, 0, 0.05),
    0 0 8px #40b6ff;
}

.ckeditor-toolbar-active .ckeditor-buttons li a:focus {
  box-shadow:
    inset 0 1px 3px rgba(0, 0, 0, 0.05),
    0 0 8px #40b6ff;
}

What should be changed in that file is the comment before the CSS rules, and the property used for those roles.

(See comment #16 for some hints on what that comment can say.)

See comment #44 for the approach to follow.

The last patch is missing the part that adds the new settings in the theme settings form, which was provided in patch #18 → .

I agree with @laurii: The style is applied to a too generic selector. It should be applied to a more specific selector.

The screenshots seem to show a link fort a node title. If the issue would try to fix at least that case, that would be more acceptable.

avpaderno → reopened merge request !78

avpaderno → closed merge request !78