- 🇺🇸United States mlncn Minneapolis, MN, USA
This looks like fantastic work but one question— is there any reason a person using a screenreader should have to hear about all the blocks we hide from view?
That is, in:
$form[$entity_id]['#attributes']['class'][] = 'visually-hidden';Shouldn't we use just "hidden" here?
- 🇫🇷France arousseau
This issue is still present with the current 2.0.4 version of the module.
The MR fixes the problem and all blocks retain their relative order, even after using drag and drop, within a single visibility group.
I see there is now a 2.1.x branch, so I am not sure if there should be a new MR created for it.
The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.