#Needs reroll

Re-rolled The patch by mr .

Prem Suthar → made their first commit to this issue’s fork.

Let's create a merge request, now that patches are no longer tested.

Automatically closed - issue fixed for 2 weeks with no activity.

I wasn't sure about this issue so I confirmed with @daffie that this is still relevant. In the same message they mentioned that there are other higher priority issues than removing these tests.

Hi sourabhjain,

Applied the patch you provided, there are only 2 files that were not patched successfully, but report shows 6 files need to be fixed. Please see below:

media_remote git:(1.x) curl https://www.drupal.org/files/issues/2022-08-09/3302374-4.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 17014  100 17014    0     0  54179      0 --:--:-- --:--:-- --:--:-- 56903
patching file README.md
Hunk #1 succeeded at 53 (offset 6 lines).
patching file media_remote.module
Hunk #1 succeeded at 183 (offset 85 lines).
patching file src/Plugin/Field/FieldFormatter/MediaRemoteBoxFormatter.php
patching file src/Plugin/Field/FieldFormatter/MediaRemoteDacastFormatter.php
patching file src/Plugin/Field/FieldFormatter/MediaRemoteDropboxFormatter.php
patching file src/Plugin/Field/FieldFormatter/MediaRemoteGoogleFormatter.php
patching file src/Plugin/Field/FieldFormatter/MediaRemoteNPRFormatter.php
patching file src/Plugin/media/Source/MediaRemoteSource.php
patching file tests/src/FunctionalJavascript/Formatters/BuzzsproutFormatterTest.php
patching file tests/src/FunctionalJavascript/Formatters/DocumentcloudFormatterTest.php
patching file tests/src/FunctionalJavascript/Formatters/DropboxFormatterTest.php
patching file tests/src/FunctionalJavascript/Formatters/GoogleFormatterTest.php
patching file tests/src/FunctionalJavascript/Formatters/NPRFormatterTest.php
patching file tests/src/FunctionalJavascript/MediaRemoteFunctionalJavascriptTestBase.php
➜  media_remote git:(1.x) ✗ cd ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig media_remote

FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/media_remote/tests/src/FunctionalJavascript/Formatters/NPRFormatterTest.php
-------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------
 17 | ERROR | Public method name "NPRFormatterTest::testNPR" is not in lowerCamel format
-------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/media_remote/tests/src/FunctionalJavascript/Formatters/QuickbaseFormatterTest.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------------
 20 | WARNING | Unused variable $page.
-------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/media_remote/src/Plugin/Field/FieldFormatter/MediaRemoteArcGISFormatter.php
-------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 9 ERRORS AFFECTING 9 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------------
  90 | ERROR | [x] Expected 1 blank line after function; 2 found
  98 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
  99 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
 100 | ERROR | [x] Array closing indentation error, expected 4 spaces but found 6
 108 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
 116 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
 124 | ERROR | [x] Array closing indentation error, expected 4 spaces but found 6
 137 | ERROR | [x] Expected 1 blank line after function; 0 found
 138 | ERROR | [x] The closing brace for the class must have an empty line before it
-------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/media_remote/src/Plugin/Field/FieldFormatter/MediaRemoteMsFormsFormatter.php
--------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------------------------------------------
  6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Utility\Html.
 93 | ERROR | [x] Expected 1 blank line after function; 2 found
--------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/media_remote/src/Plugin/Field/FieldFormatter/MediaRemoteApplePodcastsFormatter.php
--------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------------------------
 32 | WARNING | [x] A comma should follow the last multiline array item. Found: 'https://podcasts.apple.com/us/podcast/[episode-title]/[id]?i=[token]'
--------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/media_remote/src/Plugin/Field/FieldFormatter/MediaRemoteLoomFormatter.php
-----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------
  83 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
  84 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
  85 | ERROR | [x] Array closing indentation error, expected 4 spaces but found 6
  93 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
 102 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
 111 | ERROR | [x] Array closing indentation error, expected 4 spaces but found 6
-----------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------------

Time: 823ms; Memory: 10MB

Kindly check

Thanks,
Jake

Automatically closed - issue fixed for 2 weeks with no activity.