#Needs reroll

prem suthar → made their first commit to this issue’s fork.

Believe all feedback for this one has been addressed.

@berdir, Thanks you for the Information :)

Yes, uri_callback has not actually been used in a very, very long time. If it would have been called, it would have triggered deprecation errors in the tests. Looking at \Drupal\Core\Entity\EntityBase::toUrl(), it only falls back to that if there are no link templates defined. Which isn't the case for the comment entity (or any other entity in core AFAIK).

@berdir Thank you for the feedback , I have removed the uri_callback and tested the functionality. It is working as expected. However, I am a bit unsure if there is anything else that needs to be updated related to this.

Moving this for NR , Kindly review.

Tests added! :)

This function is still referenced on the Comment entity type attribute as the uri callback, it should be removed there. https://git.drupalcode.org/project/drupal/-/blob/010bbc7476df8c23b0170f5...

Removed the comment on the return statement, as I believe it was not appropriate.
Kindly review.

Moving this for your review.

Left 1 more comment on the thread started by @larowlan

@smustgrave Thank you for the review & feedback , I have updated the test file name and comment for the test class, Accordingly updated the Phpstan baseline . Re-run test after these changes and working as expected. and pipeline is green so moving this again for your review.
Kindly review.

Left another small comment on MR.

I have reviewed all the feedback and made the necessary updates. After making the changes, I re-ran the tests, and This is working as expected. Moving this to NR for your review.

Looking into the MR feedback.