mradcliffe → credited realityloop → .
realityloop → made their first commit to this issue’s fork.
fubarhouse → credited realityloop → .
realityloop → made their first commit to this issue’s fork.
realityloop → made their first commit to this issue’s fork.
Screenshot of settings form after this change, Notification email section is collapsed by default.
realityloop → changed the visibility of the branch 3514926-aloow-editing-of to hidden.
realityloop → created an issue. See original summary → .
If you have a case insensitive filesystem (for example for macOS) execute the following
mradcliffe → credited realityloop → .
update instructions for adding additional projects on simplytest.me
not possible to link to in page title ancors, links removed from table
fix tip wording now that there are more than two options
add third option to table (Cloud development environment)
Reduce verbosity of introduction, convert options to table format
Creating an issue summary is a great Novice task for Contribution workshop at Drupalcon
mradcliffe → credited realityloop → .
@deiterholvoet sorry, maybe it kept working because I had already assigned perms to some users
I can confirm this is no longer required.
gargsuchi → credited realityloop → .
@darren oh can you please explain in a bit more detail whats the blocker and whats required to get around the dind issue?
I'm not really sure when meetings are occurring.. I'm sure I used to get notifications somehow (as they used to pretty much occur while I am asleep, Australia sux for that) .. but 'm pretty sure they are done in an async fasion now right?
hestenet → credited realityloop → .
hestenet → credited realityloop → .
hestenet → credited realityloop → .
hestenet → credited realityloop → .
The error occurs because the collect
method expects an integer for the $limit
argument but receives null
. To fix this allows $limit
to be either an integer or null, defaulting to 0 if not provided.
realityloop → created an issue.
realityloop → created an issue.
Improved data handling of the denormalize function and tome-install is working now.
realityloop → created an issue.
from Slack:
samuel.mortenson said
The lack of a normalize method in https://git.drupalcode.org/project/smart_date/-/blob/4.2.x/src/Normalize... makes the bug kind of make sense, it's like normalizing as a format that can't be denormalized
Often I'll test things with the rest module first, since if it (the field type) works there then it should work with tome_sync
Yep, fine by me to close it.
realityloop → created an issue.
I can confirm this issue was causing test fails for toggle_editable_fields module, I had to add the following to the ci task so that it would pass:
.composer-base:
before_script:
- composer require drupal/libraries:^4.0 --no-update
after_script:
- mkdir $_WEB_ROOT/modules/contrib/libraries/config/optional
- mv $_WEB_ROOT/modules/contrib/libraries/config/install/libraries.settings.yml $_WEB_ROOT/modules/contrib/libraries/config/optional/libraries.settings.yml
realityloop → created an issue.
I've just added a check that the columns exist in the ip_login_update_9002() install hook
perhaps becauuse my DB is already converted:
drush updb -y
---------- ----------- --------------- ---------------------------------------------------------------
Module Update ID Type Description
---------- ----------- --------------- ---------------------------------------------------------------
ip_login 9002 hook_update_n 9002 - Migrate ip address values from old field to new table.
ip_login 9003 hook_update_n 9003 - Remove single value IP Login field from User entity.
---------- ----------- --------------- ---------------------------------------------------------------
// Do you wish to run the specified pending updates?: yes.
> [notice] Update started: ip_login_update_9002
> [error] SQLSTATE[42S22]: Column not found: 1054 Unknown column 'ip_login__ip_start' in 'field list': SELECT uid, ip_login__ip_start, ip_login__ip_end
> FROM users_field_data
> WHERE ip_login__ip_start IS NOT NULL; Array
> (
> )
>
> [error] Update failed: ip_login_update_9002
[error] Update aborted by: ip_login_update_9002
[error] Finished performing updates.
does not currently apply to dev branch, I've just updated the MR, apologies for losing individual commits, I exported patches for each of them before rebasing dev in attached archive
realityloop → made their first commit to this issue’s fork.
To test or use this:
To add the module to your project you need to ensure that the repositories section of your composer file includes the text below:
"repositories": {
"drupal": {
"type": "composer",
"url": "https://packages.drupal.org/8",
"exclude": [
"drupal/toggle_editable_fields"
]
},
"drupal/toggle_editable_fields": {
"type": "git",
"url": "https://git.drupalcode.org/issue/toggle_editable_fields-3488832.git"
},
"minhur/bootstrap-toggle": {
"type": "package",
"package": {
"name": "minhur/bootstrap-toggle",
"version": "1.0.0",
"type": "drupal-library",
"dist": {
"url": "https://github.com/minhur/bootstrap-toggle/archive/master.zip",
"type": "zip"
}
}
}
},
Once you have done this you install the correct version of the module using the following composer command:
composer require drupal/toggle_editable_fields:dev-3488832-update-for-drupal
Tests are passing locally:
ddev phpunit modules/contrib/toggle_editable_fields
PHPUnit 9.6.21 by Sebastian Bergmann and contributors.
Testing /var/www/html/web/modules/contrib/toggle_editable_fields
.. 2 / 2 (100%)
Time: 00:08.826, Memory: 12.00 MB
OK (2 tests, 48 assertions)
HTML output was generated
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_toggle_editable_fields_Functional_LoadTest-1-25831524.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_toggle_editable_fields_Functional_LoadTest-2-25831524.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_toggle_editable_fields_Functional_LoadTest-3-25831524.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_toggle_editable_fields_Functional_LoadTest-4-25831524.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_toggle_editable_fields_Functional_ToggleEditableFieldsUiTest-1-82704371.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_toggle_editable_fields_Functional_ToggleEditableFieldsUiTest-2-82704371.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_toggle_editable_fields_Functional_ToggleEditableFieldsUiTest-3-82704371.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_toggle_editable_fields_Functional_ToggleEditableFieldsUiTest-4-82704371.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_toggle_editable_fields_Functional_ToggleEditableFieldsUiTest-5-82704371.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_toggle_editable_fields_Functional_ToggleEditableFieldsUiTest-6-82704371.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_toggle_editable_fields_Functional_ToggleEditableFieldsUiTest-7-82704371.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_toggle_editable_fields_Functional_ToggleEditableFieldsUiTest-8-82704371.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_toggle_editable_fields_Functional_ToggleEditableFieldsUiTest-9-82704371.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_toggle_editable_fields_Functional_ToggleEditableFieldsUiTest-10-82704371.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_toggle_editable_fields_Functional_ToggleEditableFieldsUiTest-11-82704371.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_toggle_editable_fields_Functional_ToggleEditableFieldsUiTest-12-82704371.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_toggle_editable_fields_Functional_ToggleEditableFieldsUiTest-13-82704371.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_toggle_editable_fields_Functional_ToggleEditableFieldsUiTest-14-82704371.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_toggle_editable_fields_Functional_ToggleEditableFieldsUiTest-15-82704371.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_toggle_editable_fields_Functional_ToggleEditableFieldsUiTest-16-82704371.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_toggle_editable_fields_Functional_ToggleEditableFieldsUiTest-17-82704371.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_toggle_editable_fields_Functional_ToggleEditableFieldsUiTest-18-82704371.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_toggle_editable_fields_Functional_ToggleEditableFieldsUiTest-19-82704371.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_toggle_editable_fields_Functional_ToggleEditableFieldsUiTest-20-82704371.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_toggle_editable_fields_Functional_ToggleEditableFieldsUiTest-21-82704371.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_toggle_editable_fields_Functional_ToggleEditableFieldsUiTest-22-82704371.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_toggle_editable_fields_Functional_ToggleEditableFieldsUiTest-23-82704371.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_toggle_editable_fields_Functional_ToggleEditableFieldsUiTest-24-82704371.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_toggle_editable_fields_Functional_ToggleEditableFieldsUiTest-25-82704371.html
realityloop → created an issue.
realityloop → created an issue.
Tome maintainer has made a d11 fork here https://git.drupalcode.org/project/tome/-/merge_requests/29
realityloop → created an issue.
@mirom
Getting the following error locally, the node in question doesn't have any added fields that are date fields:
brian@drupal-foundry-web:/var/www/html$ drush tome:install -y
// You are about to DROP all tables in your local database and re-install Tome. Do you want to continue?: yes.
In SiteProcess.php line 214:
The command "/var/www/html/vendor/bin/drush tome:import --yes --uri=https://drupal-foundry.ddev.site" failed.
Exit Code: 1(General error)
Working directory:
Output:
================
[ERROR] Errors encountered when importing content:
[ERROR] Error when running "'/var/www/html/vendor/bin/drush' 'tome:import-content'
'node.92365dea-5736-4f30-8b0b-c7e6b5585b98'":
[warning] Undefined array key "end_value" SmartDateNormalizer.php:40
[error] Error: Call to a member function getTimestamp() on null in
Drupal\serialization\Normalizer\TimestampNormalizer->denormalize() (line 39 of
/var/www/html/web/core/modules/serialization/src/Normalizer/TimestampNormalizer.php) #0
/var/www/html/web/modules/contrib/smart_date/src/Normalizer/SmartDateNormalizer.php(40):
Drupal\serialization\Normalizer\TimestampNormalizer->denormalize()
#1 /var/www/html/vendor/symfony/serializer/Serializer.php(238):
Drupal\smart_date\Normalizer\SmartDateNormalizer->denormalize()
#2 /var/www/html/web/modules/contrib/smart_date/src/Normalizer/SmartDateItemNormalizer.php(45):
Symfony\Component\Serializer\Serializer->denormalize()
#3 /var/www/html/web/core/modules/serialization/src/Normalizer/FieldItemNormalizer.php(33):
Drupal\smart_date\Normalizer\SmartDateItemNormalizer->constructValue()
#4 /var/www/html/vendor/symfony/serializer/Serializer.php(238):
Drupal\serialization\Normalizer\FieldItemNormalizer->denormalize()
#5 /var/www/html/web/core/modules/serialization/src/Normalizer/FieldNormalizer.php(47):
Symfony\Component\Serializer\Serializer->denormalize()
#6 /var/www/html/vendor/symfony/serializer/Serializer.php(238):
Drupal\serialization\Normalizer\FieldNormalizer->denormalize()
#7 /var/www/html/web/core/modules/serialization/src/Normalizer/FieldableEntityNormalizerTrait.php(152):
Symfony\Component\Serializer\Serializer->denormalize()
#8 /var/www/html/web/core/modules/serialization/src/Normalizer/EntityNormalizer.php(59):
Drupal\serialization\Normalizer\EntityNormalizer->denormalizeFieldData()
#9 /var/www/html/vendor/symfony/serializer/Serializer.php(238):
Drupal\serialization\Normalizer\EntityNormalizer->denormalize()
#10 /var/www/html/web/modules/contrib/tome/modules/tome_sync/src/Importer.php(272):
Symfony\Component\Serializer\Serializer->denormalize()
#11 /var/www/html/web/modules/contrib/tome/modules/tome_sync/src/Importer.php(215):
Drupal\tome_sync\Importer->loadEntityFromStorage()
#12 /var/www/html/web/modules/contrib/tome/modules/tome_sync/src/Commands/ImportContentCommand.php(34):
Drupal\tome_sync\Importer->importContent()
#13 /var/www/html/vendor/symfony/console/Command/Command.php(279):
Drupal\tome_sync\Commands\ImportContentCommand->execute()
#14 /var/www/html/vendor/symfony/console/Application.php(1047):
Symfony\Component\Console\Command\Command->run()
#15 /var/www/html/vendor/symfony/console/Application.php(316):
Symfony\Component\Console\Application->doRunCommand()
#16 /var/www/html/vendor/symfony/console/Application.php(167): Symfony\Component\Console\Application->doRun()
#17 /var/www/html/vendor/drush/drush/src/Runtime/Runtime.php(110):
Symfony\Component\Console\Application->run()
#18 /var/www/html/vendor/drush/drush/src/Runtime/Runtime.php(40): Drush\Runtime\Runtime->doRun()
#19 /var/www/html/vendor/drush/drush/drush.php(139): Drush\Runtime\Runtime->run()
#20 /var/www/html/vendor/drush/drush/drush(4): require('...')
#21 /var/www/html/vendor/bin/drush(119): include('...')
#22 {main}.
Error: Call to a member function getTimestamp() on null in
/var/www/html/web/core/modules/serialization/src/Normalizer/TimestampNormalizer.php on line 39 #0
/var/www/html/web/modules/contrib/smart_date/src/Normalizer/SmartDateNormalizer.php(40):
Drupal\serialization\Normalizer\TimestampNormalizer->denormalize()
#1 /var/www/html/vendor/symfony/serializer/Serializer.php(238):
Drupal\smart_date\Normalizer\SmartDateNormalizer->denormalize()
#2 /var/www/html/web/modules/contrib/smart_date/src/Normalizer/SmartDateItemNormalizer.php(45):
Symfony\Component\Serializer\Serializer->denormalize()
#3 /var/www/html/web/core/modules/serialization/src/Normalizer/FieldItemNormalizer.php(33):
Drupal\smart_date\Normalizer\SmartDateItemNormalizer->constructValue()
#4 /var/www/html/vendor/symfony/serializer/Serializer.php(238):
Drupal\serialization\Normalizer\FieldItemNormalizer->denormalize()
#5 /var/www/html/web/core/modules/serialization/src/Normalizer/FieldNormalizer.php(47):
Symfony\Component\Serializer\Serializer->denormalize()
#6 /var/www/html/vendor/symfony/serializer/Serializer.php(238):
Drupal\serialization\Normalizer\FieldNormalizer->denormalize()
#7 /var/www/html/web/core/modules/serialization/src/Normalizer/FieldableEntityNormalizerTrait.php(152):
Symfony\Component\Serializer\Serializer->denormalize()
#8 /var/www/html/web/core/modules/serialization/src/Normalizer/EntityNormalizer.php(59):
Drupal\serialization\Normalizer\EntityNormalizer->denormalizeFieldData()
#9 /var/www/html/vendor/symfony/serializer/Serializer.php(238):
Drupal\serialization\Normalizer\EntityNormalizer->denormalize()
#10 /var/www/html/web/modules/contrib/tome/modules/tome_sync/src/Importer.php(272):
Symfony\Component\Serializer\Serializer->denormalize()
#11 /var/www/html/web/modules/contrib/tome/modules/tome_sync/src/Importer.php(215):
Drupal\tome_sync\Importer->loadEntityFromStorage()
#12 /var/www/html/web/modules/contrib/tome/modules/tome_sync/src/Commands/ImportContentCommand.php(34):
Drupal\tome_sync\Importer->importContent()
#13 /var/www/html/vendor/symfony/console/Command/Command.php(279):
Drupal\tome_sync\Commands\ImportContentCommand->execute()
#14 /var/www/html/vendor/symfony/console/Application.php(1047):
Symfony\Component\Console\Command\Command->run()
#15 /var/www/html/vendor/symfony/console/Application.php(316):
Symfony\Component\Console\Application->doRunCommand()
#16 /var/www/html/vendor/symfony/console/Application.php(167): Symfony\Component\Console\Application->doRun()
#17 /var/www/html/vendor/drush/drush/src/Runtime/Runtime.php(110):
Symfony\Component\Console\Application->run()
#18 /var/www/html/vendor/drush/drush/src/Runtime/Runtime.php(40): Drush\Runtime\Runtime->doRun()
#19 /var/www/html/vendor/drush/drush/drush.php(139): Drush\Runtime\Runtime->run()
#20 /var/www/html/vendor/drush/drush/drush(4): require('...')
#21 /var/www/html/vendor/bin/drush(119): include('...')
#22 {main}
[warning] Drush command terminated abnormally.
Error Output:
================
As the meetings are largely async now.. Yes I should be able to
realityloop → created an issue.
Working on Drupal 11.0.4
Confirmed working for me
Works on my project
Working on my project
Working in my project
realityloop → created an issue.
realityloop → created an issue.
realityloop → created an issue.
I've just hit the same errors as @heddn
This change appears to be in place on 3.3.x-dev already now.
@Chandansha unfortunately I'm not sure the error will occur with every site, it was in the dblog with ours though.
realityloop → created an issue.
updated .ino.yml and composer.json to allow D11
realityloop → made their first commit to this issue’s fork.
realityloop → made their first commit to this issue’s fork.
realityloop → created an issue.
realityloop → made their first commit to this issue’s fork.