Drupal 11 compatibility fixes for fontyourface

To test Drupal 11, add the following to composer.json repositories

  "repositories": [
    {
      "type": "vcs",
      "url": "https://git.drupalcode.org/issue/fontyourface-3465748.git"
    },
...
  ],

and then run

composer require drupal/fontyourface:dev-3465748-drupal-11-compatibility

Gitlab ci file has been added manually or something so that its creation is a missing step in the change and is not registered as "new file" causing merge to fail with "file not exist". It wants to add the content to the file, but create the file. It assumes it exists already, which is not.

I get this error when trying the module for drupal 11:
Problem 1
- Root composer.json requires drupal/fontyourface dev-3465748-drupal-11-compatibility, it is satisfiable by drupal/fontyourface[dev-3465748-drupal-11-compatibility] from vcs repo (git https://git.drupalcode.org/issue/fontyourface-3465748.git) but drupal/fontyourface[dev-3.x, dev-4.0.x, 3.0.0-alpha1, ..., 3.x-dev (alias of dev-3.x), 4.0.0, 4.0.x-dev (alias of dev-4.0.x)] from composer repo (https://packages.drupal.org/8) has higher repository priority. The packages from the higher priority repository do not match your constraint and are therefore not installable. That repository is canonical so the lower priority repo's packages are not installable. See https://getcomposer.org/repoprio for details and assistance.

I've created a new patch to deal with Drupal 11 issues. Seems to work.

In Drupal 11.1 this line

$modules = \Drupal::moduleHandler()->hasImplementations('fontyourface_api');

causes an exception

\Drupal::$container is not initialized yet. \Drupal::setContainer() must be called with a real container.

Yes, I got that issue too actually. This re-roll handles that.

I don't think container is ever initialised in hook_module_implements_alter (), so I'm adding the list of modules where it is implemented.
I looked into other modules that implement the same hook and none of them are using Drupal container.
Added commit and ready for review.

Just wanted to mention that the patch in #9 worked for me during our migration from D10->11

patch #9 worked for me, fontyourface module is now installed and 'working'. But when I try to upload a custom font, I get the following error:

Drupal\Component\Plugin\Exception\PluginNotFoundException: The "file_validate_extensions" plugin does not exist. Valid plugin IDs for Drupal\Core\Validation\ConstraintManager are: Callback, Blank, NotBlank, Email, Choice, Image, Country, AddressFormat, BlockContentEntityChanged, SourceEditingRedundantTags, StyleSensibleElement, CKEditor5FundamentalCompatibility, CKEditor5MediaAndFilterSettingsInSync, CKEditor5EnabledConfigurablePlugins, CKEditor5ToolbarItemDependencyConstraint, UniqueLabelInList, CKEditor5ToolbarItem, SourceEditingPreventSelfXssConstraint, CKEditor5Element, CKEditor5ToolbarItemConditionsMet, CommentName, DateTimeFormat, FileExtension, FileIsImage, FileImageDimensions, FileSizeLimit, FileNameLength, FileExtensionSecure, FileEncoding, FileValidation, FileUriUnique, LinkExternalProtocols, LinkType, LinkNotExistingInternal, LinkAccess, oembed_resource, MediaMappingsConstraint, MenuTreeHierarchy, MenuSettings, PathAlias, TaxonomyHierarchy, UserName, UserCancelMethod, UserMailUnique, UserMailRequired, UserNameUnique, ProtectedUserField, ValidPath, UniquePathAlias, PluginExists, ReferenceAccess, ImmutableProperties, EntityChanged, EntityHasField, ValidReference, Bundle, EntityType, EntityUntranslatableFields, LangcodeRequiredIfTranslatableValues, ConfigExists, RequiredConfigDependencies, ExtensionName, ExtensionExists, Regex, UriHost, Length, FullyValidatable, Uuid, Null, PrimitiveType, ComplexData, Range, NotNull, AllowedValues, ValidKeys, Count, CountryCode, UniqueField, EntityBundleExists in Drupal\Core\Plugin\DefaultPluginManager->doGetDefinition() (line 53 of /home/ultrawel/public_html/core/lib/Drupal/Component/Plugin/Discovery/DiscoveryTrait.php).

Apparently file_validate_extensions() is deprecated in 10.2 and removed in 11, and we should use the 'file.validator' service instead.

I did find the likely offending reference to file_validate_extensions() in:

/public_html/modules/contrib/fontyourface/modules/local_fonts/src/Form/LocalFontConfigEntityForm.php where it says:

$form['font_file'] = [
      '#type' => 'managed_file',
      '#title' => $this->t('Font File'),
      '#description' => $this->t('The font file must be in WOFF format since that is accepted by all modern browsers.'),
      '#size' => 50,
      '#upload_validators' => [
        'file_validate_extensions' => ['woff'],
        'file_validate_size' => [Environment::getUploadMaxSize()],
        'file_validate_name_length' => [],
      ],
    ];

I'm not sure how to replace this with the file.validator service, but think this should become something like this

use Drupal\file\Validation\FileValidator;

// Font File
    $form['font_file'] = [
      '#type' => 'managed_file',
      '#title' => $this->t('Font File'),
      '#description' => $this->t('The font file must be in WOFF format since that is accepted by all modern browsers.'),
      '#size' => 50,
      '#upload_validators' => [
        // Validate file extensions using file_validator
        [$this->fileValidator, 'validateExtensions'] => ['woff'],
        // Validate file size
        [$this->fileValidator, 'validateSize'] => [Environment::getUploadMaxSize()],
      ],
      '#required' => TRUE,
    ];

all expert advice and code adjustment very welcome!

xax, great, can someone please add this deprecated validation fix into a merge request! This prevents D10.4 and D11.1.x installs from using this module

The required fix (code) is described in comment #12. There is a deprecated form validator to replace.

As per Upgrade status module - I see some more issues for Drupal 11 Compatibility

Please verify

CONTRIBUTED PROJECTS
--------------------------------------------------------------------------------
@fontyourface
Scanned on Sat, 03/29/2025 - 07:03.

web/modules/contrib/fontyourface/fontyourface.module:
+--------+------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| status | line | message |
+--------+------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Ignore | 442 | Fetching deprecated class constant EXISTS_REPLACE of
interface Drupal\Core\File\FileSystemInterface. Deprecated
in drupal:10.3.0 and is removed from drupal:12.0.0. Use
Drupal\Core\File\FileExists::Replace instead.
|
+--------+------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
web/modules/contrib/fontyourface/modules/fontscom_api/fontscom_api.module:
+--------+------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| status | line | message |
+--------+------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Ignore | 156 | Fetching deprecated class constant EXISTS_REPLACE of
interface Drupal\Core\File\FileSystemInterface. Deprecated
in drupal:10.3.0 and is removed from drupal:12.0.0. Use
Drupal\Core\File\FileExists::Replace instead.
|
+--------+------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
web/modules/contrib/fontyourface/modules/fontsquirrel_api/fontsquirrel_api.modul
e:
+--------+------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| status | line | message |
+--------+------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Ignore | 63 | Fetching deprecated class constant EXISTS_REPLACE of
interface Drupal\Core\File\FileSystemInterface. Deprecated
in drupal:10.3.0 and is removed from drupal:12.0.0. Use
Drupal\Core\File\FileExists::Replace instead.
|
| Ignore | 71 | Fetching deprecated class constant EXISTS_REPLACE of
interface Drupal\Core\File\FileSystemInterface. Deprecated
in drupal:10.3.0 and is removed from drupal:12.0.0. Use
Drupal\Core\File\FileExists::Replace instead.
|
+--------+------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
web/modules/contrib/fontyourface/modules/local_fonts/local_fonts.module:
+--------+------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| status | line | message |
+--------+------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Ignore | 115 | Fetching deprecated class constant EXISTS_REPLACE of
interface Drupal\Core\File\FileSystemInterface. Deprecated
in drupal:10.3.0 and is removed from drupal:12.0.0. Use
Drupal\Core\File\FileExists::Replace instead.
|
| Ignore | 116 | Fetching deprecated class constant EXISTS_REPLACE of
interface Drupal\Core\File\FileSystemInterface. Deprecated
in drupal:10.3.0 and is removed from drupal:12.0.0. Use
Drupal\Core\File\FileExists::Replace instead.
|
+--------+------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+