- Merge request !9Issue #3217393: Add permission for showing only the secondary toolbar → (Open) created by dieterholvoet
- 🇨🇦Canada Nathan Tsai
Snapshot for !9 for commit 3a3c6dd7 (using the proper patch)
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
Liam Morland → made their first commit to this issue’s fork.
- Status changed to Needs review
about 1 year ago 5:19pm 8 March 2024 - 🇮🇳India anchal_gupta
Verified the issue on 10.x-dev.
Steps to be followed to verify the issue.
Steps1: Install and enable gin theme.
Steps2: Install and enable Gin toolbar module.
Step3: Applying the MR!9.Permissions was not there before applying the MR!9.
After The MR!9 permission for showing both the toolbar . I suggest move this issue to RTBC
Attached screenshots for reference.
manibharathi ezhimalai ravi → made their first commit to this issue’s fork.
- Merge request !50Issue #3217393: Add secondary toolbar permission → (Open) created by manibharathi ezhimalai ravi
Hi,
For fixing the conflicts created the separated branch from the issue fork. Changes are working as expected in the MR !50.New permissions are added for the access the toolbar.
- 🇬🇧United Kingdom scott_euser
Thanks for the work on this!
- The latest branch with commits has merge conflicts, ie, 3217393-add-permission-for
- There seem to be multiple branches: the other branches that are unused should be hidden
- I believe we should also have an update hook so the status quo is maintained for users. Ie, if we previously expected users with 'access toolbar' to have access and all of a sudden they don't, we cause a problem updating. So we should loop through roles and grant primary & secondary permission to any role that currently has 'access toolbar'
- 🇧🇪Belgium dieterholvoet Brussels
@manibharathi ezhimalai ravi no need to start a new MR, you can get access to the existing one by clicking the button. I'll rebase !9 and close !50.
- 🇧🇪Belgium dieterholvoet Brussels
dieterholvoet → changed the visibility of the branch 3217393-add-secondary-toolbar-permission to hidden.
- 🇧🇪Belgium dieterholvoet Brussels
dieterholvoet → changed the visibility of the branch 3217391-secondary_toolbar_perm to hidden.
- Status changed to Needs work
5 months ago 11:49pm 4 December 2024 - 🇺🇸United States MegaKeegMan
I am testing out MR 9 against 10.3 and unable to make it so that someone of a certain role can only get access to the secondary toolbar, and not the primary one.
I tried with and without the MR in the associated gin issue: https://www.drupal.org/project/gin/issues/3217391 ✨ Add permission for showing only the secondary toolbar Closed: won't fix
I did make sure that my role was given the access toolbar permission, as well as the access secondary permission, but they were still unable to see the secondary menu. I am only able to get them to see it when they also have the access primary permission.