🇮🇳India @gg24

gargsuchi → credited gg24 → .

gargsuchi → credited gg24 → .

gargsuchi → credited gg24 → .

gargsuchi → credited gg24 → .

The latest patch is also not working. Sorry to not add the screenshot before.

It seems the patch it not getting applied to latest version 2.2.2

This needs a re-rolled patch.

gargsuchi → credited gg24 → .

Re-rolled the patch with the latest stable module release. Please review.

gargsuchi → credited gg24 → .

gargsuchi → credited gg24 → .

Re-rolled the patch.

Please review.

gg24 → created an issue.

Updated the re-rolled patch.

Re-rolled the patch. Please review.

Uploading a new working patch.

I have created a new patch. The above patch didn't get applied for me.

Please review.

I have created a new patch. The above patch didn't get applied for me.

Please review.

I see that a commit for 10.3 is being added in the same patch where we are handling the issue for dev module incompatibility. IMHO this should have been handled in the separate issue.

Hence, I am re-rolling a patch for 10.2 Drupal version.

Thanks!

gargsuchi → credited gg24 → .

Please review the patch.

gg24 → created an issue.

I verified the PR and tested it for Problem defined in the issue. Looks great.

All works as expected. Coding standards also looks good. I have ran rector and no errors reported.

Moving this to RTBC.

Thanks!

The latest MR and patch looks good. I tested it locally and applied rector as well. No new changes. All works fine and compatible with D11. Hence moving it to RTBC.

Thanks!

gg24 → made their first commit to this issue’s fork.

This issue is not reproducible anymore and the class mentioned is not needed to be imported anymore in the mentioned classes. Hence closing this issue. Feel free to reopen the issue if needed.

Thanks!

I verified this as per the steps mentioned to reproduce and able to replicate the problem. The patch provided above works as expected and I am able to clone and hit save without having any issue due to mandatory fields. This looks good. Hence moving this to RTBC.

Patch applies beautifully.

Thanks!

gg24 → made their first commit to this issue’s fork.

The issue still exists. I am checking in Drupal 10.2.6. I am reopening this issue.

I have fixed some of the logic and refactored the code. There is still scope of refactorisation. Please review.

Thanks!

gg24 → made their first commit to this issue’s fork.

The testing is done and patch provided looks good to me. I can confirm the code works fine after making this change.

Moving this to RTBC.
Thanks!

It's been a while this ticket is hanging there, I have included these changes to https://www.drupal.org/project/coffee/issues/3428399 📌 Automated Drupal 11 compatibility fixes for coffee RTBC , we can close this issue now.

Please suggest.
Thanks!

This looks good to me, no errors reported.
Moving to RTBC.

Thanks!

Please review the PR. I have also fixed some coding in the same PR. Rest all looks to me in the PR.

gg24 → made their first commit to this issue’s fork.

Please review the PR. I have also fixed some coding in the same PR. Rest all looks to me in the PR.

gg24 → made their first commit to this issue’s fork.

I think this can be closed as suggested above by @mandclu. Hence I am closing this issue. Feel free to reopen it if needed.

Thanks!

Looks good to me.

RTBC.

fubarhouse → credited gg24 → .

gargsuchi → credited gg24 → .

gargsuchi → credited gg24 → .

gargsuchi → credited gg24 → .

gargsuchi → credited gg24 → .

gargsuchi → credited gg24 → .

gargsuchi → credited gg24 → .

gargsuchi → credited gg24 → .

gg24 → created an issue.

gg24 → created an issue.

gargsuchi → credited gg24 → .

gargsuchi → credited gg24 → .

gargsuchi → credited gg24 → .

gargsuchi → credited gg24 → .

gargsuchi → credited gg24 → .

gargsuchi → credited gg24 → .

gargsuchi → credited gg24 → .

I tested it thoroughly.

I don't find any issues here.

When we enable Captcha and below checkboxes

• Add CAPTCHA challenges on all forms
• Additionally add CAPTCHA challenges on admin forms
• Add CAPTCHA administration information to forms
• Additionally add administration informations on admin pages

Only users without Skip CAPTCHA the permission seems the Captcha.
If we give the extra permission Administer CAPTCHA settings to any user along with Skip CAPTCHA then they see the field-set which says CAPTCHA: challenge "default" enabled which shows the details for the enabled captcha and related links. This is same for admin and other roles.

Hence I am closing this issue.

Feel free to re-open the issue if incase the above mentioned points are not explanatory enough.
If I am not able to understand the issue here, please explain a bit more here.