Allow group admins to create user account and add to group

Hello,
I'm interested by this feature, is it possible to update the patch for the latest version of the group module ?

Hello Mr.Valters

That patch that you shared yesterday can be used for 3.2.0 and 2.2.0?

@mr.valters could you share some information why there is a need for a new patch? And could you also provide an interdiff so maintainers and others can review what is changed?

Interdiff provided for 43 and 51. But without any comment this is not useful and going to hide the patch. Feel free to unhide patch when there is more info.

After applying #43 patch file with 8.x-1.6 version, getting error on user register page(admin/people/create).

Drupal\Core\Database\InvalidQueryException: Query condition 'group_content_field_data.entity_id IN ()' cannot be empty. in Drupal\Core\Database\Query\Condition->condition() (line 106 of /var/www/html/docroot/core/lib/Drupal/Core/Database/Query/Condition.php).

Updated patch to support 8.x-1.6 and now I am able to create/edit user without any error.

@ramreddy.kancherla I'm not experiencing the same issue. But could you please create an interdiff? It is impossible to review your patch now.
And what version of Drupal are you using?

@tim-diels
Drupal version is : 10.1.4
Below is the interidff:

--- <unnamed>
+++ <unnamed>
@@ -221,7 +221,7 @@
 +  // Status in user add/edit from group.
 +  if ($field_definition->getName() == 'status' && $items->getEntity()->getEntityTypeId() == 'user') {
 +    $entity = $items->getEntity();
-+    if (!$entity->isAnonymous()) {
++    if ($entity->id() && !$entity->isAnonymous()) {
 +      $group_content_entities = \Drupal::entityTypeManager()->getStorage('group_content')->loadByProperties(['entity_id' => $entity->id()]);
 +      foreach ($group_content_entities as $group_content) {
 +        // Allow if can edit any.

Do any of these patches work on 2.2.1?

Is it possible to update the patch for the latest version of the group module?

Interdiff for #43 to #56 looks good.

@mr.valters please stop spamming this issue with only patches and no comments. This is really not helping for anyone reviewing this issue.
Also, #56 fixes your issue normally.

After many said #43 was working and #56 only has one logical addition, going to hide all other patches. Feel free to disagree and reshow patches or discuss.

Some asked to make this 2.2.x or higher available, but this will be a big job as the architecture of the module changed a lot.
We probably need the help of a maintainer to fix this or anyone with some time to be willing to port this to > 2.2.x.

I’m currently using the ginvite → module with success. What would this patch seek to provide that isn’t already covered by this module? Would it be better to support Ginvite with a view to future integration in the Group module?

@markdc
The ginvite module provides a workflow for inviting new users to a group.
But this patch provides a way to create a new group user. Not add an existing one as a member, do not invite it, but create a new one and add it to the group.
I've seen already 2 sites where such behavior is required. Where the site doesn't have a default registration form. Only group admins manage who must be invited (which means creating a new user and making it a group member) or excluded from the group.

It seems the patch it not getting applied to latest version 2.2.2

This needs a re-rolled patch.

The latest patch is also not working. Sorry to not add the screenshot before.

Noting that the patch from #56 ✨ Allow group admins to create user account and add to group Needs work addresses a core change to User::isAnonymous affecting core 10.1+. See 📌 Safeguarding against UnblockUser::execute()'s method unblocking the anonymous user Fixed .

The "most-proper" fix would have been to call EntityInterface::isNew but this is essentially the same, just some duplication of logic that already exists in core.

Confirming that the patch still applies to 8.x-1.6 and works as expected.