🇧🇪Belgium @tim-diels

Ok then we can set this to needs review. Thanks.

Needs to be done for 2.x also.

tim-diels → created an issue.

Tested both on D10 and D11 and works.

There is however a problem that also exists in D10 already that the checkbox is not styled correctly but that has nothing to do with this MR.

Tests are failing :(

I'll update the code to fix the comments

tim-diels → made their first commit to this issue’s fork.

Can be tested once 📌 Add GitLab CI configuration Active is merged so pipelines are activated, but already provided the fixes.

Can be tested once 📌 Add GitLab CI configuration Active is merged so pipelines are activated, but already provided the fixes.

Created 2 subtasks. One for CSpell and one for PHPCS. PHPStan will solve itself when the Drupal 11 compatibility is merged.

tim-diels → created an issue.

tim-diels → created an issue.

tim-diels → created an issue.

Removed the backwards compatibility stuff as thats not needed when adding a version constraint.

Tested this both on 10.x and 11.x and words as expected.

Can we please get this committed?

tim-diels → made their first commit to this issue’s fork.

tim-diels → made their first commit to this issue’s fork.

tim-diels → created an issue.

Please provide a MR for this so this will run the pipelines.

Adding ddd2025 tag

The provided code did so much more then just a simple check. I switched the url and text overrides and in only did the text override when the use_more option is TRUE.

Hmm on a second thought I'm not going to change this now.

Thanks for this Liam. It works as expected.

tim-diels → created an issue.

I'll have a look at this.

tim-diels → created an issue.

tim-diels → made their first commit to this issue’s fork.

Looks like this is an outdated issue as the code has been changed to handle this. Closing.

Issues are resolves in the other ticket. Thanks for that.

tim-diels → created an issue.

tim-diels → created an issue.

Thanks fore the contribution! I'll have a look.

tim-diels → created an issue.

You're correct, lets commit this.

Thank you both for the contribution. Lets get this merged in.

Hi Fabio, thanks for the report. Looks good to me.

We need better steps to reproduce the issue as its unclear for me what you did.
Can you please provide better steps to reproduce?

I'd like to see a failing test for this so we can make sure the provided fix will stay fixed.

I'd like to see a failing test for this so we can make sure the provided fix will stay fixed.

We're not supporting the 7.x branch anymore. So closing the issue.

I really like the idea of having a filter for current domain.

Having a tab for all the assigned domains will have a performance issue I think and will be unmanageable when having a lot of domains.

I'm happy to review any provided MR but won't have the time myself to build it.

Added tests, test is failing on drupal 11.x because of domain needing a new release. But that does not need to block us.

tim-diels → made their first commit to this issue’s fork.

Closing this as outdated and we're using a different approach now.

Added tests, test is failing on drupal 11.x because of domain needing a new release. But that does not need to block us.

Looks like the issue in domain is already tackled, see 📌 Add function return type for DomainTestBase::drupalUserIsLoggedIn Active . Domain just needs a new release.

Test fails on Drupal 11.x because of

PHP Fatal error: Declaration of Drupal\Tests\domain\Functional\DomainTestBase::drupalUserIsLoggedIn(Drupal\Core\Session\AccountInterface $account) must be compatible with Drupal\Tests\BrowserTestBase::drupalUserIsLoggedIn(Drupal\Core\Session\AccountInterface $account): bool in /builds/project/domain_access_logo/web/modules/contrib/domain/domain/tests/src/Functional/DomainTestBase.php on line 203

So have to look into domain module itself to see if that can get fixed there. But for me everything else is working as it should be and this test will help in 1 of the error cases. If someone feels like writing a test for actually uploading the file would be very nice! Leaving this open for a while and if no one picks it up, we'll create a follow up issue for that.

Updated Drupal version constraints because of deprecations in code.

And PHPCS failed.

This issue report is far from a good error report. It does not contain the drupal version, the version of the module at the moment the error appeared.

I can however confirm there is an issue when using the module in Drupal 11.x with deprecated code. Sorry for that.
I'm going to test this on a Drupal 10.x site and a Drupal 11.x site and see if everything in the MR works.
I'll report back later if I found the time.

Of if anyone finds the time to test both versions, feel free to provide the reports.

Closing as there is no reaction for more than 2 months.

Ooh thanks a lot for the release! Much appreciated! If I can find some time, I'll add some documentation issue. but good for now to be able to install it.

tim-diels → created an issue.

tim-diels → created an issue.

It's suggested to use MR as this will trigger the GitLab pipelines. I've just added the patch as is from #12
But could not get it to work. I did misread what I needed and not going to continue to assist here as this is not what I was needing.
Sorry for the noise.

tim-diels → made their first commit to this issue’s fork.

Added the code from the latest comment as a MR as this worked for me.

tim-diels → changed the visibility of the branch 3.x to hidden.