Gin theme compatibility

Created on 12 June 2023, about 1 year ago
Updated 16 April 2024, 2 months ago

Problem/Motivation

Form mode manager module allows to edit entities on different from modes.
It seems to have some issues when used with the gin theme:
- The "Show/Hide sidebar panel" functionality seems broken. The sidebar is under the form.
- Some from elements have white background when using the dark theme.

Steps to reproduce

Proposed resolution

1 Explain how to integrate the sidebar into a custom form.
2 Explain why .entity-meta__header remains white on dark gin theme.
3 Improve gin css selectors if possible
4 Move the ticket to form_mode_manager with the explanation

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Active

Version

3.0

Component

Code

Created by

🇭🇺Hungary Pasqualle 🇭🇺 Budapest

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Pasqualle
  • 🇭🇺Hungary Pasqualle 🇭🇺 Budapest

    It seems implementing hook_gin_content_form_routes() solves the problem.

    Please register all the new routes with this hook.

    As a quick workaround, the hook can be used in a custom module as:

    function mymodule_gin_content_form_routes() {
      return [
        'entity.node.edit_form.myformmode',
      ];
    }
    
  • First commit to issue fork.
  • Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update about 1 year ago
    Not currently mergeable.
  • @chester_ opened merge request.
  • Status changed to Needs review 2 months ago
  • 🇮🇹Italy kopeboy Mainland

    Thank you, this works while editing entities, but there is still a problem when using /node/add-list/[CUSTOM_FORM_MODE] (which is problematic on its own and I'm trying to get rid of anyway, at least of the button links at /admin/content 😇

  • Status changed to Active 2 months ago
  • 🇮🇹Italy kopeboy Mainland
Production build 0.69.0 2024