Can you share that code please? 🙏🏻
I think the most important would be link fields:
- having the option to show the link under the code would be great, so thatusers with the scanning device can scan it, but others (say mobile phone users, when showing a QR code) may directly click the link to reach the same destination;
- having the option to use custom protocols (for deep links) would be great too, ie. not only https:/ but myapp:/ or any other (whitelisted from settings maybe) open source protocol
I even tried disabling verification on each link decorator setting, without success, but I guess the field formatter setting should override the setting at each decorator, right?
kopeboy → created an issue.
I would expect the problem to go away after disabling the verification from the field formatter, but on every link field save the page takes ages to load and will again show the errors. Why is that? I even tried removing the verification checkbox on the modules settings for each social network, but the problem stayed. Should I open another issue?
I guess being able to reset passkeys is necessary for a release?
I tried with a different variation of ECA model as well, ie. I replaced the action to set the order token manually with one that loads the entity by Type & ID (selection Order entity type), but nothing changed.
Maybe we can take inspiration from this module: direct_checkout_by_url
This is the ECA model with which I'm trying. I just set up a Commerce store and a single product with 1 variation with sku "VAR1".
Nothing happens when I run the custom ECA event from the command line..
Can you provide a working example ECA model? Cause I couldn't get this to work and I'm not receiving any error messages
Last commit seems wrong: both
"drupal/draggableviews": "^3.0", and
"drupal/form_mode_control": "^3.0", don't seem to exist.
Shouldn't they both stay at ^2.1?
Is using a Service worker with Drupal something a curious Site builder can do though?
Does this mean that recipes can now be applied successfully on the command line, even if the configuration they include isn't actually applied to the site? How would a site builder identify pre-existing configuration issues and distinguish them from problems with the recipe itself?
FYI I noticed that the latest version of this module (v4, now stable) doesn't have this issue.
kopeboy → created an issue.
I just installed this module (version 8.x-7.1) on Drupal 10.3.6 and I can't reproduce this. I can create new content with the faq field empty and no error nor any field artifact will show up in the saved content.
Are you sure your field doesn't have the "Required field" option enabled in its field settings, nor the "Required Field Question" and "Required Field Answer" checkboxes in the field formatter options (at Manage Form Display)?
@sebastian-hagens: I know, you can see it even in my screenshot..
I had the subscriptions and I had run cron, but no DANSE events nor notifications were being created & sent.
I don't think you need this with CKEditor 5, as it supports inline code out-of-the-box (without adding any plugin/button/configuration): install a fresh Drupal 10 site and type `text` (the backtick) in any CKEditor textarea to see the text wrapped in <code>.
Looks nicer, but the old (horizontal) admin_toolbar is faster. I would like an horizontal option.
Since we are here (😅😇).. I noticed that the relevant CSS is not applied to the front-end theme, ie. when there is no CKEditor active on the page..
so shouldn't we remove the .ck-content class prefix from this CSS below, to make it look good out-of-the-box everywhere?
.ck-content .todo-list .todo-list__label .todo-list__label__description {
vertical-align: middle;
}.ck-content .todo-list {
list-style: none;
}
The margins top & bottom instead are irrelevant as a frontend theme will always have them already on lists (so I wouldn't touch all other CSS), but the margin-left is needed and missing from the frontend (see below), so I would add margin-left: 1ch; to the first declaration above (without the .ck-content class prefix).
AS IS while editing (with Claro default theme):
AS IS while viewing (with Olivero default theme):
TO BE while viewing (with Olivero default theme and the edits I described):
Yep, that worked, thanks!
Sorry, I didn't even now what "inject services in the class constructor" meant 😅😇, so I asked ChatGPT and tried to provide a new MR accordingly.
That worked! I didn't know about the configure key in the module.info.yml file, thanks!
I'm getting a warning by phpcs: Undefined method 'getEntity' (with and without the patch).
I don't have a use case in mind but it works fine 😇
A standard composer require won't work even with those linked projects.. Seeing from their README there are many steps to do 😅 And if they are correct, maybe they should be added to this module's README?
#2: I know, I was asking why they are unnecessary..
#3: thank you.. even if I'm not sure this module would actually improve in those 3 dimensions (see below), could this info be added to the module page or README?
- SEO: got some resources to share?
- Performance: you are altering/unsetting something that was already processed
- Privacy: could you provide some examples?
Thank you 🙏🏻
Thank you!
Yep, patch in #60 worked, and didn't seem to break anything! Thank you all!
Yep, that worked, thank you!
To @sebastix: no, the issue is unrelated to pwa or advanced_pwa: I was just noting that the latter includes web push notifications and has a submodule specifically to correctly remove that feature.
To @ nk_: Unfortunately I had already Deleted the service worker and removed the test site, so I can't Unregister the service worker now because I don't see it anymore (as well as the error logs). At least this also means the original issue got fixed by itself, maybe Chrome just needed some time?
The big red "Unlock" button is supposed to clears service workers & subscriptions? It doesn't seem so, cause I've just reinstalled a new site with DANSE, push_framework, this module, registered a new key & service worker and subscribed myself with DANSE, but after clicking it, I can still see my subscription at /admin/reports/push-subscriptions, as well as the service workers in the Chrome console.
Regarding DANSE.. how to check the subscriptions? I don't see anything in the provided /admin/reports/danse, that's why I thought DANSE events are not even fired.
I had already given the instructions to reproduce! But here it's an even simpler one:
- Install a standard Drupal 10.3.6 site (I used DDEV & drush with
ddev drush si - Require & enable this module
ddev drush composer require drupal/tour - Check that there is a tour that should show up on Tour edit pages (
/admin/config/user-interface/tour/manage/tour_edit) - Go to edit itself or any other tour, eg:
/admin/config/user-interface/tour/manage/tours] - Click on the "No tour" button in the toolbar to start the tour
You can see the same problem on all 3 of the default tours provided, as well as new tour you might create, as I said in #1.
The problem is with the toolbar module and not with the navigation module. Just enable it and repeat the last 2 steps to see the problem "fixed".
Yep, that fixed it, thanks!
What do you mean with a ticket? From who?
Clear, thank you!
We should also support Drupal 11 since we're at it, please.
..or even a dependency on jquery_ui_slider module?
I confirm the issue and that that patch solves it. Please include in a release.
The difference is that with this you have the option to only edit the field if it didn't have a value (which is a condition that you could copy in a VBO action only with custom code, or by using eca_vbo module), and the benefit of not having to filter and select the entities to update: you automatically update all the entities that have that field, directly from the field settings form, so I would say it's pretty convenient for this specific use case, ie. when modifying the structure of your site (more specific than with VBO).
I think the feature is already available here: https://www.drupal.org/project/eca_condition → ☺️
I'm not the maintainer but I just installed the module on Drupal 10.3.6, with admin_toolbar disabled, and I didn't get any warnings or errors.. the module seems to be working fine (not with the new core's nagivation module though).
Could you provide the steps or some details on how to reproduce the errors?
kopeboy → created an issue. See original summary → .
Yeah, here it is. I'm still a noob at this.. is there a way to open an issue fork and propose a MR before opening the issue on Drupal.org?
My bad, this was intended for the tour_core project.
Actually, I think this is breaking danse module.
Even after uninstalling this module and the whole push_framework, and deleting the service worker from my Chrome developer tools (under the Application tab), I still get the same warning but only when a new DANSE notification is triggered. I suspect this is the reason the notification doesn't get created at all.
kopeboy → created an issue.
I should point out that instead it works as expected if the (core experimental) navigation module is enabled, both with and without the toolbar module enalbed (which should be superflous once navigation is used).
No error in the logs nor in the browser console whatsoever, using Chrome on macOS.
kopeboy → created an issue.
I confirm the issue is still present, and even changing the annotation of web/modules/contrib/contact_formatter/src/Plugin/Field/FieldFormatter/ContactFieldFormatter.php to "entity_reference:contact_message" doesn't work (all options other than just entity_reference are just removing the formatter.
This might be the solution: https://drupal.stackexchange.com/questions/233862/limit-entity-reference...
Yep, and the problem is not only that the fieldset or details element are not collapsible, the fields inside are completely missing!
v9.3 to v11, which are the versions that really matter for modules to be built with the new APIs, already count ~370k sites, ie. the majority, more than the rest (v6 to v9.2).
To update costs time and/or money, especially if you need a different module and content wasn't already easily exportable with JSON or CSV in their older versions. Drupal Association should lead by example and finally migrate Drupal.org and produce documentation while doing it. Just filming the process and making a timelapse with a transcript would be great imo.
What is holding Drupal back regarding extensibility & integrations lately imo is the difficulty in working with Javascript & using the features on the client's browser. There are plenty of useful FLOSS libraries on Github but I don't know how to plug them.
He wanted simplicity with Wordpress and you talk him into Symfony? 😅
I think that once you get a grip of all the good modules supporting Drupal 10 & 11 out there (it takes a long time to find all the good ones), as a site builder you will get infinite powers on Drupal, all absolutely for free. Even the upgrading/deployment part nowadays is much easier thanks to automatic updates, DDEV and its integrations with hosting providers. It just takes longer to learn, but that is also changing thanks to recipes now, and Drupal CMS. Have you had a look into those?
When I try to save an Address format from the manage display page, I get redirected to a weird blank page.
When I edit it from /admin/config/address-formatter is fine though..
So it could be that this is caused by CKEditor, but I'm not sure.
For sure adding a plain text option wouldn't hurt.
I don't know why but applying the patch with composer failed:
Cannot apply patch https://drupal.org/i/3474987 ( https://www.drupal.org/files/issues/2024-09-18/address_formatter_depreca... → )!
Applying it manually removed the error instead, so... RTBC
Btw, I noticed many warnings in my IDE.. for example at line 81 (right after what we are changing with this patch) I see:
...so probably we could do a better job in a future version.
I second catch, regardeless of the version, knowing which other modules are related is useful, both dependants and required (on which the module depends).
Any core action will be picked up by ECA.
I don't have a Slack server to try but the patch seems good?
Maybe a doubt about token substitutions: I'm not sure if ECA will automatically apply substitutions or you need to do it in your action code, but it the latter case, I would allow even the channel and user to be tokenized.
If the module code was posted to Packagist.org (as it should, since composer is looking there), you can find all its dependents (ie. all the packages that list the subject module as dependencies in their `composer.json` file) at https://packagist.org/packages/[package_name]/dependents
..where [package_name] for Drupal modules (at least those shared on Drupal.org) should always start with "drupal/", for example, find dependents of the Admin Toolbar module with:
https://packagist.org/packages/drupal/admin_toolbar/dependents?order_by=...
I'm on Drupal
Mm.. I think it can be JS on the client side, at least for the simpler Notifications API.
The more complicated Push API requires a service worker, but that's something advanced_pwa module already provides.
I opened an issue there: ✨ Allow integration with ECA and Push framework Active
Oops, I had this form open but couldn't remember I had already opened an issue on this. Will follow up there, sorry.
When visiting the entity form with the user reference field, with the new core option that excludes blocked users, I got these:
2 Warnings:
Undefined array key "dependent_fields_view" in dependent_fields_field_widget_single_element_form_alter() (line 58 of /var/www/html/web/modules/contrib/dependent_fields/dependent_fields.module)
Message Warning: Trying to access array offset on null in Drupal\dependent_fields\Plugin\EntityReferenceSelection\ViewsSelection->getReferenceableEntities() (line 523 of /var/www/html/web/modules/contrib/dependent_fields/src/Plugin/EntityReferenceSelection/ViewsSelection.php)
1 fatal error:
TypeError: Symfony\Component\HttpFoundation\Request::get(): Argument #1 ($key) must be of type string, null given, called in /var/www/html/web/modules/contrib/dependent_fields/src/Plugin/EntityReferenceSelection/ViewsSelection.php on line 647 in Symfony\Component\HttpFoundation\Request->get() (line 700 of /var/www/html/vendor/symfony/http-foundation/Request.php).
When
kopeboy → created an issue.
The fix had not been included in core yet!
I applied the rerolled patch in #39, which still applies cleanly even to Drupal 10.3.6, and it worked fine, it just needs some clarification in the field help text imo..
When creating Entity reference fields on Users, this becomes the default:
You would assume from the description that the checked option will make users without the 'administer users' permission able to select blocked users. The opposite is true: the checked option, ie. by default, leaves core behaving like currently (you can't select blocked users unless you have the 'admin users' perm), but if unchecked it hides the blocked users on that field even to roles with the 'aminister users' permission.
So the feature is consistent with the original request, but we can improve the intuitiveness by reverting the label & description:
[ ] Exclude blocked users (unchecked by default - also, leave the "Include the anonymous user." as independent of this option)
Even if this option is not set, only users with the administer users permission may (view and) reference blocked users.