- 🇺🇸United States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.
CI failures in the last few patches.
Such a feature will need a change record.
Curious though if we are auto creating any kind of entity reference. What happens if it's a reference to, say articles, how is it auto creating articles?
- First commit to issue fork.
- Merge request !4410Issue #2800875: Autocreate for Entity Reference selection handlers that extend ViewsSelection → (Open) created by narendraR
- last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago 29,821 pass, 2 fail - last update
over 1 year ago 29,827 pass - Status changed to Needs review
over 1 year ago 9:55am 20 July 2023 - Status changed to Needs work
over 1 year ago 2:36pm 25 July 2023 - 🇺🇸United States smustgrave
Cleaning up credits for bad rerolls
CR looks good.
Tested this out on a Umami Install, since that's what I had running
Created an Entity Ref view that searches for Tags title and filters by just Tags taxonomy vocabulary
updated Article content type to use new handler.
Created an Article and added "This is a test" to the tags field
It was created BUT it was added to the wrong vocabulary. Was added to Recipe category not tags - Status changed to Needs review
over 1 year ago 3:08pm 25 July 2023 - 🇮🇳India narendraR Jaipur, India
Hi @smustgrave, Thanks for the review.
Created an Article and added "This is a test" to the tags field
It was created BUT it was added to the wrong vocabulary. Was added to Recipe category not tagsThis might be because Store new items in might be selected as Recipe on the created field. If this is not the case, can you please provide a screen recording so that I can reproduce the steps?
- Status changed to RTBC
over 1 year ago 5:09pm 31 July 2023 - 🇺🇸United States smustgrave
Retested on a fresh install and seems to be adding to the correct vocabulary now.
- last update
over 1 year ago 29,912 pass - last update
over 1 year ago 29,947 pass - last update
over 1 year ago 29,954 pass - last update
over 1 year ago 29,954 pass - last update
over 1 year ago 29,954 pass - last update
over 1 year ago 29,959 pass - last update
over 1 year ago 29,959 pass - last update
over 1 year ago 29,960 pass - last update
over 1 year ago 29,968 pass - last update
over 1 year ago 30,050 pass - last update
over 1 year ago 30,057 pass - last update
over 1 year ago 30,057 pass - Status changed to Needs work
over 1 year ago 5:36am 24 August 2023 - 🇳🇿New Zealand quietone
I'm triaging RTBC issues → .
I read the issue summary and then the comments. I then read the change record and scanned the patch. I have found some more things to do here which I will list below.
But first, thanks for working on this, it does look like a handy feature!
- This is adding to the UI, therefor adding 'usability' tag
- The proposed resolution has not been updated since this issue was created and there was a change to the approach in #54/#55. That should be checked.
- The points raised in #60 have not been addressed.
- #61 points out a change of behavior. I checked the change record and it is not discussed there. The change of behavior should be added there, perhaps in before/after sections. How disruptive is this change?
- Sadly, I don't see that there has been a code review since #60. There were a lot of rerolls after that but quite a few do not have interdiffs
- The term 'autocreation' is used throughout the MR but it is not an English word so should be changed. It is not identified because it appears in the core list of misspelled words in core. And there is an issue to correct all the spellings and remove that list.
- I think the change record needs a more informative title and that the CR itself can be made easier to understand. It should explicitly how/where to use this new feature. That is, that it when adding a reference field to an entity. The screenshot is helpful but I wasn't sure what is new about it. It is just the addition of the new option? Does selecting the option then offer more fields? I also am not sure what 'new referenced entities with title will be created" means. There is some help for this, Write a change record for a Drupal core issue → .
- last update
over 1 year ago 30,056 pass, 1 fail - 🇳🇿New Zealand quietone
I made a few tweaks to the MR but it still needs work.
I changed the MR to avoid spelling errors and sorted use statements in one file.
- last update
over 1 year ago 30,056 pass, 1 fail - 🇳🇿New Zealand quietone
There is one test file changed here, \Drupal\Tests\field\Functional\EntityReference\Views\SelectionTest. It adds the test module, 'views_entity_test'. However, if the line is removed the test still passes.
And related to that, what is the purpose of the duplicate plugin in, \Drupal\views_entity_test\Plugin\EntityReferenceSelection\TestViewsWithAutoCreateSelection?
This all make me think the question raised in #58.5 about testing, and answered in #59.5, needs to be looked into again. And a fail test will be needed here as well. If I knew more about views testing I would offer a suggestion.
Adding tags I should have done earlier.
- First commit to issue fork.
- last update
over 1 year ago 30,061 pass - last update
over 1 year ago 30,137 pass - last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago Custom Commands Failed - last update
10 months ago Custom Commands Failed - Assigned to tobiasb
- Issue was unassigned.
- Status changed to Needs review
8 months ago 12:01pm 5 May 2024 - 🇩🇪Germany tobiasb Berlin
I added a new constraint AutoCreateEntityBundleExists; but I have no idea how to test it on the drupal way. I know there are other constraints, but their looks easier.
- Status changed to Needs work
7 months ago 11:07pm 19 May 2024 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇺🇸United States lisagodare@gmail.com
Re-rolled the patch from #86 for 10.3.x - this is just a crutch for now, ultimately the merge request is the better option.
- 🇺🇸United States lisagodare@gmail.com
I'm just going to try that again, this time with the missing new files.
- 🇫🇷France Roman_L
Thank you @lisagodare !
Applied the patch #109 with core 10.3.1 and it solves this creation issue i had with a custom bundle, + entity reference & views selection.