Berlin
Account created on 14 September 2007, over 16 years ago
#

Merge Requests

More

Recent comments

🇩🇪Germany tobiasb Berlin

I added a new constraint AutoCreateEntityBundleExists; but I have no idea how to test it on the drupal way. I know there are other constraints, but their looks easier.

🇩🇪Germany tobiasb Berlin

Time to move.

Fyi: The maintainer Travis Tomka (droath) is active on drupal.org but it seems he has disable notification or something similar.

🇩🇪Germany tobiasb Berlin

@alexpott The issue was created before the fix of 🐛 Update composer metapackages Active was commited.

And because 11.x is a "main" branch, is \Drupal::Version 11.0.0-dev correct with the combination of the fix 🐛 Update composer metapackages Active .

So we can closed the MR/Issue, but we can still wait until @benjifisher say the same.

🇩🇪Germany tobiasb Berlin

At the moment nothing. The question is, is the branch 11.x === 11.0.x, then later 11.1.x ....Like a branch alias. (I would say yes) Then the MR/Issue can be closed. Or should the branch and \Drupal::Version in branch 11.x be unique?

🇩🇪Germany tobiasb Berlin

In case 11.x should reflect the latest minor version, then bug was fixed via 🐛 Update composer metapackages Active .

🇩🇪Germany tobiasb Berlin

Changes was not merged/commited into 11.x branch.

🇩🇪Germany tobiasb Berlin

In my use case where I get the Notice is a problem drush deploy vs. drush updb/cim/cr.

And I also got than a exception when I opened a page which use the missing route.

The hook_module_implements_alter from views_local_tasks module was not called/empty in drush deploy which results in broken routes.

So I vote for assert-only patch or closed (works as designed). :D

🇩🇪Germany tobiasb Berlin

I created a new issue #3443397: Allows to configure Apple-touch icon, theme-color. to make it possible to set/configure more than favicon. Current fix.When custom favicon set, do not print anything and use the else case, which overrides the custom favicon.

🇩🇪Germany tobiasb Berlin

FullyValidatable as a constraint is not valid for Drupal core < 10.3. See CR https://www.drupal.org/node/3404425.

So I would just leave as a todo.

🇩🇪Germany tobiasb Berlin

fyi: It is not possible to set a translation context for a specific configuration value of a vocabulary name. Only for all vocabulary names or none.

🇩🇪Germany tobiasb Berlin

Fyi: The patch file is the history of all commits. Better is to use just the diff for composer-patches.

🇩🇪Germany tobiasb Berlin

For the "Is none of" use case I believe this part needs to be untouched. At least then it works again for list fields.

@@ -275,8 +292,13 @@ public function addFilter() {
     // is set to TRUE, conditions will be added.
     $add_condition = TRUE;
     if ($operator == 'not') {
-      $value = NULL;
-      $operator = 'IS NULL';
+      if (count($value) > 1) {
+        $operator = 'NOT IN';
+      }
+      else {
+        $value = is_array($value) ? array_pop($value) : $value;
+        $operator = '!=';
+      }
       $add_condition = FALSE;
     }
     elseif ($operator == 'or' && empty($options['reduce_duplicates'])) {
🇩🇪Germany tobiasb Berlin

I believe this is a false positive.

$object->getCardinality() === 1
      ? array_shift($cacheable_normalizations) ?: CacheableNormalization::permanent(NULL)
      : CacheableNormalization::aggregate($cacheable_normalizations);

Is the same example 1 ? 2 ?: 3 : 4 from https://wiki.php.net/rfc/ternary_associativity which should not make any problems.

🇩🇪Germany tobiasb Berlin

You need to add the content access filter.

🇩🇪Germany tobiasb Berlin

tobiasb changed the visibility of the branch 2800875-autocreate-for-entity to hidden.

🇩🇪Germany tobiasb Berlin

tobiasb changed the visibility of the branch 2800875-autocreate-for-entity-D8 to hidden.

🇩🇪Germany tobiasb Berlin

tobiasb changed the visibility of the branch 2800875-autocreate-entity to hidden.

🇩🇪Germany tobiasb Berlin

There is a stable release for Drupal: ^8 || ^9 || ^10.

🇩🇪Germany tobiasb Berlin

There is a stable release for Drupal: ^8 || ^9 || ^10.

🇩🇪Germany tobiasb Berlin

This was fixed by drupal core release 10.2.3.

🇩🇪Germany tobiasb Berlin

This was fixed by drupal core release 10.2.3.

🇩🇪Germany tobiasb Berlin

tobiasb changed the visibility of the branch 3362423-incompatibility-with-multilingual to hidden.

🇩🇪Germany tobiasb Berlin

I added your suggested changes, but only those which does not increase the scope of the issue.

Production build 0.67.2 2024