🇩🇪Germany @tobiasb

Commited. Rector made oneliner for media id.

Rebased && add missing call to setDeprecationsEnabled.

tobiasb → created an issue.

Ok, as mention in #2426607: Calculates and adds dependencies of views display extender → a dependency is not a option because this would delete the view.

Therefore -> views_modules_uninstalled clean-up the config and ViewsConfigUpdater cleanup the config for uninstalled extender.

I do not understand, whether is missing todo or not. just with the patch views does not add the dependency via \Drupal\views\Plugin\views\display\DisplayPluginBase::calculateDependencies. It does also not call \Drupal\views\Plugin\views\display_extender\DisplayExtenderPluginBase::applies.

There is a plugin_type display_extender in \Drupal\views\Plugin\views\display\DisplayPluginBase::getAllPlugins, but always NULL, when used in \Drupal\views\Plugin\views\display\DisplayPluginBase::calculateDependencies.

I believe we need something like #2426607: Calculates and adds dependencies of views display extender → , which use \Drupal\views\Plugin\views\display_extender\DisplayExtenderPluginBase::applies.

tobiasb → made their first commit to this issue’s fork.

@larowlan

The constraint Email skips a empty string/null (See note https://symfony.com/doc/current/reference/constraints/Email.html). With:

email:
  label: 'Email'
  class: '\Drupal\Core\TypedData\Plugin\DataType\Email'
  constraints:
    NotBlank: {}
    Email:
      message: "%value is not a valid email address."

We would get "This value should not be blank. " as a error message.

tobiasb → made their first commit to this issue’s fork.

The update test is in core/modules/views/tests/src/Functional/Update/UserRememberRolesFilterSettingTest.php.

greggles → credited tobiasb → .

tobiasb → changed the visibility of the branch 10.2.x to hidden.

tobiasb → changed the visibility of the branch cherry-pick-bf09691e to hidden.

tobiasb → made their first commit to this issue’s fork.

Extra click for more secondary actions is for a drop-button the expected behavior, because this is a drop-button form-element.

When configured only 1 time-slot then Clear is the primary action.

tobiasb → made their first commit to this issue’s fork.

No. The static patch is for https://www.drupal.org/project/openculturas → ;-).

tobiasb → made their first commit to this issue’s fork.

tobiasb → made their first commit to this issue’s fork.

I added 2.4.x as dev-release and also change the target branch for the MR, therefore it needs a reroll/rebase.

Commited to 2.4.x and 2.3.x.

joachim namyslo → credited tobiasb → .

joachim namyslo → credited tobiasb → .

joachim namyslo → credited tobiasb → .

joachim namyslo → credited tobiasb → .

joachim namyslo → credited tobiasb → .

joachim namyslo → credited tobiasb → .

joachim namyslo → credited tobiasb → .

joachim namyslo → credited tobiasb → .

joachim namyslo → credited tobiasb → .

Thanks merged to 8.1.x and 2.0.x.

Thanks removed.

tobiasb → created an issue.

joachim namyslo → credited tobiasb → .

You need to install address module v1 (Which does not support Drupal core 11). I added a link.

tobiasb → created an issue.

tobiasb → created an issue.

No, this does not work, because I do not use v2 of address module, therefore there no "addressLine3".

With this changes you get a warning, when you do not use v2 of address module.

Warning: Undefined array key "addressLine3" in Drupal\address_display\Plugin\Field\FieldFormatter\AddressDisplayFormatter->getLabels() (line 115 of modules/contrib/address_display/src/Plugin/Field/FieldFormatter/AddressDisplayFormatter.php).

hexabinaer → credited tobiasb → .

anonymous (0) has is also valid owner. When you open Node 8 you should see owner.

❯ ddev drush php
Psy Shell v0.12.4 (PHP 8.1.30 — cli) by Justin Hileman
OpenCulturas (Drupal 10.3.6)
> \Drupal\node\Entity\Node::load(100)->getOwnerId();
= "0"

Something other must be broken.

Thx. Commited to 2.3.x and cherry-picked to 2.2.x. As a reminder there is also a block "Bookmark flag icon".

Technically it is still not possible, to set a own active_domain. But I can not remember why it was needed.

    $url = Url::fromUserInput("/admin", ["active_domain" => Domain::load("my_domain_2")]);
    $form['link'] = [
      '#type' => 'link',
      '#url' => $url,
      '#title' => $url->toString()
    ];

fyi: Simple config does not support the concept of dependencies.

Thx. Commited to 2.3.x and cherry-picked to 2.2.x.

MR updated + missing type hints.

tobiasb → made their first commit to this issue’s fork.

MR updated + missing typehints.

tobiasb → made their first commit to this issue’s fork.

I move the patch into a MR and fixes the rejected changes + typehints.

The post update uses now core/modules/views/src/ViewsConfigUpdater.php and moves the test into \Drupal\Tests\views\Functional\Plugin\FilterTest, because there are also other test for \Drupal\views\Plugin\views\filter\FilterPluginBase.

tobiasb → made their first commit to this issue’s fork.

tobiasb → made their first commit to this issue’s fork.

tobiasb → created an issue.

tobiasb → created an issue.

tobiasb → made their first commit to this issue’s fork.

The composer.json is broken.

tobiasb → made their first commit to this issue’s fork.

@johnv It is better to write your questions in the MR.

* IIFEs does not have a function name. example: https://git.drupalcode.org/project/drupal/-/blob/11.x/core/misc/ajax.js?...

* The check for slot is gone

* I reuse the pattern data-drupal-selector again

Drupal core does not support native buttons via form api, therefore we hardcode the buttons. But I added a todo with a link to 📌 Use form element type instead of Needs work .

Lets use the officially tag.

I do not like the way. I mean you can just add cast by yourself. there is no win/improvement without do the cast by default.

$id = (int) $entity->getRevisionId(); // NULL -> 0
if ($id) {
  // Do something.
}

Cast by default:

$id = $entity->getRevisionId(); // NULL || >= 1
if ($id) {
  // Do something.
}

I would just do the cast by default in 12.x.

@amer cloudy

You need to keep the headline and custom text below the headline.

tobiasb → made their first commit to this issue’s fork.

placeholder is also

tobiasb → created an issue. See original summary → .

@cilefen

The caller are spambots. Spambots does not do what we want. ;-)

I mean do we have issue like:

Why does this not work?

$config = \Drupal::configFactory()->getEditable('Über.settings');

or

drush cget 'Über.settings'

The patch does what would happen, when you only use ASCII or postgres (?). Page 404, so I am happy. :D

The exception DatabaseExceptionWrapper in the new test are not thrown or should not. So try/catch can be removed.

I would replace it with just a request to /node/add/Über which should return a 404.
With postgres this should already throw a not found exception.

And because we do not use native typehints to force config name is string. the $value should not be null in mb_check_encoding (deprecated).

Such request are done by spambots, which triggers a false-positive in your app-monitoring software. So I am happy, with a notfound exception, but not with any other which triggers a false-positive problem.