🇩🇪Germany @tobiasb

Yes, 🐛 MediaLibraryUiBuilder service does not properly allow additional contextual filter arguments Needs work resolves the issue.

Rebased. Test-Only fails.

But I will also test the fix in a real use-case.

tobiasb → made their first commit to this issue’s fork.

It was fixed by 🐛 "More" Text doesn't support Tokens, even if it says it does. Active .

tobiasb → created an issue.

tobiasb → made their first commit to this issue’s fork.

MR was merged.

tobiasb → created an issue.

Fyi: bef_datepickers.js does nothing, because $.fn.datepicker is not defined without a loaded jquery_ui_datepicker/datepicker.. Which was removed in 📌 Remove dependency on jquery_ui_datepicker Needs work .

When jquery_ui_datepicker/datepicker is loaded, then the date input has the jquery datepicker widget behind the native date picker from the browser. :D

Thanks, committed with small changes to make PHPStan happy.

Thx commited.

tobiasb → changed the visibility of the branch 3061935-fatal-error-trait to hidden.

The issue 🐛 Move content_translation I18nQueryTrait to migrate module Active was fixed in Drupal core and is part of 11.2. So I think we do not need this anymore.

tobiasb → made their first commit to this issue’s fork.

Thx commited.

For the log:

CR of drupal: https://www.drupal.org/node/3363700 →

tobiasb → made their first commit to this issue’s fork.

With NULL as value, we get an error.

Cannot load the "date_format" entity with NULL ID.

This hook can not be used by core/contrib.

When you update a module, you export the changed config locally and commit these changes. (drush updb/drush cex)

Deploy the code + config.

Then you can run drush deploy on the live site.

Both will be added to the view via update hook openculturas_map_update_10004.

I can not change the maintainer list. I just forgot once again. That I need to enable notifications for the project.

Saw the same.

ace.config.set was overridden by the old way, only workerPath worked

I replaced it and updated to latest version.

We do not use a patch atm.

hexabinaer → credited tobiasb → .

we use now ECA v2.

Patches are part of tour v2.

tobiasb → created an issue.

tobiasb → created an issue.

I removed the INSTALL.txt. A composer require is enough today.

tobiasb → made their first commit to this issue’s fork.

tobiasb → made their first commit to this issue’s fork.

From 8.x-2.1.

tobiasb → created an issue.

@dadderley You have something in your view which is broken.

The plugin ID comes from https://www.drupal.org/project/views_taxonomy_term_name_into_id →

Thx. Commited toi

It needs some love to make phpstan/rector happy.

@ressa

The issue is tagged with "Needs tests", which needs to be done.

@avpaderno

Sure.

The same problem with cookies module.

Remove header:true everything seems to be ok.

But there is also a problem with navigation-utils.js because it does not use "Drupal~behavior", so DOM can be not ready/fully loaded.

tobiasb → created an issue.

No answer until now.

Time for the next step.

I relabeled as a bug report, because I cherry-picked it into 2.4.x.

I relabeled as a bug report, because I cherry-picked it into 2.4.x.

D7 is gone. So bumping Version to 4.x.

There was a test :D

I created a new MR, because I can change the target branch.

tobiasb → changed the visibility of the branch 2985400-urlcreatefromrequest-ignores-query to hidden.

tobiasb → made their first commit to this issue’s fork.

Seems to work fine. It still try to find a translation for en (see screenshot), but not for remote, when the remote uri is build with default server pattern. (ftp.drupal.org)

So with PrivateStream and \Drupal\Core\StreamWrapper\PrivateStream::getExternalUrl the view links to system/files/my.po, which does not exists, but that is ok. The file is then removed, when file_cron cleanups temporary files.

Better would be. Upload file -> import translation -> remove file. But this is out of scope.

Rethinking.

Based on LocalStream -> getExternalUrl-> exception -> yes please.
Based on PrivateStream -> getExternalUrl -> exception -> why?

Removing \Drupal\locale\StreamWrapper\TranslationsStream::getExternalUrl would use \Drupal\Core\StreamWrapper\PrivateStream::getExternalUrl then and no Change record is required.

I need to review it in a real drupal installation.

We need to find the place where drupal tries to fetch the translation from l.d.o, so that we ca avoid the step.

The installer needs all languages for InstallerTranslationMultipleLanguageKeepEnglishTest.

And I believe we locale_translation_batch_status_check() is right place to start.

tobiasb → changed the visibility of the branch 11.x to hidden.

I added the changes from 104 + native typehint. But then I saw getExternalUrl was removed, which I added again.

Ok, forget it. setTimestamp wants a int. Unless we are calling the origin DateTime::createFromTimestamp in >= php8.4.

I move the test to the unit test.

Co-maintainer Oliver Bethke https://www.drupal.org/u/ollibolli → wrote me, he can not add me as a co-maintainer.

tobiasb → created an issue.

The test was a one-liner at the end. :D

tobiasb → created an issue.

Other examples https://git.drupalcode.org/project/openculturas/-/tree/2.5.x/profile/mod...

Use https://api.usps.com/oauth2/v3/authorize for authorization_uri.

Fyi: 8.4 comes with native \DateTime::createFromTimestamp, which allows int|float. https://github.com/php/php-src/commit/88f2dc626862b4c40ea20b8029838a8d0d....

$timestamp = 2147483647/1.1;

// Origin float
var_dump($timestamp);

$timestamp_casted = (int) $timestamp;

// Casted as int
var_dump($timestamp_casted);

// Output with float
var_dump(DateTime::createFromTimestamp($timestamp));

// Output with casted float
var_dump(DateTime::createFromTimestamp($timestamp_casted));

Output in 8.4.6:

float(1952257860.9090908)
int(1952257860)
object(DateTime)#1 (3) {
  ["date"]=>
  string(26) "2031-11-12 13:51:00.909091"
  ["timezone_type"]=>
  int(1)
  ["timezone"]=>
  string(6) "+00:00"
}
object(DateTime)#1 (3) {
  ["date"]=>
  string(26) "2031-11-12 13:51:00.000000"
  ["timezone_type"]=>
  int(1)
  ["timezone"]=>
  string(6) "+00:00"
}

So the best is to follow php-core.

tobiasb → created an issue.