🇩🇪Germany @tobiasb

Thx. Commited toi

It needs some love to make phpstan/rector happy.

@ressa

The issue is tagged with "Needs tests", which needs to be done.

@avpaderno

Sure.

The same problem with cookies module.

Remove header:true everything seems to be ok.

But there is also a problem with navigation-utils.js because it does not use "Drupal~behavior", so DOM can be not ready/fully loaded.

tobiasb → created an issue.

No answer until now.

Time for the next step.

I relabeled as a bug report, because I cherry-picked it into 2.4.x.

I relabeled as a bug report, because I cherry-picked it into 2.4.x.

D7 is gone. So bumping Version to 4.x.

There was a test :D

I created a new MR, because I can change the target branch.

tobiasb → changed the visibility of the branch 2985400-urlcreatefromrequest-ignores-query to hidden.

tobiasb → made their first commit to this issue’s fork.

Seems to work fine. It still try to find a translation for en (see screenshot), but not for remote, when the remote uri is build with default server pattern. (ftp.drupal.org)

So with PrivateStream and \Drupal\Core\StreamWrapper\PrivateStream::getExternalUrl the view links to system/files/my.po, which does not exists, but that is ok. The file is then removed, when file_cron cleanups temporary files.

Better would be. Upload file -> import translation -> remove file. But this is out of scope.

Rethinking.

Based on LocalStream -> getExternalUrl-> exception -> yes please.
Based on PrivateStream -> getExternalUrl -> exception -> why?

Removing \Drupal\locale\StreamWrapper\TranslationsStream::getExternalUrl would use \Drupal\Core\StreamWrapper\PrivateStream::getExternalUrl then and no Change record is required.

I need to review it in a real drupal installation.

We need to find the place where drupal tries to fetch the translation from l.d.o, so that we ca avoid the step.

The installer needs all languages for InstallerTranslationMultipleLanguageKeepEnglishTest.

And I believe we locale_translation_batch_status_check() is right place to start.

tobiasb → changed the visibility of the branch 11.x to hidden.

I added the changes from 104 + native typehint. But then I saw getExternalUrl was removed, which I added again.

Ok, forget it. setTimestamp wants a int. Unless we are calling the origin DateTime::createFromTimestamp in >= php8.4.

I move the test to the unit test.

Co-maintainer Oliver Bethke https://www.drupal.org/u/ollibolli → wrote me, he can not add me as a co-maintainer.

tobiasb → created an issue.

The test was a one-liner at the end. :D

tobiasb → created an issue.

Other examples https://git.drupalcode.org/project/openculturas/-/tree/2.5.x/profile/mod...

Use https://api.usps.com/oauth2/v3/authorize for authorization_uri.

Fyi: 8.4 comes with native \DateTime::createFromTimestamp, which allows int|float. https://github.com/php/php-src/commit/88f2dc626862b4c40ea20b8029838a8d0d....

$timestamp = 2147483647/1.1;

// Origin float
var_dump($timestamp);

$timestamp_casted = (int) $timestamp;

// Casted as int
var_dump($timestamp_casted);

// Output with float
var_dump(DateTime::createFromTimestamp($timestamp));

// Output with casted float
var_dump(DateTime::createFromTimestamp($timestamp_casted));

Output in 8.4.6:

float(1952257860.9090908)
int(1952257860)
object(DateTime)#1 (3) {
  ["date"]=>
  string(26) "2031-11-12 13:51:00.909091"
  ["timezone_type"]=>
  int(1)
  ["timezone"]=>
  string(6) "+00:00"
}
object(DateTime)#1 (3) {
  ["date"]=>
  string(26) "2031-11-12 13:51:00.000000"
  ["timezone_type"]=>
  int(1)
  ["timezone"]=>
  string(6) "+00:00"
}

So the best is to follow php-core.

tobiasb → created an issue.

tobiasb → created an issue.

tobiasb → created an issue.

tobiasb → created an issue.

Rebased and updated patch.

PR was merged.

joachim namyslo → credited tobiasb → .

Commited. Rector made oneliner for media id.

Rebased && add missing call to setDeprecationsEnabled.

tobiasb → created an issue.

Ok, as mention in #2426607: Calculates and adds dependencies of views display extender → a dependency is not a option because this would delete the view.

Therefore -> views_modules_uninstalled clean-up the config and ViewsConfigUpdater cleanup the config for uninstalled extender.

I do not understand, whether is missing todo or not. just with the patch views does not add the dependency via \Drupal\views\Plugin\views\display\DisplayPluginBase::calculateDependencies. It does also not call \Drupal\views\Plugin\views\display_extender\DisplayExtenderPluginBase::applies.

There is a plugin_type display_extender in \Drupal\views\Plugin\views\display\DisplayPluginBase::getAllPlugins, but always NULL, when used in \Drupal\views\Plugin\views\display\DisplayPluginBase::calculateDependencies.

I believe we need something like #2426607: Calculates and adds dependencies of views display extender → , which use \Drupal\views\Plugin\views\display_extender\DisplayExtenderPluginBase::applies.

tobiasb → made their first commit to this issue’s fork.

@larowlan

The constraint Email skips a empty string/null (See note https://symfony.com/doc/current/reference/constraints/Email.html). With:

email:
  label: 'Email'
  class: '\Drupal\Core\TypedData\Plugin\DataType\Email'
  constraints:
    NotBlank: {}
    Email:
      message: "%value is not a valid email address."

We would get "This value should not be blank. " as a error message.

tobiasb → made their first commit to this issue’s fork.

The update test is in core/modules/views/tests/src/Functional/Update/UserRememberRolesFilterSettingTest.php.

greggles → credited tobiasb → .

tobiasb → changed the visibility of the branch 10.2.x to hidden.

tobiasb → changed the visibility of the branch cherry-pick-bf09691e to hidden.

tobiasb → made their first commit to this issue’s fork.

Extra click for more secondary actions is for a drop-button the expected behavior, because this is a drop-button form-element.

When configured only 1 time-slot then Clear is the primary action.

tobiasb → made their first commit to this issue’s fork.

No. The static patch is for https://www.drupal.org/project/openculturas → ;-).

tobiasb → made their first commit to this issue’s fork.

tobiasb → made their first commit to this issue’s fork.

I added 2.4.x as dev-release and also change the target branch for the MR, therefore it needs a reroll/rebase.

Commited to 2.4.x and 2.3.x.

joachim namyslo → credited tobiasb → .

joachim namyslo → credited tobiasb → .

joachim namyslo → credited tobiasb → .

joachim namyslo → credited tobiasb → .

joachim namyslo → credited tobiasb → .

joachim namyslo → credited tobiasb → .

joachim namyslo → credited tobiasb → .

joachim namyslo → credited tobiasb → .

joachim namyslo → credited tobiasb → .

Thanks merged to 8.1.x and 2.0.x.

Thanks removed.

tobiasb → created an issue.