Filter out non-selected roles for the remember_roles setting in views

Hi, thanks for the work so far on this.

We have multiple sites built on the same systems but with some custom user roles. Comparing changes to views between sites has always thrown up the differences in these sections even though none have actually made any changes at all.

The latest patch didn't apply for me (D10.3.2), so I have created just a patch for the \Drupal\views\Plugin\views\filter\FilterPluginBase::validateExposeForm method from the latest D11 code.

This works stripping all of the redundant roles from the config.

Sorry, correct patch file for 10.3+/11.x

I move the patch into a MR and fixes the rejected changes + typehints.

The post update uses now core/modules/views/src/ViewsConfigUpdater.php and moves the test into \Drupal\Tests\views\Functional\Plugin\FilterTest, because there are also other test for \Drupal\views\Plugin\views\filter\FilterPluginBase.

Will probably need upgrade path tests.

Looks good!

The update test is in core/modules/views/tests/src/Functional/Update/UserRememberRolesFilterSettingTest.php.

Thank you, looks ready

Ran the 'test-only' test. It fails as it should. Pipeline otherwise all green.

Corrected one typo then remembered the etiquette so added two threads: code comment nits.

One comment on the post update, overall this looks good though.

Rebased && add missing call to setDeprecationsEnabled.

Looks great now, really nice to see this one ready.

Committed/pushed to 11.x, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.

tobiasb → closed merge request !9830

Hello,

I have just upgraded a site to 11.2.2.

When running the DB update script I get this:

 >  [notice] Update started: views_post_update_update_remember_role_empty
>  [error]  The "taxonomy_term_name_into_id" plugin does not exist. Valid plugin IDs for Drupal\views\Plugin\ViewsPluginManager are: taxonomy_term_name, user_name, entity:block, entity:block_content_type, entity:block_content, entity:captcha_point, entity:comment_type, entity:comment, entity:editor, entity:entity_subqueue, entity:entity_queue, entity:field_config, entity:field_storage_config, entity:file, entity:filter_format, entity:image_style, entity:imce_profile, entity:linkit_profile, entity:media_type, entity:media, entity:menu_link_content, entity:menu_position_rule, entity:metatag_defaults, entity:node, entity:node_type, entity:paragraphs_library_item, entity:path_alias, entity:redirect, entity:responsive_image_style, entity:search_page, entity:shortcut, entity:shortcut_set, entity:slick, entity:smart_date_format, entity:smart_date_rule, entity:smart_date_override, entity:menu, entity:action, entity:taxonomy_vocabulary, entity:taxonomy_term, entity:user, entity:user_role, entity:webform_options, entity:webform_submission, entity:webform, entity:pathauto_pattern, entity:xmlsitemap, entity:view, entity:paragraph, entity:paragraphs_type, entity:entity_view_display, entity:entity_form_mode, entity:entity_view_mode, entity:entity_form_display, entity:base_field_override, entity:date_format, none, numeric
>  [error]  Update failed: views_post_update_update_remember_role_empty
 [error]  Update aborted by: views_post_update_update_remember_role_empty
 [error]  Finished performing updates.

Pardon my ignorance, but is this related at all to this issue?

@dadderley You have something in your view which is broken.

The plugin ID comes from https://www.drupal.org/project/views_taxonomy_term_name_into_id →

@tobiasb
Thanks, I found the error in the view.

Doing updates today and found this in my logs. Searching for views_post_update_update_remember_role_empty leads me to this issue.

Listed as an update to execute
views update_remember_role_empty post-update Clean-up empty remember_roles display settings for views filters.

>  [notice] Update started: views_post_update_update_remember_role_empty
>  [warning] Undefined array key "type" ComponentValidator.php:90
>  [warning] Undefined array key "type" ComponentValidator.php:90
>  [warning] Undefined array key "type" ComponentValidator.php:90
>  [warning] Undefined array key "type" ComponentValidator.php:90
>  [warning] Undefined array key "type" ComponentValidator.php:90
>  [warning] Undefined array key "type" ComponentValidator.php:90
>  [warning] Undefined array key "type" ComponentValidator.php:90
>  [warning] Undefined array key "type" ComponentValidator.php:90
>  [warning] Undefined array key "type" ComponentValidator.php:90
>  [warning] Undefined array key "type" ComponentValidator.php:90
>  [warning] Undefined array key "type" ComponentValidator.php:90
>  [warning] Undefined array key "type" ComponentValidator.php:90
>  [notice] Update completed: views_post_update_update_remember_role_empty
 [success] Finished performing updates.

I cannot speak to the issues that cause or come from this; I am only reporting the message.