- @tobiasb opened merge request.
- 🇺🇸United States tr Cascadia
Is there a difference between the MR and the patch? I don't know what to review here. Patches should be hidden IMO because they can't be tested.
I'm in favor of doing this, but there really needs to be a test for this feature. There are lots of FunctionalJavascript tests in this module that you can use as an example.
- 🇩🇪Germany tobiasb Berlin
No. The static patch is for https://www.drupal.org/project/openculturas → ;-).
- 🇺🇸United States tr Cascadia
You can still use the patch that way if it's hidden. And hiding it will make it clear what needs to be reviewed and committed. The patch in this case seems to be just secondary and only so that a specific set of changes can be loaded by composer in another project.
Regardless, I don't see anything wrong with the MR. It works, but it still needs tests.